Mailing List Archive: [Bug 867] configure fails to find res_query/dn_expand on Linux amd64

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64

bugzilla-daemon at mindrot

May 11, 2004, 1:04 PM

Post #1 of 10 (665 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

Summary: configure fails to find res_query/dn_expand on Linux
amd64
Product: Portable OpenSSH
Version: 3.8.1p1
Platform: Other
URL: http://bugs.debian.org/242462
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Build system
AssignedTo: openssh-bugs@mindrot.org
ReportedBy: cjwatson@debian.org

Debian bug #242462 from Kurt Roeckx <Q@ping.be> reports:

It seems configure is unable to detect res_query and others in
libresolv because resolv.h wasn't included. It changes it to
__res_query, which is how it's called in the lib too.

The reason this works on some architectures is that they have a
weak alias from res_query to __res_query, but architectures (like
amd64) starting from glibc 2.2 or later don't have that.

The right thing to do definitely seems to be for configure to use the documented
interface to res_query (i.e. #include <resolv.h>, compile) rather than poking
about in libraries for it by hand. I'll attach Kurt's patch in a moment.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 11, 2004, 1:05 PM

Post #2 of 10 (662 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

------- Additional Comments From cjwatson@debian.org 2004-05-12 07:05 -------
Created an attachment (id=630)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=630&action=view)
look for res_query using compilation test

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 11, 2004, 3:47 PM

Post #3 of 10 (664 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

------- Additional Comments From dtucker@zip.com.au 2004-05-12 09:47 -------
(From update of attachment 630)
>- AC_SEARCH_LIBS(res_query, resolv)
>- AC_SEARCH_LIBS(dn_expand, resolv)
>+ AC_MSG_CHECKING(for res_query)
>+ AC_TRY_LINK_FUNC(res_query, AC_MSG_RESULT(yes),
>+ AC_MSG_RESULT(no))

The new check is not going to look for res_query in libresolv, is it?

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 11, 2004, 4:00 PM

Post #4 of 10 (663 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

------- Additional Comments From cjwatson@debian.org 2004-05-12 10:00 -------
The portion of the patch after the portion you quoted appears to do exactly
that. (On closer inspection it does look buggy, though; for starters it seems
that it'll add -lresolv twice on success.) I think the patch is trying to check
for res_query in libc first and then in libresolv.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 11, 2004, 4:08 PM

Post #5 of 10 (661 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

------- Additional Comments From dtucker@zip.com.au 2004-05-12 10:08 -------
Yeah, that looks like what it's trying to do but there's a missing [] pair. As
it stands -lresolv will be added whether it's needed or not since the block I
quoted doesn't actually do anything except generate a message.

There's no check for dn_query any more either, I don't know if that matters if
the res_query one always works (the HAVE_DN_EXPAND and HAVE_RES_QUERY defines
never get used).

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 11, 2004, 4:19 PM

Post #6 of 10 (663 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #630 is|0 |1
obsolete| |

------- Additional Comments From dtucker@zip.com.au 2004-05-12 10:19 -------
Created an attachment (id=631)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=631&action=view)
Check for res_query in libc before searching libresolv

This seems to be what was intended. In testing here it stops if res_query is
found in libc.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 11, 2004, 6:16 PM

Post #7 of 10 (661 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #631 is|0 |1
obsolete| |

------- Additional Comments From dtucker@zip.com.au 2004-05-12 12:16 -------
Created an attachment (id=633)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=633&action=view)
Keep AC_SEARCH_LIBS too.

Hmm, patch #631 breaks old Solaris boxes, which needs:
#include <sys/types.h>
#include <netinet/in.h>
#include <arpa/nameser.h>
#include <resolv.h>

I'm concerned that we might trip over dependancies on other platforms, so I
think we should keep the AC_SEARCH_LIBS calls and just add the new checks.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 12, 2004, 3:51 PM

Post #8 of 10 (662 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

------- Additional Comments From dtucker@zip.com.au 2004-05-13 09:51 -------
Kurt has confirmed that patch #633 fixes the problem for him, I think it's the
way to go if someone wants to OK it.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 12, 2004, 3:55 PM

Post #9 of 10 (663 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

------- Additional Comments From mouring@eviladmin.org 2004-05-13 09:55 -------
No quarms here, OK.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 867] configure fails to find res_query/dn_expand on Linux amd64 [ In reply to ]

bugzilla-daemon at mindrot

May 12, 2004, 6:05 PM

Post #10 of 10 (663 views)

http://bugzilla.mindrot.org/show_bug.cgi?id=867

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |822
nThis| |
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

------- Additional Comments From dtucker@zip.com.au 2004-05-13 12:05 -------
Thanks to all, slight variant of patch #633 (better spacing, eliminated double
"[[ ]]") committed to HEAD and 3.8.1 branch.

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.