Mailing List Archive

[Bug 859] getaddrinfo(host, "0", &hints, &res) may take extra cycles
http://bugzilla.mindrot.org/show_bug.cgi?id=859

Summary: getaddrinfo(host, "0", &hints, &res) may take extra
cycles
Product: Portable OpenSSH
Version: 3.8p1
Platform: All
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Miscellaneous
AssignedTo: openssh-bugs@mindrot.org
ReportedBy: yoshfuji@linux-ipv6.org


On some system(s), getaddrinfo() may take extra cycles when we use "0" for the
second argument. We probably may use NULL instead if the first argument is non-NULL.

(This problem is originally reported by John Devitofranceschi <jdvf@optonline.net>.)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 859] getaddrinfo(host, "0", &hints, &res) may take extra cycles [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=859





------- Additional Comments From yoshfuji@linux-ipv6.org 2004-05-02 15:35 -------
Created an attachment (id=622)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=622&action=view)
eliminate use of getaddrinfo(host, "0", &hints, &res) where getaddrinfo(host,
NULL, &hints, &res) is appricable




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 859] getaddrinfo(host, "0", &hints, &res) may take extra cycles [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=859

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |822
nThis| |
Status|NEW |ASSIGNED
Component|Miscellaneous |sshd
Keywords| |openbsd, patch
Version|3.8p1 |-current



------- Additional Comments From dtucker@zip.com.au 2004-05-12 13:09 -------
I think the patch is correct, but I'm not sure if there was a reason for it
being changed. The CVS entry for the change was:

- markus@cvs.openbsd.org 2003/06/02 09:17:34
deprecate VerifyReverseMapping since it's dangerous if combined
with IP based access control as noted by Mike Harding; replace with
a UseDNS option, UseDNS is on by default and includes the
VerifyReverseMapping check; with itojun@, provos@, jakob@ and deraadt@
ok deraadt@, djm@

Also, this issue is mentioned in bug #689, but it's not exactly the same issue
so I'm keeping them as separate bugs for now.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.