Mailing List Archive

http://bugzilla.mindrot.org/show_bug.cgi?id=558





------- Additional Comments From dtucker@zip.com.au 2003-09-09 15:10 -------
Created an attachment (id=391)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=391&action=view)
Move other libgen tests after dirname test, remove first libgen.h test.

I think the attached patch will solve this: it removes the extra libgen.h test
and only defines HAVE_LIBGEN_H if HAVE_DIRNAME gets defined. Hopefully this
won't break anything else... if it does we'll probably need a
"DIRNAME_IS_CONST " test or something.

The ChangeLog entry for the previous libgen.h change is:
revision 1.107
date: 2003/02/24 01:47:16; author: djm; state: Exp; lines: +3 -3
- (djm) Most of Bug #499: Cygwin compile fixes for new progressmeter

I have confirmed that is fixes the problem on Solaris 2.5.1 and that Cygwin
still builds after this change. OK?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=558





------- Additional Comments From alex.kiernan@thus.net 2003-09-09 15:43 -------
The patch is (modulo exchanging the order of the final basename & getspnam
checks), identical to what I've been using locally to get the build to work on
Solaris 2.5.1. Seems extremely likely that this fixes the problem.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=558

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |627
nThis| |
Status|NEW |ASSIGNED



------- Additional Comments From dtucker@zip.com.au 2003-09-09 16:17 -------
Thanks, I'll put this in the queue to be fixed for 3.7.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=558

djm@mindrot.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #391| |ok
Status| |



------- Additional Comments From djm@mindrot.org 2003-09-11 13:18 -------
(From update of attachment 391)
Looks fine to me




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=558

dtucker@zip.com.au changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED



------- Additional Comments From dtucker@zip.com.au 2003-09-11 14:45 -------
Fixed, thanks.

20030911
- (dtucker) [configure.ac] Bug #588, #615: Move other libgen tests to after
the dirname test, to allow a broken dirname to be detected correctly.
Based partially on patch supplied by alex.kiernan at thus.net. ok djm@




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.