Mailing List Archive

Re: nessus-core/nessus/prefs_dialog prefs_plugins.c, 1.45.4.2, 1.45.4.3
Hi Renaud,

IIUC this change removes, apart from some "if 0"-deactivated code,
the "Upload Plugin" feature from the client.

Should I remove the "Upload Plugin" feature from
CVS HEAD and the users manual as well?

Best

Jan

On Thu, Feb 03, 2005 at 03:24:58PM -0500, renaud@nessus.org wrote:
> Update of /usr/local/cvs/nessus-core/nessus/prefs_dialog
> In directory raccoon.nessus.org:/tmp/cvs-serv5184
>
> Modified Files:
> Tag: NESSUS_2_2
> prefs_plugins.c
> Log Message:
> bugfix
>
> Index: prefs_plugins.c
> ===================================================================
> RCS file: /usr/local/cvs/nessus-core/nessus/prefs_dialog/prefs_plugins.c,v
> retrieving revision 1.45.4.2
> retrieving revision 1.45.4.3
> diff -u -d -r1.45.4.2 -r1.45.4.3
> --- prefs_plugins.c 21 Jan 2005 15:17:40 -0000 1.45.4.2
> +++ prefs_plugins.c 3 Feb 2005 20:24:55 -0000 1.45.4.3
> @@ -77,21 +77,6 @@
>
>
>
> -static int hdl_plugin_upload(w, y)
> - GtkWidget * w, * y;
> -{
> - GtkWidget * filew = gtk_file_selection_new("Select file");
> - gtk_signal_connect(GTK_OBJECT(GTK_FILE_SELECTION(filew)->ok_button),
> - "clicked", (GtkSignalFunc)file_selected, filew);
> -
> - gtk_signal_connect_object (GTK_OBJECT (GTK_FILE_SELECTION (filew)->cancel_button),
> - "clicked",
> - GTK_SIGNAL_FUNC (file_dialog_hide),
> - GTK_OBJECT (filew));
> - gtk_widget_show(filew);
> - return 0;
> -}
> -
>
>
> static int warning_expl()
> @@ -221,29 +206,6 @@
> }
>
>
> -static int
> -enable_all_but_dos(w, ctrls)
> - GtkWidget * w;
> - struct arglist * ctrls;
> -{
> - struct arglist * buttons = arg_get_value(ctrls, "families_buttons");
> - if(buttons)
> - {
> - while(buttons->next)
> - {
> - family_enable(buttons->name, Plugins, ENABLE_FAMILY_BUT_DOS);
> - gtk_object_set_data(GTK_OBJECT(buttons->value), "be_lazy", (void*)1);
> - if(family_enabled(buttons->name, Plugins))
> - gtk_toggle_button_set_state(GTK_TOGGLE_BUTTON(buttons->value), 1);
> - else
> - gtk_toggle_button_set_state(GTK_TOGGLE_BUTTON(buttons->value), 0);
> - gtk_object_remove_data(GTK_OBJECT(buttons->value), "be_lazy");
> - buttons = buttons->next;
> - }
> - }
> - pluginset_reload(Plugins, Scanners);
> - return 0;
> -}
>
>
>
> @@ -302,6 +264,14 @@
> gtk_signal_connect(GTK_OBJECT(button),
> "clicked",
> GTK_SIGNAL_FUNC(enable_all),
> + ctrls);
> +
> + gtk_box_pack_start(GTK_BOX(hbox), button, TRUE, TRUE, 0);
> + gtk_widget_show(button);
> + button = gtk_button_new_with_label("Disable all");
> + gtk_signal_connect(GTK_OBJECT(button),
> + "clicked",
> + GTK_SIGNAL_FUNC(disable_all),
> ctrls);
>
> gtk_box_pack_start(GTK_BOX(hbox), button, TRUE, TRUE, 0);
>
> _______________________________________________
> Nessus-cvs mailing list
> Nessus-cvs@list.nessus.org
> http://mail.nessus.org/mailman/listinfo/nessus-cvs

--
Jan-Oliver Wagner http://intevation.de/~jan/

Intevation GmbH http://intevation.de/
FreeGIS http://freegis.org/
Re: Re: nessus-core/nessus/prefs_dialog prefs_plugins.c, 1.45.4.2, 1.45.4.3 [ In reply to ]
On Mon, Feb 07, 2005 at 10:39:20AM +0100, Jan-Oliver Wagner wrote:
> Hi Renaud,
>
> IIUC this change removes, apart from some "if 0"-deactivated code,
> the "Upload Plugin" feature from the client.
>
> Should I remove the "Upload Plugin" feature from
> CVS HEAD and the users manual as well?

Yes please. You can also port my list sorting function to sort the
plugins names and families in the GUI.

Thanks,

-- Renaud
Re: Re: nessus-core/nessus/prefs_dialog prefs_plugins.c, 1.45.4.2, 1.45.4.3 [ In reply to ]
On Mon, Feb 07, 2005 at 10:27:26AM -0500, Renaud Deraison wrote:
> On Mon, Feb 07, 2005 at 10:39:20AM +0100, Jan-Oliver Wagner wrote:
> > IIUC this change removes, apart from some "if 0"-deactivated code,
> > the "Upload Plugin" feature from the client.
> >
> > Should I remove the "Upload Plugin" feature from
> > CVS HEAD and the users manual as well?
>
> Yes please. You can also port my list sorting function to sort the
> plugins names and families in the GUI.

I will remove the Upload feature entirely from Nessus Client then.

The sorting stuff I already ported this morning :-)

Best

Jan
--
Jan-Oliver Wagner http://intevation.de/~jan/

Intevation GmbH http://intevation.de/
FreeGIS http://freegis.org/
Re: Re: nessus-core/nessus/prefs_dialog prefs_plugins.c, 1.45.4.2, 1.45.4.3 [ In reply to ]
On Mon, Feb 07, 2005 at 05:07:31PM +0100, Jan-Oliver Wagner wrote:
> On Mon, Feb 07, 2005 at 10:27:26AM -0500, Renaud Deraison wrote:
> > On Mon, Feb 07, 2005 at 10:39:20AM +0100, Jan-Oliver Wagner wrote:
> > > IIUC this change removes, apart from some "if 0"-deactivated code,
> > > the "Upload Plugin" feature from the client.
> > >
> > > Should I remove the "Upload Plugin" feature from
> > > CVS HEAD and the users manual as well?
> >
> > Yes please. You can also port my list sorting function to sort the
> > plugins names and families in the GUI.
>
> I will remove the Upload feature entirely from Nessus Client then.

Done now.

There are some superflous functions in plugin_prefs.c in the
2_2 branch. I do not dare to commit something to the stable
branch, so I attached my patch for review.

Best

Jan
--
Jan-Oliver Wagner http://intevation.de/~jan/

Intevation GmbH http://intevation.de/
FreeGIS http://freegis.org/