On Wed, Dec 19, 2018 at 04:16:35PM -0600, David Engel wrote:
> On Wed, Dec 19, 2018 at 04:51:31PM -0500, Peter Bennett wrote:
> >
> >
> > On 12/19/18 3:45 PM, David Engel wrote:
> > > On Wed, Dec 19, 2018 at 10:02:35AM -0600, David Engel wrote:
> > > > On Wed, Dec 19, 2018 at 07:10:31AM +0000, Mark Kendall wrote:
> > > > > On Wed, Dec 19, 2018, 2:52 AM David Engel <david@istwok.net wrote:
> > > > >
> > > > > > On Mon, Dec 17, 2018 at 08:20:57PM +0000, Mark Kendall wrote:
> > > > > > > I have a patch for the UYVY code ready to go. It will fix the
> > > > > > > interlaced chroma issue and the precision problem. It is not at all
> > > > > > > invasive. If OpenGLVideo currently works without YV12 or UYVY, it will
> > > > > > > work after the change. It effectively removes the custom UYVY code. We
> > > > > > > still use UYVY but it is not as densely packed - so there is a larger
> > > > > > > texture in video memory but no sampling problem and no need for the
> > > > > > > extra filter stage.
> > > > > > Mark, the colors are now messed up on my nvidia shield and firetv
> > > > > > stick 4k when the YV12 option is not enabled. It looks like the red
> > > > > > and blue are reversed. I suspect commit 43b64d5c. The colors are
> > > > > > correct when YV12 is enabled and on Linux regardless of the YV12
> > > > > > setting.
> > > > > >
> > > > > > David
> > > > > > --
> > > > > >
> > > > > Sounds like the UV planes are swapped.
> > > > Yes, what I figured.
> > > >
> > > > > Must be an issue with the non-mmx packing code - which is the only thing I
> > > > > didn't think to check.
> > > > Also waht I figured.
> > > >
> > > > > Or perhaps an endianness issue?
> > > > All indications are the Shield is little endian so that's probably not
> > > > it.
> > > >
> > > > > Sitting on tarmac waiting for delayed flight to leave and won't be back
> > > > > until after Christmas - so can't look at it for a few days.
> > > > I'll see if I can figure it out.
> > > I don't see the obvious fix. My best guess is something is not
> > > accounting for GL_BGRA being set to GL_RGBA because the former is
> > > missing in Android's gl.h.
> > >
> > > David
> >
> > I have not tried these latest fixes. However, it has always been the case
> > that if you uncheck both YV12 and UVYV it defaults to BGRA and displays
> > mangled colors in android. Perhaps this is related to the new problem.
>
> It's probably the same long standing problem. The latest change
> removes the UYVY option and causes the default format to be BGRA. I
> wonder if defaulting to RGBA would work. Is there an advantage to
> using BGRA when available instead of RGBA?
Strike the "I wonder" part. They are the same on Android so it
shouldn't matter. My best guess is still that something in the
kGLFilterYUV2RGB support isn't accounting for them being the same.
David
--
David Engel
david@istwok.net
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
> On Wed, Dec 19, 2018 at 04:51:31PM -0500, Peter Bennett wrote:
> >
> >
> > On 12/19/18 3:45 PM, David Engel wrote:
> > > On Wed, Dec 19, 2018 at 10:02:35AM -0600, David Engel wrote:
> > > > On Wed, Dec 19, 2018 at 07:10:31AM +0000, Mark Kendall wrote:
> > > > > On Wed, Dec 19, 2018, 2:52 AM David Engel <david@istwok.net wrote:
> > > > >
> > > > > > On Mon, Dec 17, 2018 at 08:20:57PM +0000, Mark Kendall wrote:
> > > > > > > I have a patch for the UYVY code ready to go. It will fix the
> > > > > > > interlaced chroma issue and the precision problem. It is not at all
> > > > > > > invasive. If OpenGLVideo currently works without YV12 or UYVY, it will
> > > > > > > work after the change. It effectively removes the custom UYVY code. We
> > > > > > > still use UYVY but it is not as densely packed - so there is a larger
> > > > > > > texture in video memory but no sampling problem and no need for the
> > > > > > > extra filter stage.
> > > > > > Mark, the colors are now messed up on my nvidia shield and firetv
> > > > > > stick 4k when the YV12 option is not enabled. It looks like the red
> > > > > > and blue are reversed. I suspect commit 43b64d5c. The colors are
> > > > > > correct when YV12 is enabled and on Linux regardless of the YV12
> > > > > > setting.
> > > > > >
> > > > > > David
> > > > > > --
> > > > > >
> > > > > Sounds like the UV planes are swapped.
> > > > Yes, what I figured.
> > > >
> > > > > Must be an issue with the non-mmx packing code - which is the only thing I
> > > > > didn't think to check.
> > > > Also waht I figured.
> > > >
> > > > > Or perhaps an endianness issue?
> > > > All indications are the Shield is little endian so that's probably not
> > > > it.
> > > >
> > > > > Sitting on tarmac waiting for delayed flight to leave and won't be back
> > > > > until after Christmas - so can't look at it for a few days.
> > > > I'll see if I can figure it out.
> > > I don't see the obvious fix. My best guess is something is not
> > > accounting for GL_BGRA being set to GL_RGBA because the former is
> > > missing in Android's gl.h.
> > >
> > > David
> >
> > I have not tried these latest fixes. However, it has always been the case
> > that if you uncheck both YV12 and UVYV it defaults to BGRA and displays
> > mangled colors in android. Perhaps this is related to the new problem.
>
> It's probably the same long standing problem. The latest change
> removes the UYVY option and causes the default format to be BGRA. I
> wonder if defaulting to RGBA would work. Is there an advantage to
> using BGRA when available instead of RGBA?
Strike the "I wonder" part. They are the same on Android so it
shouldn't matter. My best guess is still that something in the
kGLFilterYUV2RGB support isn't accounting for them being the same.
David
--
David Engel
david@istwok.net
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org