Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: da367dc1c09d6f40f4363c0f0219555918b9a0bb
https://github.com/MythTV/mythtv/commit/da367dc1c09d6f40f4363c0f0219555918b9a0bb
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M mythplugins/mythmusic/mythmusic/visualize.h
Log Message:
-----------
tidy: Fix "defaulted function deleted" warning in visualize.h.
The warning is from a class declaring a default constructor after its
parent has explicitly declared a non-default constructor. It turns
out this class is not necessary for the Spectrum visualizers to
function properly, so simply remove it.
Commit: 20c23fbb423957d84c296d4d4abf53d863e88356
https://github.com/MythTV/mythtv/commit/20c23fbb423957d84c296d4d4abf53d863e88356
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M mythplugins/mythmusic/mythmusic/playlist.cpp
M mythplugins/mythmusic/mythmusic/playlist.h
Log Message:
-----------
tidy: Fix "suspicious call arguments" warning.
Change the function argument names to be more self descriptive. Add a
doxygen comment describing the function.
Commit: d58a729ac53a91fd465c7bd22de6d045f5cd4550
https://github.com/MythTV/mythtv/commit/d58a729ac53a91fd465c7bd22de6d045f5cd4550
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M mythtv/libs/libmythbase/mythmiscutil.cpp
M mythtv/libs/libmythbase/serverpool.cpp
M mythtv/programs/mythbackend/mainserver.cpp
Log Message:
-----------
tidy: Fix a couple of "static member accessed through instance" warnings.
The indirection through an instance object is unnecessary, since
static functions can be directly accessed. Update the code to call
these functions directly.
Warnings newly detected after upgrading to the clang 17 compiler.
All changes made by clang-tidy.
https://clang.llvm.org/extra/clang-tidy/checks/readability/static-accessed-through-instance.html
Commit: 566e08b14f20e0fa4dc7f5cdc0cf3e01175e76d6
https://github.com/MythTV/mythtv/commit/566e08b14f20e0fa4dc7f5cdc0cf3e01175e76d6
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/programs/mythbackend/services/serviceUtil.cpp
M mythtv/programs/mythbackend/servicesv2/v2serviceUtil.cpp
Log Message:
-----------
tidy: Fix a couple of "use emplace" warnings.
The push functions require creating a temporary object before adding
the item to a list, while the emplace functions perform the same
action without the temporary. This results in cleaner code. Update
the code to use these more modern functions.
Warnings newly detected after upgrading to the clang 17 compiler.
All changes made by clang-tidy.
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-emplace.html
Commit: 573ed5f185d7b912603d2836ee5882bfcf71d41a
https://github.com/MythTV/mythtv/commit/573ed5f185d7b912603d2836ee5882bfcf71d41a
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythfrontend/custompriority.cpp
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/globalsettings.h
Log Message:
-----------
tidy: Disable a couple of erroneous warning messages.
1) The MythDRMDevice::GetModes can't possibly be converted to static
as it references member variables.
2) The PlaybackProfileConfig::swap function makes no attempt to
prevent throwing an exception.
3) The TruncateThread object in MainServer::HandleDeleteFile should be
automatically deleted by QRunnable once it finishes executing. There
is no memory leak.
4) The CustomPriority::loadData function doesn't lose the object
pointed to by the item variable 'item'. When MythUIButtonListItem
creates an item it is added to the list passed as the first argument,
so can still be referenced/deleted from there. There is no memory
leak.
Commit: 6d09c25dd43946785ed10df781facd38ce37e85d
https://github.com/MythTV/mythtv/commit/6d09c25dd43946785ed10df781facd38ce37e85d
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M mythtv/libs/libmythbase/http/mythhttpfile.h
Log Message:
-----------
tidy: Break circular header file dependency in mythhttpfile.h.
There is no need to include mythhttpresponse.h in this header file.
The HTTPResponse type is defined in mythhttptypes.h.
Compare: https://github.com/MythTV/mythtv/compare/271b7ed8d2fc...6d09c25dd439
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Home: https://github.com/MythTV/mythtv
Commit: da367dc1c09d6f40f4363c0f0219555918b9a0bb
https://github.com/MythTV/mythtv/commit/da367dc1c09d6f40f4363c0f0219555918b9a0bb
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M mythplugins/mythmusic/mythmusic/visualize.h
Log Message:
-----------
tidy: Fix "defaulted function deleted" warning in visualize.h.
The warning is from a class declaring a default constructor after its
parent has explicitly declared a non-default constructor. It turns
out this class is not necessary for the Spectrum visualizers to
function properly, so simply remove it.
Commit: 20c23fbb423957d84c296d4d4abf53d863e88356
https://github.com/MythTV/mythtv/commit/20c23fbb423957d84c296d4d4abf53d863e88356
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M mythplugins/mythmusic/mythmusic/playlist.cpp
M mythplugins/mythmusic/mythmusic/playlist.h
Log Message:
-----------
tidy: Fix "suspicious call arguments" warning.
Change the function argument names to be more self descriptive. Add a
doxygen comment describing the function.
Commit: d58a729ac53a91fd465c7bd22de6d045f5cd4550
https://github.com/MythTV/mythtv/commit/d58a729ac53a91fd465c7bd22de6d045f5cd4550
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M mythtv/libs/libmythbase/mythmiscutil.cpp
M mythtv/libs/libmythbase/serverpool.cpp
M mythtv/programs/mythbackend/mainserver.cpp
Log Message:
-----------
tidy: Fix a couple of "static member accessed through instance" warnings.
The indirection through an instance object is unnecessary, since
static functions can be directly accessed. Update the code to call
these functions directly.
Warnings newly detected after upgrading to the clang 17 compiler.
All changes made by clang-tidy.
https://clang.llvm.org/extra/clang-tidy/checks/readability/static-accessed-through-instance.html
Commit: 566e08b14f20e0fa4dc7f5cdc0cf3e01175e76d6
https://github.com/MythTV/mythtv/commit/566e08b14f20e0fa4dc7f5cdc0cf3e01175e76d6
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/programs/mythbackend/services/serviceUtil.cpp
M mythtv/programs/mythbackend/servicesv2/v2serviceUtil.cpp
Log Message:
-----------
tidy: Fix a couple of "use emplace" warnings.
The push functions require creating a temporary object before adding
the item to a list, while the emplace functions perform the same
action without the temporary. This results in cleaner code. Update
the code to use these more modern functions.
Warnings newly detected after upgrading to the clang 17 compiler.
All changes made by clang-tidy.
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-emplace.html
Commit: 573ed5f185d7b912603d2836ee5882bfcf71d41a
https://github.com/MythTV/mythtv/commit/573ed5f185d7b912603d2836ee5882bfcf71d41a
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythfrontend/custompriority.cpp
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/globalsettings.h
Log Message:
-----------
tidy: Disable a couple of erroneous warning messages.
1) The MythDRMDevice::GetModes can't possibly be converted to static
as it references member variables.
2) The PlaybackProfileConfig::swap function makes no attempt to
prevent throwing an exception.
3) The TruncateThread object in MainServer::HandleDeleteFile should be
automatically deleted by QRunnable once it finishes executing. There
is no memory leak.
4) The CustomPriority::loadData function doesn't lose the object
pointed to by the item variable 'item'. When MythUIButtonListItem
creates an item it is added to the list passed as the first argument,
so can still be referenced/deleted from there. There is no memory
leak.
Commit: 6d09c25dd43946785ed10df781facd38ce37e85d
https://github.com/MythTV/mythtv/commit/6d09c25dd43946785ed10df781facd38ce37e85d
Author: David Hampton <mythtv@love2code.net>
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M mythtv/libs/libmythbase/http/mythhttpfile.h
Log Message:
-----------
tidy: Break circular header file dependency in mythhttpfile.h.
There is no need to include mythhttpresponse.h in this header file.
The HTTPResponse type is defined in mythhttptypes.h.
Compare: https://github.com/MythTV/mythtv/compare/271b7ed8d2fc...6d09c25dd439
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits