Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: 5f9c32355f7e7c04498e2d3c6f1d70831ee497e1
https://github.com/MythTV/mythtv/commit/5f9c32355f7e7c04498e2d3c6f1d70831ee497e1
Author: David Hampton <mythtv@love2code.net>
Date: 2023-07-07 (Fri, 07 Jul 2023)
Changed paths:
M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
Log Message:
-----------
A couple of minor subtitle fixes.
1) Tidy pointed out a potential null pointer reference. Move the
validity test for a currentFrame and videoOut to before the new
external subtitles code. If either value is invalid, there's no need
to execute any of the subtitle code.
2) Clazy recommended changing the call to QObject::connect to include
a target object. Doing so will prevent the lambda from being called
once the object is deleted.
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Home: https://github.com/MythTV/mythtv
Commit: 5f9c32355f7e7c04498e2d3c6f1d70831ee497e1
https://github.com/MythTV/mythtv/commit/5f9c32355f7e7c04498e2d3c6f1d70831ee497e1
Author: David Hampton <mythtv@love2code.net>
Date: 2023-07-07 (Fri, 07 Jul 2023)
Changed paths:
M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
Log Message:
-----------
A couple of minor subtitle fixes.
1) Tidy pointed out a potential null pointer reference. Move the
validity test for a currentFrame and videoOut to before the new
external subtitles code. If either value is invalid, there's no need
to execute any of the subtitle code.
2) Clazy recommended changing the call to QObject::connect to include
a target object. Doing so will prevent the lambda from being called
once the object is deleted.
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits