Mailing List Archive

[MythTV/mythtv] d2cd22: subtitles: Don't manage the buffer assigned to a p...
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: d2cd226d2440b5fdd7df40e4f4476eefb71f5ab6
https://github.com/MythTV/mythtv/commit/d2cd226d2440b5fdd7df40e4f4476eefb71f5ab6
Author: David Hampton <mythtv@love2code.net>
Date: 2023-07-06 (Thu, 06 Jul 2023)

Changed paths:
M mythtv/libs/libmythtv/captions/textsubtitleparser.cpp

Log Message:
-----------
subtitles: Don't manage the buffer assigned to a packet.

Remove code that attempted to have FFmpeg reuse the same buffer each
time it read a subtitle. The FFmpeg code changes out the packet
buffer each time av_read_frame is called.

Refs #767.


Commit: f383ea9e8113ffada07327ffac768750e633ab74
https://github.com/MythTV/mythtv/commit/f383ea9e8113ffada07327ffac768750e633ab74
Author: David Hampton <mythtv@love2code.net>
Date: 2023-07-06 (Thu, 06 Jul 2023)

Changed paths:
M mythtv/libs/libmythtv/captions/subtitlereader.cpp
M mythtv/libs/libmythtv/captions/subtitlereader.h
M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
M mythtv/libs/libmythtv/captions/subtitlescreen.h

Log Message:
-----------
subtitles: Stop requesting external subs after FFmpeg returns empty.

After the last external subtitle has been read, FFmpeg will set the
packet buffer to nullptr and return an error code. Set a flag when
FFmpeg returns an error and stop calling every "pulse" to see if a new
subtitle is available. If the user seeks, assume that it could be a
backwards seek and start checking for subtitles again. Either a
subtitle will be returned on the next call to FFmpeg, or the code will
go back into "no more subtitles" mode.


Commit: 29980c7eaa250a20497d2e13be6fe61ebc0034ac
https://github.com/MythTV/mythtv/commit/29980c7eaa250a20497d2e13be6fe61ebc0034ac
Author: David Hampton <mythtv@love2code.net>
Date: 2023-07-06 (Thu, 06 Jul 2023)

Changed paths:
M mythtv/libs/libmythtv/captions/subtitlescreen.cpp

Log Message:
-----------
subtitles: Clean up a log message.


Commit: cde5b83c62b62c76b319ab8f6425d5f55afd57b6
https://github.com/MythTV/mythtv/commit/cde5b83c62b62c76b319ab8f6425d5f55afd57b6
Author: David Hampton <mythtv@love2code.net>
Date: 2023-07-06 (Thu, 06 Jul 2023)

Changed paths:
M mythtv/html/apps/backend/main.js
M mythtv/html/assets/i18n/en_US.json
M mythtv/html/backend/src/app/config/backend-warning/backend-warning.component.html
M mythtv/html/backend/src/app/dashboard/recordings/recordings.component.html
M mythtv/html/backend/src/app/dashboard/recrules/recrules.component.html
M mythtv/html/backend/src/app/dashboard/recrules/recrules.component.ts
M mythtv/html/backend/src/app/dashboard/videos/videos.component.html
M mythtv/html/backend/src/app/primeng.module.ts
M mythtv/html/backend/src/app/schedule/schedule.component.html
M mythtv/html/backend/src/app/schedule/schedule.component.ts
M mythtv/libs/libmythtv/recordingrule.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/programs/mythfrontend/customedit.cpp

Log Message:
-----------
A couple of subtitle changes.


Compare: https://github.com/MythTV/mythtv/compare/5e422b2853f2...cde5b83c62b6
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits