Mailing List Archive

[MythTV/mythtv] 58b0a8: coverity: Silence a couple of "auto causes copy" w...
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: 58b0a880698b865a2eb505647fc6492372f27d79
https://github.com/MythTV/mythtv/commit/58b0a880698b865a2eb505647fc6492372f27d79
Author: David Hampton <mythtv@love2code.net>
Date: 2022-11-30 (Wed, 30 Nov 2022)

Changed paths:
M mythtv/libs/libmythbase/mythplugin.cpp
M mythtv/programs/mythfrontend/videodlg.cpp

Log Message:
-----------
coverity: Silence a couple of "auto causes copy" warning.


Commit: daf2f8f90cc34084c3868fbf140b0ab0467b1354
https://github.com/MythTV/mythtv/commit/daf2f8f90cc34084c3868fbf140b0ab0467b1354
Author: David Hampton <mythtv@love2code.net>
Date: 2022-11-30 (Wed, 30 Nov 2022)

Changed paths:
M mythtv/libs/libmythmetadata/metadatadownload.cpp
M mythtv/libs/libmythtv/captions/cc608decoder.cpp
M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
M mythtv/libs/libmythtv/decoders/mythvdpaucontext.cpp
M mythtv/libs/libmythtv/decoders/mythvdpauhelper.cpp
M mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythui/mythuitextedit.cpp
M mythtv/libs/libmythui/x11colors.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythbackend/servicesv2/v2dvr.cpp
M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
M mythtv/programs/mythtv-setup/importicons.cpp

Log Message:
-----------
coverity: Use references to fix "auto causes copy" warnings.

These have also had "const" added to the type declaration as suggested
by the clang-tidy readability-qualified-auto check.


Commit: 2cdd122baca177afdbf40f532997a13c20e8be88
https://github.com/MythTV/mythtv/commit/2cdd122baca177afdbf40f532997a13c20e8be88
Author: David Hampton <mythtv@love2code.net>
Date: 2022-11-30 (Wed, 30 Nov 2022)

Changed paths:
M mythtv/libs/libmythbase/http/mythhttpranges.cpp
M mythtv/libs/libmythbase/mythcorecontext.cpp
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/recorders/hdhrchannel.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/programs/mythfrontend/videofileassoc.cpp
M mythtv/programs/mythfrontend/viewschedulediff.cpp

Log Message:
-----------
coverity: Use references to fix "auto causes copy" warnings. (2)

These have also had "const" added to the type declaration. These were
not suggested by the clang-tidy readability-qualified-auto check but
were determined by code inspection.


Commit: 34865370a8101398c4de620ba5cf26d9f7befbd9
https://github.com/MythTV/mythtv/commit/34865370a8101398c4de620ba5cf26d9f7befbd9
Author: David Hampton <mythtv@love2code.net>
Date: 2022-11-30 (Wed, 30 Nov 2022)

Changed paths:
M mythtv/libs/libmythui/mythuiprocedural.cpp

Log Message:
-----------
coverity: Fix dereference after null checks.

The earlier nullptr checks only print a warning message. They don't
guard against dereferencing the nullptr.


Commit: 5d456a56ad09d04626657bae7decb3b92059eed4
https://github.com/MythTV/mythtv/commit/5d456a56ad09d04626657bae7decb3b92059eed4
Author: David Hampton <mythtv@love2code.net>
Date: 2022-11-30 (Wed, 30 Nov 2022)

Changed paths:
M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

Log Message:
-----------
coverity: Add a nullptr check to avforatdecoder.

All other dereferences of m_ringBuffer in this function are preceded
by nullptr checks. This implies that this dereference also needs a
nullptr check.


Compare: https://github.com/MythTV/mythtv/compare/00e4fc531cb8...5d456a56ad09
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits