Mailing List Archive

[MythTV/mythtv] db57d7: clazy: Use isEmpty() instead of !count() etc.
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: db57d7341274ed11a7fe16a31b2e4cd504336517
https://github.com/MythTV/mythtv/commit/db57d7341274ed11a7fe16a31b2e4cd504336517
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mythmusic/mythmusic/streamview.cpp
M mythtv/libs/libmyth/backendselect.cpp
M mythtv/libs/libmyth/mediamonitor-unix.cpp

Log Message:
-----------
clazy: Use isEmpty() instead of !count() etc.


Commit: d9a34567e1a3f07e0f841faa16052892c8dab488
https://github.com/MythTV/mythtv/commit/d9a34567e1a3f07e0f841faa16052892c8dab488
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp
M mythtv/libs/libmythui/mythuitype.cpp
M mythtv/programs/mythbackend/mainserver.cpp

Log Message:
-----------
clazy: Fix "container inside loop" warnings.

Finds places defining containers inside loops. Defining them outside
the loop and using resize(0) or clear() will save memory allocations.


Commit: 6b66cc7041b83d1c73299edaa0e059980d8e1681
https://github.com/MythTV/mythtv/commit/6b66cc7041b83d1c73299edaa0e059980d8e1681
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mytharchive/mytharchive/fileselector.cpp
M mythtv/libs/libmyth/mythcontext.cpp
M mythtv/libs/libmythbase/logging.cpp
M mythtv/libs/libmythbase/mythcorecontext.cpp
M mythtv/libs/libmythbase/mythmiscutil.cpp
M mythtv/libs/libmythbase/mythsystemunix.cpp
M mythtv/libs/libmythbase/mythtimezone.cpp
M mythtv/libs/libmythbase/storagegroup.cpp
M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
M mythtv/libs/libmythtv/decoders/mythvdpaucontext.cpp
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/mheg/mhegic.cpp
M mythtv/libs/libmythtv/mheg/netstream.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/opengl/mythvaapiinterop.cpp
M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
M mythtv/libs/libmythui/devices/lirc_client.cpp
M mythtv/libs/libmythui/mythuifilebrowser.cpp
M mythtv/libs/libmythui/mythuiimage.cpp
M mythtv/libs/libmythupnp/httprequest.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/myth.cpp
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
M mythtv/programs/mythfrontend/themechooser.cpp

Log Message:
-----------
clazy: Fix "raw environment function" warnings.

Replace instances of getenv() with one of the qEnvironmentVariable()
family of functions.


Commit: c61ee90cf721a894cf72aec0f1d5db41cd6f098d
https://github.com/MythTV/mythtv/commit/c61ee90cf721a894cf72aec0f1d5db41cd6f098d
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/programs/mythfrontend/idlescreen.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
M mythtv/programs/mythwelcome/welcomedialog.cpp

Log Message:
-----------
clazy: Fix some "use chrono in qtimer" warnings.

From the docs: Find places where a number is used with QTimer's start,
setElapsed or singleShot methods, and suggests to use chrono literals
instead.

This batch of changes are for constant values that are converted to
chrono. These changes made by hand.


Commit: 4f39b916409fe77766a37a801776a857ed160753
https://github.com/MythTV/mythtv/commit/4f39b916409fe77766a37a801776a857ed160753
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mytharchive/mytharchive/logviewer.cpp
M mythplugins/mytharchive/mytharchive/videoselector.cpp
M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
M mythplugins/mythmusic/mythmusic/cdrip.cpp
M mythplugins/mythmusic/mythmusic/miniplayer.cpp
M mythplugins/mythmusic/mythmusic/streamview.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmconsole.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmplayer.cpp
M mythtv/libs/libmyth/guistartup.cpp
M mythtv/libs/libmythbase/housekeeper.cpp
M mythtv/libs/libmythbase/lcddevice.cpp
M mythtv/libs/libmythprotoserver/requesthandler/outboundhandler.cpp
M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
M mythtv/libs/libmythtv/mythplayerui.cpp
M mythtv/libs/libmythtv/recorders/httptsstreamhandler.cpp
M mythtv/libs/libmythui/mythdisplay.cpp
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythscreenstack.cpp
M mythtv/libs/libmythui/mythuibutton.cpp
M mythtv/libs/libmythui/mythuifilebrowser.cpp
M mythtv/libs/libmythupnp/websocket.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythfrontend/galleryinfo.cpp
M mythtv/programs/mythfrontend/idlescreen.cpp
M mythtv/programs/mythfrontend/themechooser.cpp
M mythtv/programs/mythfrontend/upnpscanner.cpp
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
M mythtv/programs/mythwelcome/welcomedialog.cpp

Log Message:
-----------
clazy: Fix some "use chrono in qtimer" warnings.

From the docs: Find places where a number is used with QTimer's start,
setElapsed or singleShot methods, and suggests to use chrono literals
instead.


Commit: e2acfa2dca47d868e6949e0040ba369f68cf81b4
https://github.com/MythTV/mythtv/commit/e2acfa2dca47d868e6949e0040ba369f68cf81b4
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythtv/previewgenerator.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythui/mythmainwindow.cpp
M mythtv/libs/libmythui/mythmainwindow.h
M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
M mythtv/programs/mythfrontend/playbackboxhelper.cpp

Log Message:
-----------
clazy: Fix "base class event" warnings.

From the docs: Warns when you return false inside your
QObject::event() or QObject::eventFilter() reimplementation. Instead
you should probably call the base class method, so the event is
correctly handled.


Commit: c3a7f64b36479607943ae46ffb2e489dc5ae008a
https://github.com/MythTV/mythtv/commit/c3a7f64b36479607943ae46ffb2e489dc5ae008a
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mythmusic/mythmusic/decoder.h
M mythplugins/mythmusic/mythmusic/decoderhandler.cpp
M mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp
M mythtv/libs/libmythmetadata/dbaccess.cpp
M mythtv/libs/libmythmetadata/videometadata.cpp
M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythfrontend/schedulecommon.cpp
M mythtv/programs/mythfrontend/videolist.cpp

Log Message:
-----------
clazy: Fix "returning void expression" warnings.

This check looks for void functions that contain the expression:

return doStuff();

across one or more lines, where doStuff is a function that returns
void. This compiles cleanly because the function returns void, but
appears to be a mistake in the code. Clean these up to be a call to
the function followed by a bare "return" (when necessary).


Commit: df168cb44ff90354b882c5b8324e27e8dfd7feb6
https://github.com/MythTV/mythtv/commit/df168cb44ff90354b882c5b8324e27e8dfd7feb6
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mythbrowser/mythbrowser/browserdbutil.cpp
M mythplugins/mythbrowser/mythbrowser/browserdbutil.h
M mythplugins/mythgame/mythgame/rominfo.h
M mythplugins/mythmusic/mythmusic/mainvisual.cpp
M mythplugins/mythmusic/mythmusic/mainvisual.h
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythplugins/mythmusic/mythmusic/visualize.h

Log Message:
-----------
clazy: Fix "function args by value" warnings. (plugins)

Warns when you should be passing by value instead of by-ref. Types
with sizeof <= 16 bytes which are trivially-copyable and
trivially-destructible should be passed by value.


Commit: 93805eb8b9bbb934373a8b3c5f8c6e885184060a
https://github.com/MythTV/mythtv/commit/93805eb8b9bbb934373a8b3c5f8c6e885184060a
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythtv/previewgenerator.h
M mythtv/programs/mythbackend/playbacksock.cpp
M mythtv/programs/mythbackend/playbacksock.h
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/scheduler.h
M mythtv/programs/mythbackend/services/video.h
M mythtv/programs/mythfrontend/channelrecpriority.cpp
M mythtv/programs/mythfrontend/guidegrid.h
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythfrontend/videodlg.h
M mythtv/programs/mythfrontend/videofileassoc.cpp
M mythtv/programs/mythpreviewgen/main.cpp

Log Message:
-----------
clazy: Fix "function args by value" warnings. (programs)

Warns when you should be passing by value instead of by-ref. Types
with sizeof <= 16 bytes which are trivially-copyable and
trivially-destructible should be passed by value.


Commit: de344e19b27bd86d308f9727d7352a3d11a0ac4d
https://github.com/MythTV/mythtv/commit/de344e19b27bd86d308f9727d7352a3d11a0ac4d
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp
M mythtv/libs/libmythtv/DVD/mythdvdbuffer.h
M mythtv/libs/libmythtv/DVD/mythdvdstream.cpp
M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
M mythtv/libs/libmythtv/captions/subtitlescreen.h
M mythtv/libs/libmythtv/channelinfo.cpp
M mythtv/libs/libmythtv/channelinfo.h
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/channelscan/channelscan_sm.h
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/diseqc.cpp
M mythtv/libs/libmythtv/dtvconfparserhelpers.h
M mythtv/libs/libmythtv/frequencytables.h
M mythtv/libs/libmythtv/mheg/interactivetv.cpp
M mythtv/libs/libmythtv/mheg/interactivetv.h
M mythtv/libs/libmythtv/mheg/mhi.cpp
M mythtv/libs/libmythtv/mheg/mhi.h
M mythtv/libs/libmythtv/mythcaptionsoverlay.cpp
M mythtv/libs/libmythtv/mythcaptionsoverlay.h
M mythtv/libs/libmythtv/mythmediaoverlay.cpp
M mythtv/libs/libmythtv/mythmediaoverlay.h
M mythtv/libs/libmythtv/mythplayerstate.cpp
M mythtv/libs/libmythtv/mythplayerstate.h
M mythtv/libs/libmythtv/mythplayervisualiserui.cpp
M mythtv/libs/libmythtv/mythplayervisualiserui.h
M mythtv/libs/libmythtv/mythvideobounds.cpp
M mythtv/libs/libmythtv/mythvideobounds.h
M mythtv/libs/libmythtv/mythvideogpu.cpp
M mythtv/libs/libmythtv/mythvideogpu.h
M mythtv/libs/libmythtv/mythvideoout.cpp
M mythtv/libs/libmythtv/mythvideoout.h
M mythtv/libs/libmythtv/mythvideooutgpu.cpp
M mythtv/libs/libmythtv/mythvideooutgpu.h
M mythtv/libs/libmythtv/mythvideooutnull.cpp
M mythtv/libs/libmythtv/mythvideooutnull.h
M mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp
M mythtv/libs/libmythtv/opengl/mythvideooutopengl.h
M mythtv/libs/libmythtv/osd.cpp
M mythtv/libs/libmythtv/osd.h
M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
M mythtv/libs/libmythtv/previewgeneratorqueue.h
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/channelbase.h
M mythtv/libs/libmythtv/recorders/hdhrchannel.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.h
M mythtv/libs/libmythtv/recordinginfo.cpp
M mythtv/libs/libmythtv/recordinginfo.h
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_play.h
M mythtv/libs/libmythtv/tvplaybackstate.cpp
M mythtv/libs/libmythtv/tvplaybackstate.h
M mythtv/libs/libmythtv/v4l2util.cpp
M mythtv/libs/libmythtv/v4l2util.h
M mythtv/libs/libmythtv/videodisplayprofile.cpp
M mythtv/libs/libmythtv/videodisplayprofile.h
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/videosource.h
M mythtv/libs/libmythtv/visualisations/opengl/mythvisualmonoscopeopengl.cpp
M mythtv/libs/libmythtv/visualisations/opengl/mythvisualmonoscopeopengl.h
M mythtv/libs/libmythtv/visualisations/videovisual.h
M mythtv/libs/libmythtv/visualisations/videovisualgoom.cpp
M mythtv/libs/libmythtv/visualisations/videovisualgoom.h
M mythtv/libs/libmythtv/visualisations/videovisualmonoscope.cpp
M mythtv/libs/libmythtv/visualisations/videovisualmonoscope.h
M mythtv/libs/libmythtv/visualisations/videovisualspectrum.cpp
M mythtv/libs/libmythtv/visualisations/videovisualspectrum.h
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualcirclesvulkan.cpp
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualcirclesvulkan.h
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualmonoscopevulkan.cpp
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualmonoscopevulkan.h
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualvulkan.cpp
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualvulkan.h
M mythtv/libs/libmythtv/vulkan/mythvideooutputvulkan.cpp
M mythtv/libs/libmythtv/vulkan/mythvideooutputvulkan.h

Log Message:
-----------
clazy: Fix "function args by value" warnings. (libmythtv)

Warns when you should be passing by value instead of by-ref. Types
with sizeof <= 16 bytes which are trivially-copyable and
trivially-destructible should be passed by value.


Commit: 23f99a6fa6d9c7c7b898fe0c59fdc427d7068db4
https://github.com/MythTV/mythtv/commit/23f99a6fa6d9c7c7b898fe0c59fdc427d7068db4
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythui/devices/mythcecadapter.cpp
M mythtv/libs/libmythui/devices/mythcecadapter.h
M mythtv/libs/libmythui/mythdisplay.cpp
M mythtv/libs/libmythui/mythdisplay.h
M mythtv/libs/libmythui/mythfontproperties.cpp
M mythtv/libs/libmythui/mythfontproperties.h
M mythtv/libs/libmythui/mythgesture.cpp
M mythtv/libs/libmythui/mythgesture.h
M mythtv/libs/libmythui/mythimage.cpp
M mythtv/libs/libmythui/mythimage.h
M mythtv/libs/libmythui/mythpainter.cpp
M mythtv/libs/libmythui/mythpainter.h
M mythtv/libs/libmythui/mythpainter_qt.cpp
M mythtv/libs/libmythui/mythpainter_qt.h
M mythtv/libs/libmythui/mythrect.cpp
M mythtv/libs/libmythui/mythrect.h
M mythtv/libs/libmythui/mythrender_base.h
M mythtv/libs/libmythui/mythuianimation.cpp
M mythtv/libs/libmythui/mythuianimation.h
M mythtv/libs/libmythui/mythuibuttonlist.cpp
M mythtv/libs/libmythui/mythuibuttonlist.h
M mythtv/libs/libmythui/mythuieditbar.cpp
M mythtv/libs/libmythui/mythuieditbar.h
M mythtv/libs/libmythui/mythuiguidegrid.cpp
M mythtv/libs/libmythui/mythuiguidegrid.h
M mythtv/libs/libmythui/mythuiimage.cpp
M mythtv/libs/libmythui/mythuiimage.h
M mythtv/libs/libmythui/mythuiscreenbounds.cpp
M mythtv/libs/libmythui/mythuiscreenbounds.h
M mythtv/libs/libmythui/mythuisimpletext.cpp
M mythtv/libs/libmythui/mythuisimpletext.h
M mythtv/libs/libmythui/mythuithemecache.cpp
M mythtv/libs/libmythui/mythuithemecache.h
M mythtv/libs/libmythui/mythuitype.cpp
M mythtv/libs/libmythui/mythuitype.h
M mythtv/libs/libmythui/opengl/mythpainteropengl.cpp
M mythtv/libs/libmythui/opengl/mythpainteropengl.h
M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
M mythtv/libs/libmythui/opengl/mythrenderopengl.h
M mythtv/libs/libmythui/vulkan/mythcombobuffervulkan.cpp
M mythtv/libs/libmythui/vulkan/mythcombobuffervulkan.h
M mythtv/libs/libmythui/vulkan/mythdebugvulkan.cpp
M mythtv/libs/libmythui/vulkan/mythdebugvulkan.h
M mythtv/libs/libmythui/vulkan/mythpaintervulkan.cpp
M mythtv/libs/libmythui/vulkan/mythpaintervulkan.h
M mythtv/libs/libmythui/vulkan/mythrendervulkan.cpp
M mythtv/libs/libmythui/vulkan/mythrendervulkan.h
M mythtv/libs/libmythui/vulkan/mythvertexbuffervulkan.cpp
M mythtv/libs/libmythui/vulkan/mythvertexbuffervulkan.h

Log Message:
-----------
clazy: Fix "function args by value" warnings. (libmythui)

Warns when you should be passing by value instead of by-ref. Types
with sizeof <= 16 bytes which are trivially-copyable and
trivially-destructible should be passed by value.


Commit: 86aebe2fbcc1138b397143163f9a2f73668034cc
https://github.com/MythTV/mythtv/commit/86aebe2fbcc1138b397143163f9a2f73668034cc
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmyth/audio/audiooutputgraph.cpp
M mythtv/libs/libmyth/mythrssmanager.cpp
M mythtv/libs/libmyth/mythrssmanager.h
M mythtv/libs/libmyth/netgrabbermanager.cpp
M mythtv/libs/libmyth/netgrabbermanager.h
M mythtv/libs/libmyth/netutils.cpp
M mythtv/libs/libmyth/netutils.h
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/programinfo.h
M mythtv/libs/libmyth/programinfoupdater.h
M mythtv/libs/libmyth/rssparse.cpp
M mythtv/libs/libmyth/rssparse.h
M mythtv/libs/libmythbase/mythdate.cpp
M mythtv/libs/libmythbase/mythdate.h
M mythtv/libs/libmythbase/unzip.cpp
M mythtv/libs/libmythbase/unzip_p.h
M mythtv/libs/libmythmetadata/metadatacommon.cpp
M mythtv/libs/libmythmetadata/metadatacommon.h
M mythtv/libs/libmythmetadata/metaioid3.cpp
M mythtv/libs/libmythmetadata/metaioid3.h
M mythtv/libs/libmythmetadata/musicfilescanner.cpp
M mythtv/libs/libmythmetadata/musicfilescanner.h
M mythtv/libs/libmythmetadata/videometadata.cpp
M mythtv/libs/libmythmetadata/videometadata.h
M mythtv/libs/libmythupnp/ssdpcache.cpp
M mythtv/libs/libmythupnp/ssdpcache.h
M mythtv/libs/libmythupnp/upnphelpers.cpp
M mythtv/libs/libmythupnp/upnphelpers.h

Log Message:
-----------
clazy: Fix "function args by value" warnings. (libs)

Warns when you should be passing by value instead of by-ref. Types
with sizeof <= 16 bytes which are trivially-copyable and
trivially-destructible should be passed by value.


Commit: c3f37c3483b44bfc9e71608223395e4ec5a3edc8
https://github.com/MythTV/mythtv/commit/c3f37c3483b44bfc9e71608223395e4ec5a3edc8
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mytharchive/mytharchive/mythburn.cpp
M mythplugins/mytharchive/mytharchive/mythburn.h
M mythplugins/mytharchive/mytharchive/themeselector.cpp
M mythplugins/mytharchive/mytharchive/themeselector.h

Log Message:
-----------
clazy: Fix "function args by ref" warnings. (plugins)

Warns when you should be passing by const-ref. Types with sizeof > 16
bytes or types which are not trivially-copyable or not
trivially-destructible should be passed by ref. A rule of thumb is
that if passing by value would trigger copy-ctor and/or dtor then pass
by ref instead.


Commit: d9da1fc56c2e55d309d9bc6ed3d3918e241b511e
https://github.com/MythTV/mythtv/commit/d9da1fc56c2e55d309d9bc6ed3d3918e241b511e
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
M mythtv/programs/mythcommflag/ClassicCommDetector.h

Log Message:
-----------
clazy: Fix "function args by ref" warnings. (programs)

Warns when you should be passing by const-ref. Types with sizeof > 16
bytes or types which are not trivially-copyable or not
trivially-destructible should be passed by ref. A rule of thumb is
that if passing by value would trigger copy-ctor and/or dtor then pass
by ref instead.


Commit: a25c410a28bd9aa254620cd7a0e9a460b1721d90
https://github.com/MythTV/mythtv/commit/a25c410a28bd9aa254620cd7a0e9a460b1721d90
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythservicecontracts/datacontracthelper.h
M mythtv/libs/libmythservicecontracts/datacontracts/artworkInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/blurayInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/buildInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/captureCard.h
M mythtv/libs/libmythservicecontracts/datacontracts/castMember.h
M mythtv/libs/libmythservicecontracts/datacontracts/channelGroup.h
M mythtv/libs/libmythservicecontracts/datacontracts/channelInfoList.h
M mythtv/libs/libmythservicecontracts/datacontracts/databaseInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/encoder.h
M mythtv/libs/libmythservicecontracts/datacontracts/enum.h
M mythtv/libs/libmythservicecontracts/datacontracts/enumItem.h
M mythtv/libs/libmythservicecontracts/datacontracts/envInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/frontend.h
M mythtv/libs/libmythservicecontracts/datacontracts/frontendStatus.h
M mythtv/libs/libmythservicecontracts/datacontracts/genre.h
M mythtv/libs/libmythservicecontracts/datacontracts/imageMetadataInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/imageMetadataInfoList.h
M mythtv/libs/libmythservicecontracts/datacontracts/input.h
M mythtv/libs/libmythservicecontracts/datacontracts/labelValue.h
M mythtv/libs/libmythservicecontracts/datacontracts/lineup.h
M mythtv/libs/libmythservicecontracts/datacontracts/liveStreamInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/logInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/logMessage.h
M mythtv/libs/libmythservicecontracts/datacontracts/musicMetadataInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/musicMetadataInfoList.h
M mythtv/libs/libmythservicecontracts/datacontracts/programAndChannel.h
M mythtv/libs/libmythservicecontracts/datacontracts/programGuide.h
M mythtv/libs/libmythservicecontracts/datacontracts/programList.h
M mythtv/libs/libmythservicecontracts/datacontracts/recRule.h
M mythtv/libs/libmythservicecontracts/datacontracts/recRuleFilter.h
M mythtv/libs/libmythservicecontracts/datacontracts/recRuleFilterList.h
M mythtv/libs/libmythservicecontracts/datacontracts/recRuleList.h
M mythtv/libs/libmythservicecontracts/datacontracts/recording.h
M mythtv/libs/libmythservicecontracts/datacontracts/settingList.h
M mythtv/libs/libmythservicecontracts/datacontracts/storageGroupDir.h
M mythtv/libs/libmythservicecontracts/datacontracts/timeZoneInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/titleInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/versionInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoLookupInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoLookupInfoList.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoMetadataInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoMetadataInfoList.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoMultiplex.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoMultiplexList.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoSource.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoSourceList.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoStreamInfo.h
M mythtv/libs/libmythservicecontracts/datacontracts/videoStreamInfoList.h
M mythtv/libs/libmythservicecontracts/datacontracts/wolInfo.h

Log Message:
-----------
clazy: Fix "function args by ref" warnings. (libmythservicecontracts)

Warns when you should be passing by const-ref. Types with sizeof > 16
bytes or types which are not trivially-copyable or not
trivially-destructible should be passed by ref. A rule of thumb is
that if passing by value would trigger copy-ctor and/or dtor then pass
by ref instead.


Commit: 3ed259b9fabdb8cb6ea071a9e5a854dfa896636d
https://github.com/MythTV/mythtv/commit/3ed259b9fabdb8cb6ea071a9e5a854dfa896636d
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythservicecontracts/services/dvrServices.h
M mythtv/libs/libmythservicecontracts/services/mythServices.h
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythbackend/services/dvr.h
M mythtv/programs/mythbackend/services/myth.cpp
M mythtv/programs/mythbackend/services/myth.h

Log Message:
-----------
clazy: Fix "function args by ref" warnings. (libmythservicecontracts 2)


Commit: b3c9df161392cd7ae0d24197e3758652481b4515
https://github.com/MythTV/mythtv/commit/b3c9df161392cd7ae0d24197e3758652481b4515
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythfreemheg/Engine.cpp
M mythtv/libs/libmythfreemheg/Engine.h
M mythtv/libs/libmythfreemheg/Root.h
M mythtv/libs/libmythfreemheg/Visible.cpp
M mythtv/libs/libmythfreemheg/Visible.h
M mythtv/libs/libmythfreemheg/freemheg.h
M mythtv/libs/libmythmetadata/imagemanager.cpp
M mythtv/libs/libmythmetadata/imagemanager.h
M mythtv/libs/libmythmetadata/musicmetadata.cpp
M mythtv/libs/libmythmetadata/musicmetadata.h
M mythtv/libs/libmythtv/mheg/mhi.cpp
M mythtv/libs/libmythtv/mheg/mhi.h
M mythtv/libs/libmythtv/mythplayervisualiserui.cpp
M mythtv/libs/libmythtv/mythplayervisualiserui.h
M mythtv/libs/libmythtv/mythvideocolourspace.cpp
M mythtv/libs/libmythtv/mythvideocolourspace.h
M mythtv/libs/libmythtv/overlays/mythnavigationoverlay.cpp
M mythtv/libs/libmythtv/overlays/mythnavigationoverlay.h
M mythtv/libs/libmythtv/recorders/asistreamhandler.h
M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.h
M mythtv/libs/libmythtv/recorders/iptvstreamhandler.h
M mythtv/libs/libmythtv/recorders/satipstreamhandler.h
M mythtv/libs/libmythtv/recorders/streamhandler.cpp
M mythtv/libs/libmythtv/recorders/streamhandler.h
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualvulkan.cpp
M mythtv/libs/libmythtv/visualisations/vulkan/mythvisualvulkan.h
M mythtv/libs/libmythupnp/configuration.cpp
M mythtv/libs/libmythupnp/configuration.h
M mythtv/libs/libmythupnp/httprequest.cpp
M mythtv/libs/libmythupnp/httprequest.h

Log Message:
-----------
clazy: Fix "function args by ref" warnings. (libs)

Warns when you should be passing by const-ref. Types with sizeof > 16
bytes or types which are not trivially-copyable or not
trivially-destructible should be passed by ref. A rule of thumb is
that if passing by value would trigger copy-ctor and/or dtor then pass
by ref instead.


Commit: 369fcb79e0bab3d13da4c5f6ecd0114ff8ef5608
https://github.com/MythTV/mythtv/commit/369fcb79e0bab3d13da4c5f6ecd0114ff8ef5608
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mythmusic/mythmusic/playlist.cpp

Log Message:
-----------
Remove unused string from playlist.cpp.


Commit: d6365a763c39051be9f16c6c4d204b52f3abd226
https://github.com/MythTV/mythtv/commit/d6365a763c39051be9f16c6c4d204b52f3abd226
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmyth/programtypes.cpp
M mythtv/libs/libmyth/programtypes.h
M mythtv/libs/libmythbase/logging.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp

Log Message:
-----------
clazy: Fix "global const char*" warnings.

Convert these to QStrings, and use QStringLiteral to put most of it
into the read-only data segment.


Commit: 61970b45f129257620ebcc450c2be591d02459f4
https://github.com/MythTV/mythtv/commit/61970b45f129257620ebcc450c2be591d02459f4
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythplugins/mytharchive/mytharchive/archiveutil.cpp
M mythplugins/mythnews/mythnews/mythnews.cpp
M mythtv/libs/libmythmetadata/metadataimagedownload.cpp
M mythtv/programs/mythfilldatabase/fillutil.cpp

Log Message:
-----------
clazy: Fix qt6 QDir deprecated API.


Commit: 307c1118906a5d0cb8d43cb56cd06ac1a7d8592a
https://github.com/MythTV/mythtv/commit/307c1118906a5d0cb8d43cb56cd06ac1a7d8592a
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/videosource.h
M mythtv/libs/libmythupnp/upnpcds.h
M mythtv/programs/mythbackend/upnpcdsmusic.cpp
M mythtv/programs/mythbackend/upnpcdstv.cpp
M mythtv/programs/mythbackend/upnpcdsvideo.cpp

Log Message:
-----------
clazy: Fix a couple of "tr with non-literal argument" warnings. (1)

Move the translation of these strings to the caller where the actual
literal string is located. This guarantees that the strings have been
translated.


Commit: aac8d26162a57775e872cd8356bf71bd7fb6a8ce
https://github.com/MythTV/mythtv/commit/aac8d26162a57775e872cd8356bf71bd7fb6a8ce
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmyth/programinfo.cpp

Log Message:
-----------
clazy: Fix a couple of "tr with non-literal argument" warnings. (2)

This function call in programinfo.cpp relies on all of the strings
having been marked for translation elsewhere. Add a comment to that
effect, and quiet the warning.


Commit: ecdd3ff852555ba9adf85acaaf47d4184e0b2522
https://github.com/MythTV/mythtv/commit/ecdd3ff852555ba9adf85acaaf47d4184e0b2522
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/libs/libmythbase/mythdb.cpp

Log Message:
-----------
clazy: Fix "global const char*" warnings. (2)

Add another const qualifier to put the string into the read-only data
segment.


Commit: dbde73e571058f960bae7fdb684f3c9d7b9d97cf
https://github.com/MythTV/mythtv/commit/dbde73e571058f960bae7fdb684f3c9d7b9d97cf
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M .clazy

Log Message:
-----------
Update clazy checks.


Commit: 0f7bd22cd85e653c4b96e99a81f14cf663a8d73b
https://github.com/MythTV/mythtv/commit/0f7bd22cd85e653c4b96e99a81f14cf663a8d73b
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-15 (Sun, 15 Nov 2020)

Changed paths:
M mythtv/programs/mythexternrecorder/MythExternRecApp.cpp

Log Message:
-----------
clazy: Fix "incorrect emit" warning in MythExternRecApp.

Remove the emit statement from the constructor because there's no-one
listening for it.


Compare: https://github.com/MythTV/mythtv/compare/22fd97461440...0f7bd22cd85e
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits