Mailing List Archive

Ticket #12460: mythmetadata: data lookup for TV specials fails
#12460: mythmetadata: data lookup for TV specials fails
---------------------------------------------+-------------------------
Reporter: jejb@… | Owner: jyavenard
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Mythmetadatalookup | Version: Unspecified
Severity: medium | Keywords:
Ticket locked: 0 |
---------------------------------------------+-------------------------
in thetvdb.com specials are season zero. Unfortunately, libmythmetadata
has a zero check on the season which ignores season zero set on any file,
meaning it never retrieves the correct data for specials.

The fix is only to check if the episode is non zero, not the season and
episode

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12460>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #12460: mythmetadata: data lookup for TV specials fails [ In reply to ]
#12460: mythmetadata: data lookup for TV specials fails
-----------------------------------------+-----------------------------
Reporter: jejb@… | Owner: jyavenard
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Mythmetadatalookup | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-----------------------------------------+-----------------------------
Changes (by jejb@…):

Attachment "07_fix_specials.diff" added

https://code.mythtv.org/trac/raw-attachment/ticket/12460/07_fix_specials.diff

fix for the specials problem

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12460>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #12460: mythmetadata: data lookup for TV specials fails [ In reply to ]
#12460: mythmetadata: data lookup for TV specials fails
-----------------------------------------+-----------------------------
Reporter: jejb@… | Owner: jyavenard
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: 0.28
Component: MythTV - Mythmetadatalookup | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-----------------------------------------+-----------------------------
Changes (by stuarta):

* milestone: unknown => 0.28


--
Ticket URL: <https://code.mythtv.org/trac/ticket/12460#comment:1>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #12460: mythmetadata: data lookup for TV specials fails [ In reply to ]
#12460: mythmetadata: data lookup for TV specials fails
-----------------------------------------+-----------------------------
Reporter: jejb@… | Owner: jyavenard
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: 0.28
Component: MythTV - Mythmetadatalookup | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-----------------------------------------+-----------------------------

Comment (by jejb@…):

It looks like the change that caused the problem also went into 0.27.4 as

commit af9082ea5a4123662726dbfe58ee3516f9cb75db
Author: Jean-Yves Avenard <jyavenard@mythtv.org>
Date: Thu Jul 17 23:33:00 2014 +1000

metadata: complete refactor of search

So the fix probably needs backporting to the 0.27 branch as well (patch
applies as is).

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12460#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #12460: mythmetadata: data lookup for TV specials fails [ In reply to ]
#12460: mythmetadata: data lookup for TV specials fails
-----------------------------------------+---------------------------
Reporter: jejb@… | Owner: JYA
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: 29.2
Component: MythTV - Mythmetadatalookup | Version: v31-fixes
Severity: medium | Resolution: Fixed
Keywords: | Ticket locked: 0
-----------------------------------------+---------------------------
Changes (by rcrdnalor):

* status: new => closed
* version: Unspecified => v31-fixes
* resolution: => Fixed


Comment:

Fixed by commit [https://github.com/MythTV/mythtv/commit/8ca546b] on
master and v31
{{{
if (list.isEmpty() && (lookup->GetSeason() || lookup->GetEpisode()))
}}}

See pull request: Fix thetvdb Specials #185

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12460#comment:8>
MythTV <http://www.mythtv.org>
MythTV Media Center