Mailing List Archive: tiny patch to user/install/install.pod

howdy folks,

i just learned the hard way that makepl_args.mod_perl2 needs
newlines between the options, whereas mod_perl1 worked fine
with just spaces. seems worth documenting:

regards, brandt

Index: src/mod_perl-docs/src/docs/2.0/user/install/install.pod
===================================================================
--- src/mod_perl-docs/src/docs/2.0/user/install/install.pod (revision 111889)
+++ src/mod_perl-docs/src/docs/2.0/user/install/install.pod (working copy)
@@ -547,7 +547,8 @@
=head3 mod_perl Options File

Options can also be specified in the file I<makepl_args.mod_perl2> or
-I<.makepl_args.mod_perl2>. The file can be placed under C<$ENV{HOME}>,
+I<.makepl_args.mod_perl2>. Each option specified in this file must be
+on a separate line. The file can be placed under C<$ENV{HOME}>,
the root of the source package or its parent directory. So if you
unpack the mod_perl source into I</tmp/mod_perl-2.x/> and your home is
I</home/foo/>, the file will be searched in:

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org

Brandt Kurowski wrote:
> howdy folks,
>
> i just learned the hard way that makepl_args.mod_perl2 needs
> newlines between the options, whereas mod_perl1 worked fine
> with just spaces. seems worth documenting:

Thanks Brandt, but I'd rather see this fixed in the code :)

Please try this patch:

Index: lib/ModPerl/BuildOptions.pm
===================================================================
--- lib/ModPerl/BuildOptions.pm (revision 111891)
+++ lib/ModPerl/BuildOptions.pm (working copy)
@@ -75,7 +75,13 @@
my @unknown;
my $continue = "";

+ my @data = ();
for (@$lines) {
+ # more than one entry on the same line
+ push @data, split /(?=MP_)/, $_;
+ }
+
+ for (@data) {
#XXX: this "parser" should be more robust
chomp;
s/^\s+//; s/\s+$//;

--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org