Mailing List Archive

Re: debian stable 5.6.1 fix
Stas,
I feel like a complete bum pointing out a "potential problem" when I'm
perfectly aware that I don't have the time (or the hardware at the moment)
to look at it at all but....
Remember that Debian Sarge is scheduled for release in ~3 weeks. Probably a
good idea to make sure the patch doesn't mess anything up with the default
releases there...

Issac
*cowers against the slam of criticism he know's he's got coming his way*

----- Original Message -----
From: "Stas Bekman" <stas@stason.org>
To: "Jason Woodward" <woodwardj@jaos.org>
Cc: <dev@perl.apache.org>
Sent: Monday, August 23, 2004 8:06 AM
Subject: Re: debian stable 5.6.1 fix


> Jason Woodward wrote:
> > Building current cvs for Apache 2.0.50 on Debian GNU/Linux stable, perl
5.6.1.
> >
> > The attached patch fixes a sv_copypv missing symbol error when starting
apache with mod_perl
> > mod_perl-1.99_15 and newer.
>
> Thanks Jason for the spot and the patch.
>
> After testing is completed I'll apply the following patch (this is sort of
> ppport.h, so no code needs to be changed).
>
> I'll probably release 1.99_16 shortly, as this will be a problem for any
> 5.6.x users.
>
> Index: src/modules/perl/modperl_perl_includes.h
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_perl_includes.h,v
> retrieving revision 1.19
> diff -u -r1.19 modperl_perl_includes.h
> --- src/modules/perl/modperl_perl_includes.h 4 Mar 2004 06:01:07 -0000
1.19
> +++ src/modules/perl/modperl_perl_includes.h 23 Aug 2004 05:00:27 -0000
> @@ -112,4 +112,21 @@
> # define environ (*_NSGetEnviron())
> #endif
>
> +/* sv_copypv was added in perl 5.7.3 */
> +#ifndef sv_copypv
> +# define sv_copypv(dsv, ssv) \
> + STMT_START { \
> + STRLEN len; \
> + char *s; \
> + s = SvPV(ssv, len); \
> + sv_setpvn(dsv, s, len); \
> + if (SvUTF8(ssv)) { \
> + SvUTF8_on(dsv); \
> + } \
> + else { \
> + SvUTF8_off(dsv); \
> + } \
> + } STMT_END
> +#endif
> +
> #endif /* MODPERL_PERL_INCLUDES_H */
>
> --
> __________________________________________________________________
> Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org http://ticketmaster.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: debian stable 5.6.1 fix [ In reply to ]
Issac Goldstand wrote:
> Stas,
> I feel like a complete bum pointing out a "potential problem" when I'm
> perfectly aware that I don't have the time (or the hardware at the moment)
> to look at it at all but....
> Remember that Debian Sarge is scheduled for release in ~3 weeks. Probably a
> good idea to make sure the patch doesn't mess anything up with the default
> releases there...
>
> Issac
> *cowers against the slam of criticism he know's he's got coming his way*

Sorry, Issac, I don't understand what seems to be the problem. Please explain.

> ----- Original Message -----
> From: "Stas Bekman" <stas@stason.org>
> To: "Jason Woodward" <woodwardj@jaos.org>
> Cc: <dev@perl.apache.org>
> Sent: Monday, August 23, 2004 8:06 AM
> Subject: Re: debian stable 5.6.1 fix
>
>
>
>>Jason Woodward wrote:
>>
>>>Building current cvs for Apache 2.0.50 on Debian GNU/Linux stable, perl
>
> 5.6.1.
>
>>>The attached patch fixes a sv_copypv missing symbol error when starting
>
> apache with mod_perl
>
>>>mod_perl-1.99_15 and newer.
>>
>>Thanks Jason for the spot and the patch.
>>
>>After testing is completed I'll apply the following patch (this is sort of
>>ppport.h, so no code needs to be changed).
>>
>>I'll probably release 1.99_16 shortly, as this will be a problem for any
>>5.6.x users.
>>
>>Index: src/modules/perl/modperl_perl_includes.h
>>===================================================================
>>RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_perl_includes.h,v
>>retrieving revision 1.19
>>diff -u -r1.19 modperl_perl_includes.h
>>--- src/modules/perl/modperl_perl_includes.h 4 Mar 2004 06:01:07 -0000
>
> 1.19
>
>>+++ src/modules/perl/modperl_perl_includes.h 23 Aug 2004 05:00:27 -0000
>>@@ -112,4 +112,21 @@
>> # define environ (*_NSGetEnviron())
>> #endif
>>
>>+/* sv_copypv was added in perl 5.7.3 */
>>+#ifndef sv_copypv
>>+# define sv_copypv(dsv, ssv) \
>>+ STMT_START { \
>>+ STRLEN len; \
>>+ char *s; \
>>+ s = SvPV(ssv, len); \
>>+ sv_setpvn(dsv, s, len); \
>>+ if (SvUTF8(ssv)) { \
>>+ SvUTF8_on(dsv); \
>>+ } \
>>+ else { \
>>+ SvUTF8_off(dsv); \
>>+ } \
>>+ } STMT_END
>>+#endif
>>+
>> #endif /* MODPERL_PERL_INCLUDES_H */
>>
>>--
>>__________________________________________________________________
>>Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
>>http://stason.org/ mod_perl Guide ---> http://perl.apache.org
>>mailto:stas@stason.org http://use.perl.org http://apacheweek.com
>>http://modperlbook.org http://apache.org http://ticketmaster.com
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
>>For additional commands, e-mail: dev-help@perl.apache.org
>>


--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: debian stable 5.6.1 fix [ In reply to ]
Not problem - potential problem. Anyway, my guilty consience made me look
into it myself. All good :-)

However:

Failed Test Stat Wstat Total Fail Failed List of Failed
----------------------------------------------------------------------------
---
t/modperl/setupenv.t 63 6 9.52% 8 22 29 36 50 57
t/preconnection/note.t 1 1 100.00% 1
Failed 2/2 test scripts, 0.00% okay. 7/64 subtests failed, 89.06% okay.
[warning] server hector.mirimar.net:8529 shutdown
[ error] error running tests (please examine t/logs/error_log)
issac@hector:~/build/mod_perl-1.99_16$ cat t/logs/error_log
[Mon Aug 23 20:26:19 2004] [info] mod_unique_id: using ip addr 127.0.0.1
[Mon Aug 23 20:26:20 2004] [notice] suEXEC mechanism enabled (wrapper:
/usr/loca
l/httpd/bin/suexec)
[Mon Aug 23 20:26:20 2004] [info] Init: Initializing OpenSSL library
[Mon Aug 23 20:26:20 2004] [info] Init: Seeding PRNG with 0 bytes of entropy
[Mon Aug 23 20:26:20 2004] [info] Init: Generating temporary RSA private
keys (5
12/1024 bits)
[Mon Aug 23 20:26:20 2004] [info] Init: Generating temporary DH parameters
(512/
1024 bits)
[Mon Aug 23 20:26:20 2004] [warn] Init: Session Cache is not configured
[hint: S
SLSessionCache]
[Mon Aug 23 20:26:20 2004] [info] Init: Initializing (virtual) servers for
SSL
[Mon Aug 23 20:26:20 2004] [info] Server: Apache/2.0.50, Interface:
mod_ssl/2.0.
50, Library: OpenSSL/0.9.7d
END in modperl_extra.pl, pid=27129
END in modperl_extra.pl, pid=27129
[Mon Aug 23 20:26:22 2004] [info] mod_unique_id: using ip addr 127.0.0.1
[Mon Aug 23 20:26:23 2004] [notice] Digest: generating secret for digest
authent
ication ...
[Mon Aug 23 20:26:45 2004] [notice] Digest: done
[Mon Aug 23 20:26:45 2004] [info] Init: Initializing OpenSSL library
[Mon Aug 23 20:26:45 2004] [info] Init: Seeding PRNG with 0 bytes of entropy
[Mon Aug 23 20:26:45 2004] [info] Init: Generating temporary RSA private
keys (5
12/1024 bits)
[Mon Aug 23 20:26:45 2004] [info] Init: Generating temporary DH parameters
(512/
1024 bits)
[Mon Aug 23 20:26:45 2004] [info] Init: Initializing (virtual) servers for
SSL
[Mon Aug 23 20:26:45 2004] [info] Server: Apache/2.0.50, Interface:
mod_ssl/2.0.
50, Library: OpenSSL/0.9.7d
[Mon Aug 23 20:26:45 2004] [notice] Apache/2.0.50 (Unix) mod_perl/1.99_16
Perl/v
5.8.5 world domination series/2.0 mod_ssl/2.0.50 OpenSSL/0.9.7d DAV/2
PHP/5.0.1
configured -- resuming normal operations
[Mon Aug 23 20:26:45 2004] [info] Server built: Aug 3 2004 18:51:42
[Mon Aug 23 20:26:45 2004] [debug] worker.c(1631): AcceptMutex: pthread
(default
: pthread)
# Failed test 8 in
/home/issac/build/mod_perl-1.99_16/t/response/TestModperl/set
upenv.pm at line 35
# Failed test 22 in
/home/issac/build/mod_perl-1.99_16/t/response/TestModperl/se
tupenv.pm at line 115
# Failed test 29 in
/home/issac/build/mod_perl-1.99_16/t/response/TestModperl/se
tupenv.pm at line 35 fail #2
# Failed test 36 in
/home/issac/build/mod_perl-1.99_16/t/response/TestModperl/se
tupenv.pm at line 35 fail #3
# Failed test 50 in
/home/issac/build/mod_perl-1.99_16/t/response/TestModperl/se
tupenv.pm at line 35 fail #4
# Failed test 57 in
/home/issac/build/mod_perl-1.99_16/t/response/TestModperl/se
tupenv.pm at line 115 fail #2
[Mon Aug 23 20:26:50 2004] [info] Child process pid=28714 is exiting
END in modperl_extra.pl, pid=28714
END in modperl_extra.pl, pid=28714
[Mon Aug 23 20:26:50 2004] [warn] child process 28102 still did not exit,
sendin
g a SIGTERM
[Mon Aug 23 20:26:50 2004] [info] Child process pid=28102 is exiting
END in modperl_extra.pl, pid=28102
END in modperl_extra.pl, pid=28102
[Mon Aug 23 20:26:50 2004] [info] removed PID file
/home/issac/build/mod_perl-1.
99_16/t/logs/httpd.pid (pid=27447)
[Mon Aug 23 20:26:50 2004] [notice] caught SIGTERM, shutting down
END in modperl_extra.pl, pid=27447
END in modperl_extra.pl, pid=27447

issac@hector:~/build/mod_perl-1.99_16$ perl -V
Summary of my perl5 (revision 5 version 8 subversion 5) configuration:
Platform:
osname=linux, osvers=2.6.7-1-686-smp,
archname=i686-linux-thread-multi-64int
-ld
uname='linux hector.mirimar.net 2.6.7-1-686-smp #1 smp thu jul 29
14:28:01 i
dt 2004 i686 gnulinux '
config_args=''
hint=previous, useposix=true, d_sigaction=define
usethreads=define use5005threads=undef useithreads=define
usemultiplicity=de
fine
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=define use64bitall=undef uselongdouble=define
usemymalloc=n, bincompat5005=undef
Compiler:
cc='cc', ccflags
='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno-stric
t-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BIT
S=64
-DDEBIAN',
optimize='-O3 -march=pentium4 -mcpu=pentium4',




cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno-strict-aliasin
g -pipe -I/usr/local/include -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS
-fno
-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFS
ET_B
ITS=64 -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno-strict-aliasing -
pipe
-I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DDEBIAN -D
_REE
NTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno-strict-aliasing -pipe -I/usr/l
ocal
/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DDEBIAN -D_REENTRANT -D
_GNU
_SOURCE -DTHREADS_HAVE_PIDS -fno-strict-aliasing -pipe -I/usr/local/include
-D_L
ARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DDEBIAN -D_REENTRANT -D_GNU_SOURCE -
DTHR
EADS_HAVE_PIDS -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_
SOUR
CE -D_FILE_OFFSET_BITS=64 -DDEBIAN -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE
_PID
S -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FIL
E_OF
FSET_BITS=64 -DDEBIAN -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -fno-st
rict
-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS
=64
-DDEBIAN'
ccversion='', gccversion='3.3.4 (Debian 1:3.3.4-3)', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
ivtype='long long', ivsize=8, nvtype='long double', nvsize=12,
Off_t='off_t'
, lseeksize=8
alignbytes=4, prototype=define
Linker and Libraries:
ld='cc', ldflags =' -L/usr/local/lib'
libpth=/usr/local/lib /lib /usr/lib
libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc
perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
libc=/lib/libc-2.3.2.so, so=so, useshrplib=true, libperl=libperl.so
gnulibc_version='2.3.2'
Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef,
ccdlflags='-fPIC -Wl,-rpath,/
usr/local/lib/perl5/5.8.5/i686-debian-thread-multi-ld/CORE '
cccdlflags='-fpic', lddlflags=' -L/usr/local/lib -shared'


Characteristics of this binary (from libperl):
Compile-time options: MULTIPLICITY USE_ITHREADS USE_64_BIT_INT
USE_LONG_DOUBLE
USE_LARGE_FILES PERL_IMPLICIT_CONTEXT
Built under linux
Compiled at Aug 9 2004 20:44:08
%ENV:
PERL5LIB="/home/issac/perl/lib/perl/5.8.3/auto"
@INC:
/home/issac/perl/lib/perl/5.8.3/auto
/usr/local/lib/perl5/5.8.5/i686-debian-thread-multi-ld
/usr/local/lib/perl5/5.8.5
/usr/local/lib/perl5/site_perl/5.8.5/i686-debian-thread-multi-ld
/usr/local/lib/perl5/site_perl/5.8.5
/usr/local/lib/perl5/site_perl
/usr/lib/perl5
/usr/share/perl5
/usr/share/perl5
/etc/perl
/usr/lib/perl/5.8
/usr/share/perl/5.8
/usr/local/httpd/lib/perl
/usr/local/lib/site_perl
/usr/local/lib/perl/5.8.4
/usr/local/share/perl/5.8.4
/usr/local/lib/perl/5.8.3
/usr/local/share/perl/5.8.3
.

----- Original Message -----
From: "Stas Bekman" <stas@stason.org>
To: "Issac Goldstand" <margol@beamartyr.net>
Cc: "Jason Woodward" <woodwardj@jaos.org>; <docs-dev@perl.apache.org>
Sent: Monday, August 23, 2004 7:41 PM
Subject: Re: debian stable 5.6.1 fix


> Issac Goldstand wrote:
> > Stas,
> > I feel like a complete bum pointing out a "potential problem" when I'm
> > perfectly aware that I don't have the time (or the hardware at the
moment)
> > to look at it at all but....
> > Remember that Debian Sarge is scheduled for release in ~3 weeks.
Probably a
> > good idea to make sure the patch doesn't mess anything up with the
default
> > releases there...
> >
> > Issac
> > *cowers against the slam of criticism he know's he's got coming his
way*
>
> Sorry, Issac, I don't understand what seems to be the problem. Please
explain.
>
> > ----- Original Message -----
> > From: "Stas Bekman" <stas@stason.org>
> > To: "Jason Woodward" <woodwardj@jaos.org>
> > Cc: <dev@perl.apache.org>
> > Sent: Monday, August 23, 2004 8:06 AM
> > Subject: Re: debian stable 5.6.1 fix
> >
> >
> >
> >>Jason Woodward wrote:
> >>
> >>>Building current cvs for Apache 2.0.50 on Debian GNU/Linux stable, perl
> >
> > 5.6.1.
> >
> >>>The attached patch fixes a sv_copypv missing symbol error when starting
> >
> > apache with mod_perl
> >
> >>>mod_perl-1.99_15 and newer.
> >>
> >>Thanks Jason for the spot and the patch.
> >>
> >>After testing is completed I'll apply the following patch (this is sort
of
> >>ppport.h, so no code needs to be changed).
> >>
> >>I'll probably release 1.99_16 shortly, as this will be a problem for any
> >>5.6.x users.
> >>
> >>Index: src/modules/perl/modperl_perl_includes.h
> >>===================================================================
> >>RCS file:
/home/cvs/modperl-2.0/src/modules/perl/modperl_perl_includes.h,v
> >>retrieving revision 1.19
> >>diff -u -r1.19 modperl_perl_includes.h
> >>--- src/modules/perl/modperl_perl_includes.h 4 Mar 2004 06:01:07 -0000
> >
> > 1.19
> >
> >>+++ src/modules/perl/modperl_perl_includes.h 23 Aug 2004 05:00:27 -0000
> >>@@ -112,4 +112,21 @@
> >> # define environ (*_NSGetEnviron())
> >> #endif
> >>
> >>+/* sv_copypv was added in perl 5.7.3 */
> >>+#ifndef sv_copypv
> >>+# define sv_copypv(dsv, ssv) \
> >>+ STMT_START { \
> >>+ STRLEN len; \
> >>+ char *s; \
> >>+ s = SvPV(ssv, len); \
> >>+ sv_setpvn(dsv, s, len); \
> >>+ if (SvUTF8(ssv)) { \
> >>+ SvUTF8_on(dsv); \
> >>+ } \
> >>+ else { \
> >>+ SvUTF8_off(dsv); \
> >>+ } \
> >>+ } STMT_END
> >>+#endif
> >>+
> >> #endif /* MODPERL_PERL_INCLUDES_H */
> >>
> >>--
> >>__________________________________________________________________
> >>Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> >>http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> >>mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> >>http://modperlbook.org http://apache.org http://ticketmaster.com
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> >>For additional commands, e-mail: dev-help@perl.apache.org
> >>
>
>
> --
> __________________________________________________________________
> Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org http://ticketmaster.com
>


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org
Re: debian stable 5.6.1 fix [ In reply to ]
Issac Goldstand wrote:
> Not problem - potential problem. Anyway, my guilty consience made me look
> into it myself. All good :-)

Ah, so you have test failures, how could I possible guess that from your
original message. :)

Please read http://perl.apache.org/bugs/ and submit a proper bug report to
the right list and we will take care of it. Thanks Issac!

--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org