Mailing List Archive: Heads up: upcoming GitHub action to mark stale Lucene PRs

Heads up: upcoming GitHub action to mark stale Lucene PRs

Jan 4, 2024, 5:04 AM

Post #1 of 5 (127 views)

Hi Team,

Stefan Vodita made an awesome simple PR adding a GitHub action to remind /
nag us about stale PRs: https://github.com/apache/lucene/pull/12813

This happened after an in-person discussion at the last Community Over Code
NA in Halifax where Stefan learned about the nice automation Apache Beam
uses to nudge PRs forward. This change is just a baby step to try to get
our stale PRs into a healthier state / workflow.

In the ultimate irony, that PR itself had become stale recently (2 weeks of
no activity) -- a "meta-stale PR"!

I would like to merge this PR soon, but:
* It will generate a bunch of one-time noise because we have ~163 open
PRs many of which are stale:
https://githubsearch.mikemccandless.com/search.py?dd=status%3AOpen&dd=issue_or_pr%3APR
* I know nothing about GitHub actions YAML format, but worst comes to
worst we push it, it fails in some exotic way, and we revert.

I assume lazy consensus soon ;)

Mike McCandless

http://blog.mikemccandless.com

Re: Heads up: upcoming GitHub action to mark stale Lucene PRs [ In reply to ]

uwe at thetaphi

Jan 4, 2024, 5:29 AM

Post #2 of 5 (127 views)

Permalink

Hi,

would it be possible to exclude DRAFT pull requests from this check? I
can't send a weekly reminder to my own WIP PRs, like the MMapDirectory
one (because it waits for Java 22 to be in RC phase).

Uwe

Am 04.01.2024 um 14:04 schrieb Michael McCandless:
> Hi Team,
>
> Stefan Vodita made an awesome simple PR adding a GitHub action to
> remind / nag us about stale PRs:
> https://github.com/apache/lucene/pull/12813
>
> This happened after an in-person discussion at the last Community Over
> Code NA in Halifax where Stefan learned about the nice automation
> Apache Beam uses to nudge PRs forward. This change is just a baby step
> to try to get our stale PRs into a healthier state / workflow.
>
> In the ultimate irony, that PR itself had become stale recently (2
> weeks of no activity) -- a "meta-stale PR"!
>
> I would like to merge this PR soon, but:
> * It will generate a bunch of one-time noise because we have ~163
> open PRs many of which are stale:
> https://githubsearch.mikemccandless.com/search.py?dd=status%3AOpen&dd=issue_or_pr%3APR
> <https://githubsearch.mikemccandless.com/search.py?dd=status%3AOpen&dd=issue_or_pr%3APR>
> * I know nothing about GitHub actions YAML format, but worst comes
> to worst we push it, it fails in some exotic way, and we revert.
>
> I assume lazy consensus soon ;)
>
> Mike McCandless
>
> http://blog.mikemccandless.com

--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail:uwe@thetaphi.de

Re: Heads up: upcoming GitHub action to mark stale Lucene PRs [ In reply to ]

stefan.vodita at gmail

Jan 4, 2024, 5:47 AM

Post #3 of 5 (127 views)

Permalink

There's a flag for excluding draft PRs [1]. I'll add it to the workflow.
If we need more flexibility in the future, we can also exclude PRs with
certain labels [2].

Stefan

[1] https://github.com/actions/stale?tab=readme-ov-file#exempt-draft-pr
[2] https://github.com/actions/stale?tab=readme-ov-file#exempt-pr-labels

On Thu, 4 Jan 2024 at 15:30, Uwe Schindler <uwe@thetaphi.de> wrote:

> Hi,
>
> would it be possible to exclude DRAFT pull requests from this check? I
> can't send a weekly reminder to my own WIP PRs, like the MMapDirectory one
> (because it waits for Java 22 to be in RC phase).
>
> Uwe
> Am 04.01.2024 um 14:04 schrieb Michael McCandless:
>
> Hi Team,
>
> Stefan Vodita made an awesome simple PR adding a GitHub action to remind /
> nag us about stale PRs: https://github.com/apache/lucene/pull/12813
>
> This happened after an in-person discussion at the last Community Over
> Code NA in Halifax where Stefan learned about the nice automation Apache
> Beam uses to nudge PRs forward. This change is just a baby step to try to
> get our stale PRs into a healthier state / workflow.
>
> In the ultimate irony, that PR itself had become stale recently (2 weeks
> of no activity) -- a "meta-stale PR"!
>
> I would like to merge this PR soon, but:
> * It will generate a bunch of one-time noise because we have ~163 open
> PRs many of which are stale:
> https://githubsearch.mikemccandless.com/search.py?dd=status%3AOpen&dd=issue_or_pr%3APR
> * I know nothing about GitHub actions YAML format, but worst comes to
> worst we push it, it fails in some exotic way, and we revert.
>
> I assume lazy consensus soon ;)
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> --
> Uwe Schindler
> Achterdiek 19, D-28357 Bremenhttps://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>

Re: Heads up: upcoming GitHub action to mark stale Lucene PRs [ In reply to ]

stefan.vodita at gmail

Jan 8, 2024, 4:34 AM

Post #4 of 5 (115 views)

Permalink

Hi all,

We merged the PR for adding stale labels and ran the bot a few minutes ago.
The run [1] went through 133 PRs, starting from the most recently created
and found 91 stale [2].
The workflow will continue running daily. By tomorrow, it should get
through all the PRs.

[1] https://github.com/apache/lucene/actions/runs/7447339092/job/20259452054
[2]
https://github.com/apache/lucene/pulls?q=is%3Apr+label%3AStale+is%3Aclosed

On Thu, 4 Jan 2024 at 15:47, Stefan Vodita <stefan.vodita@gmail.com> wrote:

> There's a flag for excluding draft PRs [1]. I'll add it to the workflow.
> If we need more flexibility in the future, we can also exclude PRs with
> certain labels [2].
>
> Stefan
>
> [1] https://github.com/actions/stale?tab=readme-ov-file#exempt-draft-pr
> [2] https://github.com/actions/stale?tab=readme-ov-file#exempt-pr-labels
>
> On Thu, 4 Jan 2024 at 15:30, Uwe Schindler <uwe@thetaphi.de> wrote:
>
>> Hi,
>>
>> would it be possible to exclude DRAFT pull requests from this check? I
>> can't send a weekly reminder to my own WIP PRs, like the MMapDirectory one
>> (because it waits for Java 22 to be in RC phase).
>>
>> Uwe
>> Am 04.01.2024 um 14:04 schrieb Michael McCandless:
>>
>> Hi Team,
>>
>> Stefan Vodita made an awesome simple PR adding a GitHub action to remind
>> / nag us about stale PRs: https://github.com/apache/lucene/pull/12813
>>
>> This happened after an in-person discussion at the last Community Over
>> Code NA in Halifax where Stefan learned about the nice automation Apache
>> Beam uses to nudge PRs forward. This change is just a baby step to try to
>> get our stale PRs into a healthier state / workflow.
>>
>> In the ultimate irony, that PR itself had become stale recently (2 weeks
>> of no activity) -- a "meta-stale PR"!
>>
>> I would like to merge this PR soon, but:
>> * It will generate a bunch of one-time noise because we have ~163
>> open PRs many of which are stale:
>> https://githubsearch.mikemccandless.com/search.py?dd=status%3AOpen&dd=issue_or_pr%3APR
>> * I know nothing about GitHub actions YAML format, but worst comes to
>> worst we push it, it fails in some exotic way, and we revert.
>>
>> I assume lazy consensus soon ;)
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>> --
>> Uwe Schindler
>> Achterdiek 19, D-28357 Bremenhttps://www.thetaphi.de
>> eMail: uwe@thetaphi.de
>>
>>

Re: Heads up: upcoming GitHub action to mark stale Lucene PRs [ In reply to ]

uwe at thetaphi

Jan 8, 2024, 4:50 AM

Post #5 of 5 (115 views)

Permalink

Hi thanks Stefan,

I will check some of the PRs I was invoved in and close/merge them if
needed.

Uwe

Am 08.01.2024 um 13:34 schrieb Stefan Vodita:
> Hi all,
>
> We merged the PR for adding stale labels and ran the bot a few minutes
> ago.
> The run [1] went through 133 PRs, starting from the most recently
> created and found 91 stale [2].
> The workflow will continue running daily. By tomorrow, it should get
> through all the PRs.
>
> [1]
> https://github.com/apache/lucene/actions/runs/7447339092/job/20259452054
> [2]
> https://github.com/apache/lucene/pulls?q=is%3Apr+label%3AStale+is%3Aclosed
>
> On Thu, 4 Jan 2024 at 15:47, Stefan Vodita <stefan.vodita@gmail.com>
> wrote:
>
> There's a flag for excluding draft PRs [1]. I'll add it to the
> workflow.
> If we need more flexibility in the future, we can also exclude PRs
> with certain labels [2].
>
> Stefan
>
> [1]
> https://github.com/actions/stale?tab=readme-ov-file#exempt-draft-pr
> [2]
> https://github.com/actions/stale?tab=readme-ov-file#exempt-pr-labels
>
> On Thu, 4 Jan 2024 at 15:30, Uwe Schindler <uwe@thetaphi.de> wrote:
>
> Hi,
>
> would it be possible to exclude DRAFT pull requests from this
> check? I can't send a weekly reminder to my own WIP PRs, like
> the MMapDirectory one (because it waits for Java 22 to be in
> RC phase).
>
> Uwe
>
> Am 04.01.2024 um 14:04 schrieb Michael McCandless:
>> Hi Team,
>>
>> Stefan Vodita made an awesome simple PR adding a GitHub
>> action to remind / nag us about stale PRs:
>> https://github.com/apache/lucene/pull/12813
>>
>> This happened after an in-person discussion at the last
>> Community Over Code NA in Halifax where Stefan learned about
>> the nice automation Apache Beam uses to nudge PRs forward.
>> This change is just a baby step to try to get our stale PRs
>> into a healthier state / workflow.
>>
>> In the ultimate irony, that PR itself had become stale
>> recently (2 weeks of no activity) -- a "meta-stale PR"!
>>
>> I would like to merge this PR soon, but:
>> * It will generate a bunch of one-time noise because we
>> have ~163 open PRs many of which are stale:
>> https://githubsearch.mikemccandless.com/search.py?dd=status%3AOpen&dd=issue_or_pr%3APR
>> <https://githubsearch.mikemccandless.com/search.py?dd=status%3AOpen&dd=issue_or_pr%3APR>
>> * I know nothing about GitHub actions YAML format, but
>> worst comes to worst we push it, it fails in some exotic way,
>> and we revert.
>>
>> I assume lazy consensus soon ;)
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>
> --
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail:uwe@thetaphi.de
>
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail:uwe@thetaphi.de