Mailing List Archive

Automated smoke testing passed for me:
SUCCESS! [1:32:35.061917]

I think this commit should be applied to the release branch too, if there's
a decision to respin.

https://gitbox.apache.org/repos/asf?p=lucene.git;h=e999056

D.

On Tue, Mar 15, 2022 at 1:57 AM Julie Tibshirani <julietibs@gmail.com>
wrote:

> Please vote for release candidate 1 for Lucene 9.1.0
>
> The artifacts can be downloaded from:
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
>
> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00
> UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1.
>
> Julie
>

Hi,



I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).



This worked for 9.0, but with 9.1 it hangs endless and does not finish:

make sure no JARs/WARs in src dist...

run "./gradlew --no-daemon check -p lucene/documentation"

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...



After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.



There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):

org.gradle.parallel=true

org.gradle.priority=normal

org.gradle.daemon=false



org.gradle.workers.max=6

tests.jvms=6

tests.multiplier=3



The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)



Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de



From: Julie Tibshirani <julietibs@gmail.com>
Sent: Tuesday, March 15, 2022 1:57 AM
To: dev@lucene.apache.org
Subject: [VOTE] Release Lucene 9.1.0 RC1



Please vote for release candidate 1 for Lucene 9.1.0

The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

You can run the smoke tester directly with this command:

python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here is my +1.



Julie

Click the "Advanced" button for the "Invoke Gradle script" task, and you get the chance to pass "Project properties" as well as "Switches" and "System properties".

Jan

> 15. mar. 2022 kl. 13:12 skrev Uwe Schindler <uwe@thetaphi.de>:
>
> Hi,
>
> I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).
>
> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
> make sure no JARs/WARs in src dist...
> run "./gradlew --no-daemon check -p lucene/documentation"
> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...
>
> After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.
>
> There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):
> org.gradle.parallel=true
> org.gradle.priority=normal
> org.gradle.daemon=false
>
> org.gradle.workers.max=6
> tests.jvms=6
> tests.multiplier=3
>
> The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)
>
> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?
>
> Uwe
>
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de <https://www.thetaphi.de/>
> eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>
>
> From: Julie Tibshirani <julietibs@gmail.com>
> Sent: Tuesday, March 15, 2022 1:57 AM
> To: dev@lucene.apache.org
> Subject: [VOTE] Release Lucene 9.1.0 RC1
>
> Please vote for release candidate 1 for Lucene 9.1.0
>
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679 <https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679>
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679 <https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679>
>
> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1.
>
> Julie

Hi,



I figured out that you can pass the test args at end of command line after the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope that helps:



Now it starts tests like this:

https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false -Dtests.multiplier=1'...



I will try to do the same on ASF jenkins to prevent the same problem, because I am working on setting up the nightly smoketester job for 9.x branch.



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de



From: Uwe Schindler <uwe@thetaphi.de>
Sent: Tuesday, March 15, 2022 1:13 PM
To: dev@lucene.apache.org
Subject: RE: [VOTE] Release Lucene 9.1.0 RC1



Hi,



I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).



This worked for 9.0, but with 9.1 it hangs endless and does not finish:

make sure no JARs/WARs in src dist...

run "./gradlew --no-daemon check -p lucene/documentation"

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...



After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.



There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):

org.gradle.parallel=true

org.gradle.priority=normal

org.gradle.daemon=false



org.gradle.workers.max=6

tests.jvms=6

tests.multiplier=3



The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)



Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Julie Tibshirani <julietibs@gmail.com <mailto:julietibs@gmail.com> >
Sent: Tuesday, March 15, 2022 1:57 AM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: [VOTE] Release Lucene 9.1.0 RC1



Please vote for release candidate 1 for Lucene 9.1.0

The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

You can run the smoke tester directly with this command:

python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here is my +1.



Julie

That does not help for smoke tester ???? It has a hardcoded command line.



I figured out how to do it. You can passe xtra args at end of smoke tester command line.



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de



From: Jan Høydahl <jan.asf@cominvent.com>
Sent: Tuesday, March 15, 2022 1:33 PM
To: Lucene Dev <dev@lucene.apache.org>
Subject: Re: [VOTE] Release Lucene 9.1.0 RC1



Click the "Advanced" button for the "Invoke Gradle script" task, and you get the chance to pass "Project properties" as well as "Switches" and "System properties".



Jan





15. mar. 2022 kl. 13:12 skrev Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >:



Hi,



I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).



This worked for 9.0, but with 9.1 it hangs endless and does not finish:

make sure no JARs/WARs in src dist...

run "./gradlew --no-daemon check -p lucene/documentation"

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...



After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.



There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):

org.gradle.parallel=true

org.gradle.priority=normal

org.gradle.daemon=false



org.gradle.workers.max=6

tests.jvms=6

tests.multiplier=3



The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)



Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de <https://www.thetaphi.de/>

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Julie Tibshirani <julietibs@gmail.com <mailto:julietibs@gmail.com> >
Sent: Tuesday, March 15, 2022 1:57 AM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: [VOTE] Release Lucene 9.1.0 RC1



Please vote for release candidate 1 for Lucene 9.1.0

The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

You can run the smoke tester directly with this command:

python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here is my +1.



Julie

Ah, sure, makes sense. I'm trying to get smoketester to run in Jenkins for Solr as well, so struggling with some of the same issues there.

Jan

> 15. mar. 2022 kl. 13:41 skrev Uwe Schindler <uwe@thetaphi.de>:
>
> That does not help for smoke tester ???? It has a hardcoded command line.
>
> I figured out how to do it. You can passe xtra args at end of smoke tester command line.
>
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de <https://www.thetaphi.de/>
> eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>
>
> From: Jan Høydahl <jan.asf@cominvent.com>
> Sent: Tuesday, March 15, 2022 1:33 PM
> To: Lucene Dev <dev@lucene.apache.org>
> Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
>
> Click the "Advanced" button for the "Invoke Gradle script" task, and you get the chance to pass "Project properties" as well as "Switches" and "System properties".
>
> Jan
>
>
>> 15. mar. 2022 kl. 13:12 skrev Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de>>:
>>
>> Hi,
>>
>> I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).
>>
>> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
>> make sure no JARs/WARs in src dist...
>> run "./gradlew --no-daemon check -p lucene/documentation"
>> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...
>>
>> After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.
>>
>> There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):
>> org.gradle.parallel=true
>> org.gradle.priority=normal
>> org.gradle.daemon=false
>>
>> org.gradle.workers.max=6
>> tests.jvms=6
>> tests.multiplier=3
>>
>> The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)
>>
>> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?
>>
>> Uwe
>>
>> -----
>> Uwe Schindler
>> Achterdiek 19, D-28357 Bremen
>> https://www.thetaphi.de <https://www.thetaphi.de/>
>> eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>
>>
>> From: Julie Tibshirani <julietibs@gmail.com <mailto:julietibs@gmail.com>>
>> Sent: Tuesday, March 15, 2022 1:57 AM
>> To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
>> Subject: [VOTE] Release Lucene 9.1.0 RC1
>>
>> Please vote for release candidate 1 for Lucene 9.1.0
>>
>> The artifacts can be downloaded from:
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679 <https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679>
>>
>> You can run the smoke tester directly with this command:
>>
>> python3 -u dev-tools/scripts/smokeTestRelease.py \
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679 <https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679>
>>
>> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>> Here is my +1.
>>
>> Julie

On Tue, Mar 15, 2022 at 8:13 AM Uwe Schindler <uwe@thetaphi.de> wrote:
>
> The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)
>

Hi Uwe, I looked at one of these ASF jenkins logs:
https://ci-builds.apache.org/job/Lucene/job/Lucene-NightlyTests-main/575/console

You can see a lot of the problem may be just a few bad tests that get
super-slow with the parameters. Let's open issue and tone these down
to be reasonable? I don't think tests should require an hour of CPU
time, even with nightly and 3x multiplier.

The slowest tests (exceeding 500 ms) during this run:
3298.44s TestDoubleRangeFieldQueries.testRandomBig (:lucene:core)
2869.82s Test2BPostings.test (:lucene:core)
1951.74s TestLatLonDocValuesQueries.testRandomBig (:lucene:core)
1628.04s TestLatLonPointQueries.testRandomBig (:lucene:core)
1492.32s TestGeo3DPoint.testRandomBig (:lucene:spatial3d)
1481.19s TestXYDocValuesQueries.testRandomBig (:lucene:core)
1351.95s TestXYPointQueries.testRandomBig (:lucene:core)
940.30s TestLongRangeFieldQueries.testRandomBig (:lucene:core)
871.50s Test4GBStoredFields.test (:lucene:core)
743.00s TestFloatRangeFieldQueries.testRandomBig (:lucene:core)
The slowest suites (exceeding 1s) during this run:
3315.29s TestDoubleRangeFieldQueries (:lucene:core)
2869.92s Test2BPostings (:lucene:core)
2055.19s TestLatLonDocValuesQueries (:lucene:core)
1710.01s TestLatLonPointQueries (:lucene:core)
1556.67s TestLucene90DocValuesFormatMergeInstance (:lucene:core)
1547.51s TestXYDocValuesQueries (:lucene:core)
1526.50s TestGeo3DPoint (:lucene:spatial3d)
1510.20s TestSimpleTextTermVectorsFormat (:lucene:codecs)
1424.21s TestXYPointQueries (:lucene:core)
1375.18s TestLucene90DocValuesFormat (:lucene:core)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Hi,



Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work to override!



-P (project prop) takes precedence over -D (system prop) and the user’s values in gradle.properties are injected into build as project properties.



We should also change smoketester.py to pass the nightly with -P not -D, because those properties have highest precendence. Otherwise smoke tester can do different things behind the scenes. If you put tests.nightly=false into your gradle.properties, smoke tester won’t be able to override



@Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de



From: Uwe Schindler <uwe@thetaphi.de>
Sent: Tuesday, March 15, 2022 1:40 PM
To: dev@lucene.apache.org
Subject: RE: [VOTE] Release Lucene 9.1.0 RC1



Hi,



I figured out that you can pass the test args at end of command line after the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope that helps:



Now it starts tests like this:

https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false -Dtests.multiplier=1'...



I will try to do the same on ASF jenkins to prevent the same problem, because I am working on setting up the nightly smoketester job for 9.x branch.



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >
Sent: Tuesday, March 15, 2022 1:13 PM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: RE: [VOTE] Release Lucene 9.1.0 RC1



Hi,



I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).



This worked for 9.0, but with 9.1 it hangs endless and does not finish:

make sure no JARs/WARs in src dist...

run "./gradlew --no-daemon check -p lucene/documentation"

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...



After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.



There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):

org.gradle.parallel=true

org.gradle.priority=normal

org.gradle.daemon=false



org.gradle.workers.max=6

tests.jvms=6

tests.multiplier=3



The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)



Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Julie Tibshirani <julietibs@gmail.com <mailto:julietibs@gmail.com> >
Sent: Tuesday, March 15, 2022 1:57 AM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: [VOTE] Release Lucene 9.1.0 RC1



Please vote for release candidate 1 for Lucene 9.1.0

The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

You can run the smoke tester directly with this command:

python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here is my +1.



Julie

See my other mail: You have to pass -P instead of -D as only this overrides the properties file ?



Generally smoke tester should pass the extra flags using -P, not -D.



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de



From: Jan Høydahl <jan.asf@cominvent.com>
Sent: Tuesday, March 15, 2022 1:44 PM
To: dev@lucene.apache.org
Subject: Re: [VOTE] Release Lucene 9.1.0 RC1



Ah, sure, makes sense. I'm trying to get smoketester to run in Jenkins for Solr as well, so struggling with some of the same issues there.



Jan





15. mar. 2022 kl. 13:41 skrev Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >:



That does not help for smoke tester ???? It has a hardcoded command line.



I figured out how to do it. You can passe xtra args at end of smoke tester command line.



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de <https://www.thetaphi.de/>

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Jan Høydahl <jan.asf@cominvent.com <mailto:jan.asf@cominvent.com> >
Sent: Tuesday, March 15, 2022 1:33 PM
To: Lucene Dev <dev@lucene.apache.org <mailto:dev@lucene.apache.org> >
Subject: Re: [VOTE] Release Lucene 9.1.0 RC1



Click the "Advanced" button for the "Invoke Gradle script" task, and you get the chance to pass "Project properties" as well as "Switches" and "System properties".



Jan






15. mar. 2022 kl. 13:12 skrev Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >:



Hi,



I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).



This worked for 9.0, but with 9.1 it hangs endless and does not finish:

make sure no JARs/WARs in src dist...

run "./gradlew --no-daemon check -p lucene/documentation"

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...



After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.



There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):

org.gradle.parallel=true

org.gradle.priority=normal

org.gradle.daemon=false



org.gradle.workers.max=6

tests.jvms=6

tests.multiplier=3



The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)



Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de <https://www.thetaphi.de/>

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Julie Tibshirani <julietibs@gmail.com <mailto:julietibs@gmail.com> >
Sent: Tuesday, March 15, 2022 1:57 AM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: [VOTE] Release Lucene 9.1.0 RC1



Please vote for release candidate 1 for Lucene 9.1.0

The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

You can run the smoke tester directly with this command:

python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here is my +1.



Julie

> @Dawid: Is there any way to make -D and -P the same for gradle? Most
developers are used to “-D” (as I am), but gradle expects “-P” and the -D
support was only added by your hack. Could we change this
propertyOrDefault() hack in Gradle to make -D have higher prio?

Gradle doesn't recognize -D (system) properties at all within the build. I
added it manually for people like you, who are used to it. Typically, you'd
pass project properties with -P only. I would love to get rid of this -D
option entirely, eventually...

Dawid

On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de> wrote:

> Hi,
>
>
>
> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not
> work to override!
>
>
>
> -P (project prop) takes precedence over -D (system prop) and the user’s
> values in gradle.properties are injected into build as project properties.
>
>
>
> We should also change smoketester.py to pass the nightly with -P not -D,
> because those properties have highest precendence. Otherwise smoke tester
> can do different things behind the scenes. If you put tests.nightly=false
> into your gradle.properties, smoke tester won’t be able to override
>
>
>
> @Dawid: Is there any way to make -D and -P the same for gradle? Most
> developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> support was only added by your hack. Could we change this
> propertyOrDefault() hack in Gradle to make -D have higher prio?
>
>
>
> Uwe
>
>
>
> -----
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
>
> https://www.thetaphi.de
>
> eMail: uwe@thetaphi.de
>
>
>
> *From:* Uwe Schindler <uwe@thetaphi.de>
> *Sent:* Tuesday, March 15, 2022 1:40 PM
> *To:* dev@lucene.apache.org
> *Subject:* RE: [VOTE] Release Lucene 9.1.0 RC1
>
>
>
> Hi,
>
>
>
> I figured out that you can pass the test args at end of command line after
> the URL. I added -Dtests.multiplier=1 on the run command line in jenkins.
> Hope that helps:
>
>
>
> Now it starts tests like this:
>
> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
>
> run tests w/ Java 11 and testArgs='-Dtests.nightly=true
> -Dtests.badapples=false -Dtests.multiplier=1'...
>
>
>
> I will try to do the same on ASF jenkins to prevent the same problem,
> because I am working on setting up the nightly smoketester job for 9.x
> branch.
>
>
>
> Uwe
>
>
>
> -----
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
>
> https://www.thetaphi.de
>
> eMail: uwe@thetaphi.de
>
>
>
> *From:* Uwe Schindler <uwe@thetaphi.de>
> *Sent:* Tuesday, March 15, 2022 1:13 PM
> *To:* dev@lucene.apache.org
> *Subject:* RE: [VOTE] Release Lucene 9.1.0 RC1
>
>
>
> Hi,
>
>
>
> I have a problem with running Smoketester (like on every release) with
> Policeman Jenkins. There’s a job to execute smoke tester and it takes as
> parameters the branch name and the version number (incl. hash).
>
>
>
> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
>
> make sure no JARs/WARs in src dist...
>
> run "./gradlew --no-daemon check -p lucene/documentation"
>
> run tests w/ Java 11 and testArgs='-Dtests.nightly=true
> -Dtests.badapples=false '...
>
>
>
> After that nothing happens anymore. The CPUs use a lot at beginning, but
> it hangs at end with one cpu core 100% occupied. From the parameters it
> enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> environment.
>
>
>
> There is one important thing to note: Jenkins has a gradle.properties with
> the following lines (similar on ASF jenkins):
>
> org.gradle.parallel=true
>
> org.gradle.priority=normal
>
> org.gradle.daemon=false
>
>
>
> org.gradle.workers.max=6
>
> tests.jvms=6
>
> tests.multiplier=3
>
>
>
> The “tests.multiplier=3” looks like the problem. I have no idea how to
> stop this, because the gradle properties are injected through the config
> file. Is there a way to pass custom parameters. Maybe we should add
> “-Dtests.multiplier=1” to the command line. At least in combination with
> “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most
> nightly jobs taking forever)
>
>
>
> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?
>
>
>
> Uwe
>
>
>
> -----
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
>
> https://www.thetaphi.de
>
> eMail: uwe@thetaphi.de
>
>
>
> *From:* Julie Tibshirani <julietibs@gmail.com>
> *Sent:* Tuesday, March 15, 2022 1:57 AM
> *To:* dev@lucene.apache.org
> *Subject:* [VOTE] Release Lucene 9.1.0 RC1
>
>
>
> Please vote for release candidate 1 for Lucene 9.1.0
>
> The artifacts can be downloaded from:
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py \
>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
>
> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00
> UTC.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Here is my +1.
>
>
>
> Julie
>

> Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?

Perhaps this wasn't explicit - yes, if you modify that method (and
propertyOrDefaultOrEnv) then you can control the "priority" of these
properties.


On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>
>
> > @Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?
>
> Gradle doesn't recognize -D (system) properties at all within the build. I added it manually for people like you, who are used to it. Typically, you'd pass project properties with -P only. I would love to get rid of this -D option entirely, eventually...
>
> Dawid
>
> On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de> wrote:
>>
>> Hi,
>>
>>
>>
>> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work to override!
>>
>>
>>
>> -P (project prop) takes precedence over -D (system prop) and the user’s values in gradle.properties are injected into build as project properties.
>>
>>
>>
>> We should also change smoketester.py to pass the nightly with -P not -D, because those properties have highest precendence. Otherwise smoke tester can do different things behind the scenes. If you put tests.nightly=false into your gradle.properties, smoke tester won’t be able to override
>>
>>
>>
>> @Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?
>>
>>
>>
>> Uwe
>>
>>
>>
>> -----
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> https://www.thetaphi.de
>>
>> eMail: uwe@thetaphi.de
>>
>>
>>
>> From: Uwe Schindler <uwe@thetaphi.de>
>> Sent: Tuesday, March 15, 2022 1:40 PM
>> To: dev@lucene.apache.org
>> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
>>
>>
>>
>> Hi,
>>
>>
>>
>> I figured out that you can pass the test args at end of command line after the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope that helps:
>>
>>
>>
>> Now it starts tests like this:
>>
>> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
>>
>> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false -Dtests.multiplier=1'...
>>
>>
>>
>> I will try to do the same on ASF jenkins to prevent the same problem, because I am working on setting up the nightly smoketester job for 9.x branch.
>>
>>
>>
>> Uwe
>>
>>
>>
>> -----
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> https://www.thetaphi.de
>>
>> eMail: uwe@thetaphi.de
>>
>>
>>
>> From: Uwe Schindler <uwe@thetaphi.de>
>> Sent: Tuesday, March 15, 2022 1:13 PM
>> To: dev@lucene.apache.org
>> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
>>
>>
>>
>> Hi,
>>
>>
>>
>> I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).
>>
>>
>>
>> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
>>
>> make sure no JARs/WARs in src dist...
>>
>> run "./gradlew --no-daemon check -p lucene/documentation"
>>
>> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...
>>
>>
>>
>> After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.
>>
>>
>>
>> There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):
>>
>> org.gradle.parallel=true
>>
>> org.gradle.priority=normal
>>
>> org.gradle.daemon=false
>>
>>
>>
>> org.gradle.workers.max=6
>>
>> tests.jvms=6
>>
>> tests.multiplier=3
>>
>>
>>
>> The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)
>>
>>
>>
>> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?
>>
>>
>>
>> Uwe
>>
>>
>>
>> -----
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> https://www.thetaphi.de
>>
>> eMail: uwe@thetaphi.de
>>
>>
>>
>> From: Julie Tibshirani <julietibs@gmail.com>
>> Sent: Tuesday, March 15, 2022 1:57 AM
>> To: dev@lucene.apache.org
>> Subject: [VOTE] Release Lucene 9.1.0 RC1
>>
>>
>>
>> Please vote for release candidate 1 for Lucene 9.1.0
>>
>> The artifacts can be downloaded from:
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
>>
>> You can run the smoke tester directly with this command:
>>
>> python3 -u dev-tools/scripts/smokeTestRelease.py \
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
>>
>> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>> Here is my +1.
>>
>>
>>
>> Julie

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

+1 [1:15:46.282120]

On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>
> > Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?
>
> Perhaps this wasn't explicit - yes, if you modify that method (and
> propertyOrDefaultOrEnv) then you can control the "priority" of these
> properties.
>
>
> On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
> >
> >
> > > @Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?
> >
> > Gradle doesn't recognize -D (system) properties at all within the build. I added it manually for people like you, who are used to it. Typically, you'd pass project properties with -P only. I would love to get rid of this -D option entirely, eventually...
> >
> > Dawid
> >
> > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de> wrote:
> >>
> >> Hi,
> >>
> >>
> >>
> >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work to override!
> >>
> >>
> >>
> >> -P (project prop) takes precedence over -D (system prop) and the user’s values in gradle.properties are injected into build as project properties.
> >>
> >>
> >>
> >> We should also change smoketester.py to pass the nightly with -P not -D, because those properties have highest precendence. Otherwise smoke tester can do different things behind the scenes. If you put tests.nightly=false into your gradle.properties, smoke tester won’t be able to override
> >>
> >>
> >>
> >> @Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?
> >>
> >>
> >>
> >> Uwe
> >>
> >>
> >>
> >> -----
> >>
> >> Uwe Schindler
> >>
> >> Achterdiek 19, D-28357 Bremen
> >>
> >> https://www.thetaphi.de
> >>
> >> eMail: uwe@thetaphi.de
> >>
> >>
> >>
> >> From: Uwe Schindler <uwe@thetaphi.de>
> >> Sent: Tuesday, March 15, 2022 1:40 PM
> >> To: dev@lucene.apache.org
> >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> >>
> >>
> >>
> >> Hi,
> >>
> >>
> >>
> >> I figured out that you can pass the test args at end of command line after the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope that helps:
> >>
> >>
> >>
> >> Now it starts tests like this:
> >>
> >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> >>
> >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false -Dtests.multiplier=1'...
> >>
> >>
> >>
> >> I will try to do the same on ASF jenkins to prevent the same problem, because I am working on setting up the nightly smoketester job for 9.x branch.
> >>
> >>
> >>
> >> Uwe
> >>
> >>
> >>
> >> -----
> >>
> >> Uwe Schindler
> >>
> >> Achterdiek 19, D-28357 Bremen
> >>
> >> https://www.thetaphi.de
> >>
> >> eMail: uwe@thetaphi.de
> >>
> >>
> >>
> >> From: Uwe Schindler <uwe@thetaphi.de>
> >> Sent: Tuesday, March 15, 2022 1:13 PM
> >> To: dev@lucene.apache.org
> >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> >>
> >>
> >>
> >> Hi,
> >>
> >>
> >>
> >> I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).
> >>
> >>
> >>
> >> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
> >>
> >> make sure no JARs/WARs in src dist...
> >>
> >> run "./gradlew --no-daemon check -p lucene/documentation"
> >>
> >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...
> >>
> >>
> >>
> >> After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.
> >>
> >>
> >>
> >> There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):
> >>
> >> org.gradle.parallel=true
> >>
> >> org.gradle.priority=normal
> >>
> >> org.gradle.daemon=false
> >>
> >>
> >>
> >> org.gradle.workers.max=6
> >>
> >> tests.jvms=6
> >>
> >> tests.multiplier=3
> >>
> >>
> >>
> >> The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)
> >>
> >>
> >>
> >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?
> >>
> >>
> >>
> >> Uwe
> >>
> >>
> >>
> >> -----
> >>
> >> Uwe Schindler
> >>
> >> Achterdiek 19, D-28357 Bremen
> >>
> >> https://www.thetaphi.de
> >>
> >> eMail: uwe@thetaphi.de
> >>
> >>
> >>
> >> From: Julie Tibshirani <julietibs@gmail.com>
> >> Sent: Tuesday, March 15, 2022 1:57 AM
> >> To: dev@lucene.apache.org
> >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> >>
> >>
> >>
> >> Please vote for release candidate 1 for Lucene 9.1.0
> >>
> >> The artifacts can be downloaded from:
> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
> >>
> >> You can run the smoke tester directly with this command:
> >>
> >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
> >>
> >> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.
> >>
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove (and reason why)
> >>
> >> Here is my +1.
> >>
> >>
> >>
> >> Julie
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>


--
Adrien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Hi Dawid,



thanks for the feedback. As one step in between we should fix smoketester to pass properties to gradle using -P and not -D. That should be easy to do.



Thanks,

Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de



From: Dawid Weiss <dawid.weiss@gmail.com>
Sent: Tuesday, March 15, 2022 3:17 PM
To: Lucene Dev <dev@lucene.apache.org>
Subject: Re: [VOTE] Release Lucene 9.1.0 RC1





> @Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?



Gradle doesn't recognize -D (system) properties at all within the build. I added it manually for people like you, who are used to it. Typically, you'd pass project properties with -P only. I would love to get rid of this -D option entirely, eventually...



Dawid



On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> > wrote:

Hi,



Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work to override!



-P (project prop) takes precedence over -D (system prop) and the user’s values in gradle.properties are injected into build as project properties.



We should also change smoketester.py to pass the nightly with -P not -D, because those properties have highest precendence. Otherwise smoke tester can do different things behind the scenes. If you put tests.nightly=false into your gradle.properties, smoke tester won’t be able to override



@Dawid: Is there any way to make -D and -P the same for gradle? Most developers are used to “-D” (as I am), but gradle expects “-P” and the -D support was only added by your hack. Could we change this propertyOrDefault() hack in Gradle to make -D have higher prio?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >
Sent: Tuesday, March 15, 2022 1:40 PM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: RE: [VOTE] Release Lucene 9.1.0 RC1



Hi,



I figured out that you can pass the test args at end of command line after the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope that helps:



Now it starts tests like this:

https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false -Dtests.multiplier=1'...



I will try to do the same on ASF jenkins to prevent the same problem, because I am working on setting up the nightly smoketester job for 9.x branch.



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >
Sent: Tuesday, March 15, 2022 1:13 PM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: RE: [VOTE] Release Lucene 9.1.0 RC1



Hi,



I have a problem with running Smoketester (like on every release) with Policeman Jenkins. There’s a job to execute smoke tester and it takes as parameters the branch name and the version number (incl. hash).



This worked for 9.0, but with 9.1 it hangs endless and does not finish:

make sure no JARs/WARs in src dist...

run "./gradlew --no-daemon check -p lucene/documentation"

run tests w/ Java 11 and testArgs='-Dtests.nightly=true -Dtests.badapples=false '...



After that nothing happens anymore. The CPUs use a lot at beginning, but it hangs at end with one cpu core 100% occupied. From the parameters it enabled -Dtests.nightly=true. Is this wanted or somehow coming from environment.



There is one important thing to note: Jenkins has a gradle.properties with the following lines (similar on ASF jenkins):

org.gradle.parallel=true

org.gradle.priority=normal

org.gradle.daemon=false



org.gradle.workers.max=6

tests.jvms=6

tests.multiplier=3



The “tests.multiplier=3” looks like the problem. I have no idea how to stop this, because the gradle properties are injected through the config file. Is there a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1” to the command line. At least in combination with “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most nightly jobs taking forever)



Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1 branch?



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>



From: Julie Tibshirani <julietibs@gmail.com <mailto:julietibs@gmail.com> >
Sent: Tuesday, March 15, 2022 1:57 AM
To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
Subject: [VOTE] Release Lucene 9.1.0 RC1



Please vote for release candidate 1 for Lucene 9.1.0

The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

You can run the smoke tester directly with this command:

python3 -u dev-tools/scripts/smokeTestRelease.py \
https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679

The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here is my +1.



Julie

+1
SUCCESS! [1:44:48.902867]

Thanks Julie for being the release manager.

On Tue, Mar 15, 2022 at 10:32 AM Adrien Grand <jpountz@gmail.com> wrote:

> +1 [1:15:46.282120]
>
> On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
> >
> > > Could we change this propertyOrDefault() hack in Gradle to make -D
> have higher prio?
> >
> > Perhaps this wasn't explicit - yes, if you modify that method (and
> > propertyOrDefaultOrEnv) then you can control the "priority" of these
> > properties.
> >
> >
> > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> > >
> > >
> > > > @Dawid: Is there any way to make -D and -P the same for gradle? Most
> developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> support was only added by your hack. Could we change this
> propertyOrDefault() hack in Gradle to make -D have higher prio?
> > >
> > > Gradle doesn't recognize -D (system) properties at all within the
> build. I added it manually for people like you, who are used to it.
> Typically, you'd pass project properties with -P only. I would love to get
> rid of this -D option entirely, eventually...
> > >
> > > Dawid
> > >
> > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de> wrote:
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does
> not work to override!
> > >>
> > >>
> > >>
> > >> -P (project prop) takes precedence over -D (system prop) and the
> user’s values in gradle.properties are injected into build as project
> properties.
> > >>
> > >>
> > >>
> > >> We should also change smoketester.py to pass the nightly with -P not
> -D, because those properties have highest precendence. Otherwise smoke
> tester can do different things behind the scenes. If you put
> tests.nightly=false into your gradle.properties, smoke tester won’t be able
> to override
> > >>
> > >>
> > >>
> > >> @Dawid: Is there any way to make -D and -P the same for gradle? Most
> developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> support was only added by your hack. Could we change this
> propertyOrDefault() hack in Gradle to make -D have higher prio?
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de
> > >>
> > >>
> > >>
> > >> From: Uwe Schindler <uwe@thetaphi.de>
> > >> Sent: Tuesday, March 15, 2022 1:40 PM
> > >> To: dev@lucene.apache.org
> > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> I figured out that you can pass the test args at end of command line
> after the URL. I added -Dtests.multiplier=1 on the run command line in
> jenkins. Hope that helps:
> > >>
> > >>
> > >>
> > >> Now it starts tests like this:
> > >>
> > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> > >>
> > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true
> -Dtests.badapples=false -Dtests.multiplier=1'...
> > >>
> > >>
> > >>
> > >> I will try to do the same on ASF jenkins to prevent the same problem,
> because I am working on setting up the nightly smoketester job for 9.x
> branch.
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de
> > >>
> > >>
> > >>
> > >> From: Uwe Schindler <uwe@thetaphi.de>
> > >> Sent: Tuesday, March 15, 2022 1:13 PM
> > >> To: dev@lucene.apache.org
> > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> I have a problem with running Smoketester (like on every release)
> with Policeman Jenkins. There’s a job to execute smoke tester and it takes
> as parameters the branch name and the version number (incl. hash).
> > >>
> > >>
> > >>
> > >> This worked for 9.0, but with 9.1 it hangs endless and does not
> finish:
> > >>
> > >> make sure no JARs/WARs in src dist...
> > >>
> > >> run "./gradlew --no-daemon check -p lucene/documentation"
> > >>
> > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true
> -Dtests.badapples=false '...
> > >>
> > >>
> > >>
> > >> After that nothing happens anymore. The CPUs use a lot at beginning,
> but it hangs at end with one cpu core 100% occupied. From the parameters it
> enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> environment.
> > >>
> > >>
> > >>
> > >> There is one important thing to note: Jenkins has a gradle.properties
> with the following lines (similar on ASF jenkins):
> > >>
> > >> org.gradle.parallel=true
> > >>
> > >> org.gradle.priority=normal
> > >>
> > >> org.gradle.daemon=false
> > >>
> > >>
> > >>
> > >> org.gradle.workers.max=6
> > >>
> > >> tests.jvms=6
> > >>
> > >> tests.multiplier=3
> > >>
> > >>
> > >>
> > >> The “tests.multiplier=3” looks like the problem. I have no idea how
> to stop this, because the gradle properties are injected through the config
> file. Is there a way to pass custom parameters. Maybe we should add
> “-Dtests.multiplier=1” to the command line. At least in combination with
> “-Dtests.nightly=true” this seems to break (see ASF Jenkins which has most
> nightly jobs taking forever)
> > >>
> > >>
> > >>
> > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1
> branch?
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de
> > >>
> > >>
> > >>
> > >> From: Julie Tibshirani <julietibs@gmail.com>
> > >> Sent: Tuesday, March 15, 2022 1:57 AM
> > >> To: dev@lucene.apache.org
> > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Please vote for release candidate 1 for Lucene 9.1.0
> > >>
> > >> The artifacts can be downloaded from:
> > >>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
> > >>
> > >> You can run the smoke tester directly with this command:
> > >>
> > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> > >>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-a6114b532a273e370528675d551d3ddfa02f4679
> > >>
> > >> The vote will be open for at least 72 hours i.e. until 2022-03-18
> 00:00 UTC.
> > >>
> > >> [ ] +1 approve
> > >> [ ] +0 no opinion
> > >> [ ] -1 disapprove (and reason why)
> > >>
> > >> Here is my +1.
> > >>
> > >>
> > >>
> > >> Julie
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
> --
> Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Hi Julie,

Thanks for starting the release process! Many thanks for the work of fixing smoke tester. I was finally also able to run the smoke tester on my private Policeman Jenkins job to test the release (please note "-Ptests.multiplier=1" in command line):
https://jenkins.thetaphi.de/job/Lucene-Release-Tester/12/console

SUCCESS! [1:54:13.620821]
Finished: SUCCESS

This tested Java 11 and Java 17 (Eclipse Temurin JDK), this is why it took approximately 2 hours on the otherwise beefy machine.

I also unzipped the archives and verified Javadocs. Luke started with Windows and whitespace in path name. I was able to open an 8.x index from the backwards indexes.

Unfortunately I had no time to do a real module system test with a project, but I trust the integration tests that we added. Looking forward to get responses from Elastic about migration of Lucene and Elasticsearch to the Java module system!

Here is my +1 to release!

Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: uwe@thetaphi.de

> -----Original Message-----
> From: Adrien Grand <jpountz@gmail.com>
> Sent: Tuesday, March 15, 2022 3:32 PM
> To: Lucene Dev <dev@lucene.apache.org>
> Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
>
> +1 [1:15:46.282120]
>
> On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> >
> > > Could we change this propertyOrDefault() hack in Gradle to make -D have
> higher prio?
> >
> > Perhaps this wasn't explicit - yes, if you modify that method (and
> > propertyOrDefaultOrEnv) then you can control the "priority" of these
> > properties.
> >
> >
> > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> > >
> > >
> > > > @Dawid: Is there any way to make -D and -P the same for gradle? Most
> developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> support was only added by your hack. Could we change this
> propertyOrDefault() hack in Gradle to make -D have higher prio?
> > >
> > > Gradle doesn't recognize -D (system) properties at all within the build. I
> added it manually for people like you, who are used to it. Typically, you'd pass
> project properties with -P only. I would love to get rid of this -D option entirely,
> eventually...
> > >
> > > Dawid
> > >
> > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de>
> wrote:
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work
> to override!
> > >>
> > >>
> > >>
> > >> -P (project prop) takes precedence over -D (system prop) and the user’s
> values in gradle.properties are injected into build as project properties.
> > >>
> > >>
> > >>
> > >> We should also change smoketester.py to pass the nightly with -P not -D,
> because those properties have highest precendence. Otherwise smoke tester
> can do different things behind the scenes. If you put tests.nightly=false into
> your gradle.properties, smoke tester won’t be able to override
> > >>
> > >>
> > >>
> > >> @Dawid: Is there any way to make -D and -P the same for gradle? Most
> developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> support was only added by your hack. Could we change this
> propertyOrDefault() hack in Gradle to make -D have higher prio?
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de
> > >>
> > >>
> > >>
> > >> From: Uwe Schindler <uwe@thetaphi.de>
> > >> Sent: Tuesday, March 15, 2022 1:40 PM
> > >> To: dev@lucene.apache.org
> > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> I figured out that you can pass the test args at end of command line after
> the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope
> that helps:
> > >>
> > >>
> > >>
> > >> Now it starts tests like this:
> > >>
> > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> > >>
> > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> Dtests.badapples=false -Dtests.multiplier=1'...
> > >>
> > >>
> > >>
> > >> I will try to do the same on ASF jenkins to prevent the same problem,
> because I am working on setting up the nightly smoketester job for 9.x branch.
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de
> > >>
> > >>
> > >>
> > >> From: Uwe Schindler <uwe@thetaphi.de>
> > >> Sent: Tuesday, March 15, 2022 1:13 PM
> > >> To: dev@lucene.apache.org
> > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> I have a problem with running Smoketester (like on every release) with
> Policeman Jenkins. There’s a job to execute smoke tester and it takes as
> parameters the branch name and the version number (incl. hash).
> > >>
> > >>
> > >>
> > >> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
> > >>
> > >> make sure no JARs/WARs in src dist...
> > >>
> > >> run "./gradlew --no-daemon check -p lucene/documentation"
> > >>
> > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> Dtests.badapples=false '...
> > >>
> > >>
> > >>
> > >> After that nothing happens anymore. The CPUs use a lot at beginning, but
> it hangs at end with one cpu core 100% occupied. From the parameters it
> enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> environment.
> > >>
> > >>
> > >>
> > >> There is one important thing to note: Jenkins has a gradle.properties with
> the following lines (similar on ASF jenkins):
> > >>
> > >> org.gradle.parallel=true
> > >>
> > >> org.gradle.priority=normal
> > >>
> > >> org.gradle.daemon=false
> > >>
> > >>
> > >>
> > >> org.gradle.workers.max=6
> > >>
> > >> tests.jvms=6
> > >>
> > >> tests.multiplier=3
> > >>
> > >>
> > >>
> > >> The “tests.multiplier=3” looks like the problem. I have no idea how to stop
> this, because the gradle properties are injected through the config file. Is there
> a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1”
> to the command line. At least in combination with “-Dtests.nightly=true” this
> seems to break (see ASF Jenkins which has most nightly jobs taking forever)
> > >>
> > >>
> > >>
> > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1
> branch?
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de
> > >>
> > >>
> > >>
> > >> From: Julie Tibshirani <julietibs@gmail.com>
> > >> Sent: Tuesday, March 15, 2022 1:57 AM
> > >> To: dev@lucene.apache.org
> > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Please vote for release candidate 1 for Lucene 9.1.0
> > >>
> > >> The artifacts can be downloaded from:
> > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> a6114b532a273e370528675d551d3ddfa02f4679
> > >>
> > >> You can run the smoke tester directly with this command:
> > >>
> > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> a6114b532a273e370528675d551d3ddfa02f4679
> > >>
> > >> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.
> > >>
> > >> [ ] +1 approve
> > >> [ ] +0 no opinion
> > >> [ ] -1 disapprove (and reason why)
> > >>
> > >> Here is my +1.
> > >>
> > >>
> > >>
> > >> Julie
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
> --
> Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Thank you everyone who tested so far.

As we discussed on the other thread, Dawid found that an important
follow-up fix for LUCENE-10311 was not backported to branch_9_1. We decided
it was worth cancelling this vote and respinning an RC2 with this fix. So
this vote has failed. I will send out a new vote for RC2 tomorrow.

Separately, I noticed a warning in Uwe's build log around my GPG key ("GPG:
gpg: WARNING: This key is not certified with a trusted signature!"). I'm
not sure if this indicates an issue with my new key? Please let me know if
you have any insights/ suggestions -- I found the instructions for setting
up keys to be complex and I may have missed something.

Julie

On Tue, Mar 15, 2022 at 9:11 AM Uwe Schindler <uwe@thetaphi.de> wrote:

> Hi Julie,
>
> Thanks for starting the release process! Many thanks for the work of
> fixing smoke tester. I was finally also able to run the smoke tester on my
> private Policeman Jenkins job to test the release (please note
> "-Ptests.multiplier=1" in command line):
> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/12/console
>
> SUCCESS! [1:54:13.620821]
> Finished: SUCCESS
>
> This tested Java 11 and Java 17 (Eclipse Temurin JDK), this is why it took
> approximately 2 hours on the otherwise beefy machine.
>
> I also unzipped the archives and verified Javadocs. Luke started with
> Windows and whitespace in path name. I was able to open an 8.x index from
> the backwards indexes.
>
> Unfortunately I had no time to do a real module system test with a
> project, but I trust the integration tests that we added. Looking forward
> to get responses from Elastic about migration of Lucene and Elasticsearch
> to the Java module system!
>
> Here is my +1 to release!
>
> Uwe
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
> > -----Original Message-----
> > From: Adrien Grand <jpountz@gmail.com>
> > Sent: Tuesday, March 15, 2022 3:32 PM
> > To: Lucene Dev <dev@lucene.apache.org>
> > Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
> >
> > +1 [1:15:46.282120]
> >
> > On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com>
> > wrote:
> > >
> > > > Could we change this propertyOrDefault() hack in Gradle to make -D
> have
> > higher prio?
> > >
> > > Perhaps this wasn't explicit - yes, if you modify that method (and
> > > propertyOrDefaultOrEnv) then you can control the "priority" of these
> > > properties.
> > >
> > >
> > > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com>
> > wrote:
> > > >
> > > >
> > > > > @Dawid: Is there any way to make -D and -P the same for gradle?
> Most
> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> > support was only added by your hack. Could we change this
> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> > > >
> > > > Gradle doesn't recognize -D (system) properties at all within the
> build. I
> > added it manually for people like you, who are used to it. Typically,
> you'd pass
> > project properties with -P only. I would love to get rid of this -D
> option entirely,
> > eventually...
> > > >
> > > > Dawid
> > > >
> > > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de>
> > wrote:
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does
> not work
> > to override!
> > > >>
> > > >>
> > > >>
> > > >> -P (project prop) takes precedence over -D (system prop) and the
> user’s
> > values in gradle.properties are injected into build as project
> properties.
> > > >>
> > > >>
> > > >>
> > > >> We should also change smoketester.py to pass the nightly with -P
> not -D,
> > because those properties have highest precendence. Otherwise smoke tester
> > can do different things behind the scenes. If you put
> tests.nightly=false into
> > your gradle.properties, smoke tester won’t be able to override
> > > >>
> > > >>
> > > >>
> > > >> @Dawid: Is there any way to make -D and -P the same for gradle? Most
> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> > support was only added by your hack. Could we change this
> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: uwe@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Uwe Schindler <uwe@thetaphi.de>
> > > >> Sent: Tuesday, March 15, 2022 1:40 PM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> I figured out that you can pass the test args at end of command
> line after
> > the URL. I added -Dtests.multiplier=1 on the run command line in
> jenkins. Hope
> > that helps:
> > > >>
> > > >>
> > > >>
> > > >> Now it starts tests like this:
> > > >>
> > > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> > > >>
> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> > Dtests.badapples=false -Dtests.multiplier=1'...
> > > >>
> > > >>
> > > >>
> > > >> I will try to do the same on ASF jenkins to prevent the same
> problem,
> > because I am working on setting up the nightly smoketester job for 9.x
> branch.
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: uwe@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Uwe Schindler <uwe@thetaphi.de>
> > > >> Sent: Tuesday, March 15, 2022 1:13 PM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> I have a problem with running Smoketester (like on every release)
> with
> > Policeman Jenkins. There’s a job to execute smoke tester and it takes as
> > parameters the branch name and the version number (incl. hash).
> > > >>
> > > >>
> > > >>
> > > >> This worked for 9.0, but with 9.1 it hangs endless and does not
> finish:
> > > >>
> > > >> make sure no JARs/WARs in src dist...
> > > >>
> > > >> run "./gradlew --no-daemon check -p lucene/documentation"
> > > >>
> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> > Dtests.badapples=false '...
> > > >>
> > > >>
> > > >>
> > > >> After that nothing happens anymore. The CPUs use a lot at
> beginning, but
> > it hangs at end with one cpu core 100% occupied. From the parameters it
> > enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> > environment.
> > > >>
> > > >>
> > > >>
> > > >> There is one important thing to note: Jenkins has a
> gradle.properties with
> > the following lines (similar on ASF jenkins):
> > > >>
> > > >> org.gradle.parallel=true
> > > >>
> > > >> org.gradle.priority=normal
> > > >>
> > > >> org.gradle.daemon=false
> > > >>
> > > >>
> > > >>
> > > >> org.gradle.workers.max=6
> > > >>
> > > >> tests.jvms=6
> > > >>
> > > >> tests.multiplier=3
> > > >>
> > > >>
> > > >>
> > > >> The “tests.multiplier=3” looks like the problem. I have no idea how
> to stop
> > this, because the gradle properties are injected through the config
> file. Is there
> > a way to pass custom parameters. Maybe we should add
> “-Dtests.multiplier=1”
> > to the command line. At least in combination with “-Dtests.nightly=true”
> this
> > seems to break (see ASF Jenkins which has most nightly jobs taking
> forever)
> > > >>
> > > >>
> > > >>
> > > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1
> > branch?
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: uwe@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Julie Tibshirani <julietibs@gmail.com>
> > > >> Sent: Tuesday, March 15, 2022 1:57 AM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Please vote for release candidate 1 for Lucene 9.1.0
> > > >>
> > > >> The artifacts can be downloaded from:
> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> > a6114b532a273e370528675d551d3ddfa02f4679
> > > >>
> > > >> You can run the smoke tester directly with this command:
> > > >>
> > > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> > a6114b532a273e370528675d551d3ddfa02f4679
> > > >>
> > > >> The vote will be open for at least 72 hours i.e. until 2022-03-18
> 00:00 UTC.
> > > >>
> > > >> [ ] +1 approve
> > > >> [ ] +0 no opinion
> > > >> [ ] -1 disapprove (and reason why)
> > > >>
> > > >> Here is my +1.
> > > >>
> > > >>
> > > >>
> > > >> Julie
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > For additional commands, e-mail: dev-help@lucene.apache.org
> > >
> >
> >
> > --
> > Adrien
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Hi Julie,



Thank you for respinning!



About the GPG warnings: This is nothing critical. The warning message is a bit misleading and comes from the following fact:

* The smoke tester only imports the key file and verifies the signatures against that
* The smoke tester does not get any information about other people signing your key, because it does not look up the keys from public key servers to figure out how many people have verified your key (in person meeting).



The warning just says: “I was able to verify the signature and that it matches with a key from the key file of Apache. But I have no idea that you know the person or anybody else has verified this.” If you run smoke tester on your own it passes without warning, because you know yourself. ????



To get rid of the warning you would need to import the keys and then check them with key servers for cross-signatures or mark them as valid (you tell GPG that you know the person). Jenkins cannot do this – he isn’t a person that can meet you! ????



Uwe



-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

https://www.thetaphi.de

eMail: uwe@thetaphi.de



From: Julie Tibshirani <julietibs@gmail.com>
Sent: Tuesday, March 15, 2022 9:14 PM
To: dev@lucene.apache.org
Subject: Re: [VOTE] Release Lucene 9.1.0 RC1



Thank you everyone who tested so far.



As we discussed on the other thread, Dawid found that an important follow-up fix for LUCENE-10311 was not backported to branch_9_1. We decided it was worth cancelling this vote and respinning an RC2 with this fix. So this vote has failed. I will send out a new vote for RC2 tomorrow.



Separately, I noticed a warning in Uwe's build log around my GPG key ("GPG: gpg: WARNING: This key is not certified with a trusted signature!"). I'm not sure if this indicates an issue with my new key? Please let me know if you have any insights/ suggestions -- I found the instructions for setting up keys to be complex and I may have missed something.



Julie



On Tue, Mar 15, 2022 at 9:11 AM Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> > wrote:

Hi Julie,

Thanks for starting the release process! Many thanks for the work of fixing smoke tester. I was finally also able to run the smoke tester on my private Policeman Jenkins job to test the release (please note "-Ptests.multiplier=1" in command line):
https://jenkins.thetaphi.de/job/Lucene-Release-Tester/12/console

SUCCESS! [1:54:13.620821]
Finished: SUCCESS

This tested Java 11 and Java 17 (Eclipse Temurin JDK), this is why it took approximately 2 hours on the otherwise beefy machine.

I also unzipped the archives and verified Javadocs. Luke started with Windows and whitespace in path name. I was able to open an 8.x index from the backwards indexes.

Unfortunately I had no time to do a real module system test with a project, but I trust the integration tests that we added. Looking forward to get responses from Elastic about migration of Lucene and Elasticsearch to the Java module system!

Here is my +1 to release!

Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>

> -----Original Message-----
> From: Adrien Grand <jpountz@gmail.com <mailto:jpountz@gmail.com> >
> Sent: Tuesday, March 15, 2022 3:32 PM
> To: Lucene Dev <dev@lucene.apache.org <mailto:dev@lucene.apache.org> >
> Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
>
> +1 [1:15:46.282120]
>
> On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com <mailto:dawid.weiss@gmail.com> >
> wrote:
> >
> > > Could we change this propertyOrDefault() hack in Gradle to make -D have
> higher prio?
> >
> > Perhaps this wasn't explicit - yes, if you modify that method (and
> > propertyOrDefaultOrEnv) then you can control the "priority" of these
> > properties.
> >
> >
> > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com <mailto:dawid.weiss@gmail.com> >
> wrote:
> > >
> > >
> > > > @Dawid: Is there any way to make -D and -P the same for gradle? Most
> developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> support was only added by your hack. Could we change this
> propertyOrDefault() hack in Gradle to make -D have higher prio?
> > >
> > > Gradle doesn't recognize -D (system) properties at all within the build. I
> added it manually for people like you, who are used to it. Typically, you'd pass
> project properties with -P only. I would love to get rid of this -D option entirely,
> eventually...
> > >
> > > Dawid
> > >
> > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >
> wrote:
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work
> to override!
> > >>
> > >>
> > >>
> > >> -P (project prop) takes precedence over -D (system prop) and the user’s
> values in gradle.properties are injected into build as project properties.
> > >>
> > >>
> > >>
> > >> We should also change smoketester.py to pass the nightly with -P not -D,
> because those properties have highest precendence. Otherwise smoke tester
> can do different things behind the scenes. If you put tests.nightly=false into
> your gradle.properties, smoke tester won’t be able to override
> > >>
> > >>
> > >>
> > >> @Dawid: Is there any way to make -D and -P the same for gradle? Most
> developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> support was only added by your hack. Could we change this
> propertyOrDefault() hack in Gradle to make -D have higher prio?
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>
> > >>
> > >>
> > >>
> > >> From: Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >
> > >> Sent: Tuesday, March 15, 2022 1:40 PM
> > >> To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
> > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> I figured out that you can pass the test args at end of command line after
> the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope
> that helps:
> > >>
> > >>
> > >>
> > >> Now it starts tests like this:
> > >>
> > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> > >>
> > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> Dtests.badapples=false -Dtests.multiplier=1'...
> > >>
> > >>
> > >>
> > >> I will try to do the same on ASF jenkins to prevent the same problem,
> because I am working on setting up the nightly smoketester job for 9.x branch.
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>
> > >>
> > >>
> > >>
> > >> From: Uwe Schindler <uwe@thetaphi.de <mailto:uwe@thetaphi.de> >
> > >> Sent: Tuesday, March 15, 2022 1:13 PM
> > >> To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
> > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Hi,
> > >>
> > >>
> > >>
> > >> I have a problem with running Smoketester (like on every release) with
> Policeman Jenkins. There’s a job to execute smoke tester and it takes as
> parameters the branch name and the version number (incl. hash).
> > >>
> > >>
> > >>
> > >> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
> > >>
> > >> make sure no JARs/WARs in src dist...
> > >>
> > >> run "./gradlew --no-daemon check -p lucene/documentation"
> > >>
> > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> Dtests.badapples=false '...
> > >>
> > >>
> > >>
> > >> After that nothing happens anymore. The CPUs use a lot at beginning, but
> it hangs at end with one cpu core 100% occupied. From the parameters it
> enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> environment.
> > >>
> > >>
> > >>
> > >> There is one important thing to note: Jenkins has a gradle.properties with
> the following lines (similar on ASF jenkins):
> > >>
> > >> org.gradle.parallel=true
> > >>
> > >> org.gradle.priority=normal
> > >>
> > >> org.gradle.daemon=false
> > >>
> > >>
> > >>
> > >> org.gradle.workers.max=6
> > >>
> > >> tests.jvms=6
> > >>
> > >> tests.multiplier=3
> > >>
> > >>
> > >>
> > >> The “tests.multiplier=3” looks like the problem. I have no idea how to stop
> this, because the gradle properties are injected through the config file. Is there
> a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1”
> to the command line. At least in combination with “-Dtests.nightly=true” this
> seems to break (see ASF Jenkins which has most nightly jobs taking forever)
> > >>
> > >>
> > >>
> > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1
> branch?
> > >>
> > >>
> > >>
> > >> Uwe
> > >>
> > >>
> > >>
> > >> -----
> > >>
> > >> Uwe Schindler
> > >>
> > >> Achterdiek 19, D-28357 Bremen
> > >>
> > >> https://www.thetaphi.de
> > >>
> > >> eMail: uwe@thetaphi.de <mailto:uwe@thetaphi.de>
> > >>
> > >>
> > >>
> > >> From: Julie Tibshirani <julietibs@gmail.com <mailto:julietibs@gmail.com> >
> > >> Sent: Tuesday, March 15, 2022 1:57 AM
> > >> To: dev@lucene.apache.org <mailto:dev@lucene.apache.org>
> > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> > >>
> > >>
> > >>
> > >> Please vote for release candidate 1 for Lucene 9.1.0
> > >>
> > >> The artifacts can be downloaded from:
> > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> a6114b532a273e370528675d551d3ddfa02f4679
> > >>
> > >> You can run the smoke tester directly with this command:
> > >>
> > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> a6114b532a273e370528675d551d3ddfa02f4679
> > >>
> > >> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.
> > >>
> > >> [ ] +1 approve
> > >> [ ] +0 no opinion
> > >> [ ] -1 disapprove (and reason why)
> > >>
> > >> Here is my +1.
> > >>
> > >>
> > >>
> > >> Julie
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org <mailto:dev-unsubscribe@lucene.apache.org>
> > For additional commands, e-mail: dev-help@lucene.apache.org <mailto:dev-help@lucene.apache.org>
> >
>
>
> --
> Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org <mailto:dev-unsubscribe@lucene.apache.org>
> For additional commands, e-mail: dev-help@lucene.apache.org <mailto:dev-help@lucene.apache.org>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org <mailto:dev-unsubscribe@lucene.apache.org>
For additional commands, e-mail: dev-help@lucene.apache.org <mailto:dev-help@lucene.apache.org>

Thank you Uwe, that makes sense. Too bad I can't meet this Jenkins fellow,
he seems very hardworking :)

Julie

On Tue, Mar 15, 2022 at 4:20 PM Uwe Schindler <uwe@thetaphi.de> wrote:

> Hi Julie,
>
>
>
> Thank you for respinning!
>
>
>
> About the GPG warnings: This is nothing critical. The warning message is a
> bit misleading and comes from the following fact:
>
> - The smoke tester only imports the key file and verifies the
> signatures against that
> - The smoke tester does not get any information about other people
> signing your key, because it does not look up the keys from public key
> servers to figure out how many people have verified your key (in person
> meeting).
>
>
>
> The warning just says: “I was able to verify the signature and that it
> matches with a key from the key file of Apache. But I have no idea that you
> know the person or anybody else has verified this.” If you run smoke tester
> on your own it passes without warning, because you know yourself. ????
>
>
>
> To get rid of the warning you would need to import the keys and then check
> them with key servers for cross-signatures or mark them as valid (you tell
> GPG that you know the person). Jenkins cannot do this – he isn’t a person
> that can meet you! ????
>
>
>
> Uwe
>
>
>
> -----
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
>
> https://www.thetaphi.de
>
> eMail: uwe@thetaphi.de
>
>
>
> *From:* Julie Tibshirani <julietibs@gmail.com>
> *Sent:* Tuesday, March 15, 2022 9:14 PM
> *To:* dev@lucene.apache.org
> *Subject:* Re: [VOTE] Release Lucene 9.1.0 RC1
>
>
>
> Thank you everyone who tested so far.
>
>
>
> As we discussed on the other thread, Dawid found that an important
> follow-up fix for LUCENE-10311 was not backported to branch_9_1. We decided
> it was worth cancelling this vote and respinning an RC2 with this fix. So
> this vote has failed. I will send out a new vote for RC2 tomorrow.
>
>
>
> Separately, I noticed a warning in Uwe's build log around my GPG key
> ("GPG: gpg: WARNING: This key is not certified with a trusted signature!").
> I'm not sure if this indicates an issue with my new key? Please let me know
> if you have any insights/ suggestions -- I found the instructions for
> setting up keys to be complex and I may have missed something.
>
>
>
> Julie
>
>
>
> On Tue, Mar 15, 2022 at 9:11 AM Uwe Schindler <uwe@thetaphi.de> wrote:
>
> Hi Julie,
>
> Thanks for starting the release process! Many thanks for the work of
> fixing smoke tester. I was finally also able to run the smoke tester on my
> private Policeman Jenkins job to test the release (please note
> "-Ptests.multiplier=1" in command line):
> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/12/console
>
> SUCCESS! [1:54:13.620821]
> Finished: SUCCESS
>
> This tested Java 11 and Java 17 (Eclipse Temurin JDK), this is why it took
> approximately 2 hours on the otherwise beefy machine.
>
> I also unzipped the archives and verified Javadocs. Luke started with
> Windows and whitespace in path name. I was able to open an 8.x index from
> the backwards indexes.
>
> Unfortunately I had no time to do a real module system test with a
> project, but I trust the integration tests that we added. Looking forward
> to get responses from Elastic about migration of Lucene and Elasticsearch
> to the Java module system!
>
> Here is my +1 to release!
>
> Uwe
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
> > -----Original Message-----
> > From: Adrien Grand <jpountz@gmail.com>
> > Sent: Tuesday, March 15, 2022 3:32 PM
> > To: Lucene Dev <dev@lucene.apache.org>
> > Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
> >
> > +1 [1:15:46.282120]
> >
> > On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com>
> > wrote:
> > >
> > > > Could we change this propertyOrDefault() hack in Gradle to make -D
> have
> > higher prio?
> > >
> > > Perhaps this wasn't explicit - yes, if you modify that method (and
> > > propertyOrDefaultOrEnv) then you can control the "priority" of these
> > > properties.
> > >
> > >
> > > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com>
> > wrote:
> > > >
> > > >
> > > > > @Dawid: Is there any way to make -D and -P the same for gradle?
> Most
> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> > support was only added by your hack. Could we change this
> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> > > >
> > > > Gradle doesn't recognize -D (system) properties at all within the
> build. I
> > added it manually for people like you, who are used to it. Typically,
> you'd pass
> > project properties with -P only. I would love to get rid of this -D
> option entirely,
> > eventually...
> > > >
> > > > Dawid
> > > >
> > > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de>
> > wrote:
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does
> not work
> > to override!
> > > >>
> > > >>
> > > >>
> > > >> -P (project prop) takes precedence over -D (system prop) and the
> user’s
> > values in gradle.properties are injected into build as project
> properties.
> > > >>
> > > >>
> > > >>
> > > >> We should also change smoketester.py to pass the nightly with -P
> not -D,
> > because those properties have highest precendence. Otherwise smoke tester
> > can do different things behind the scenes. If you put
> tests.nightly=false into
> > your gradle.properties, smoke tester won’t be able to override
> > > >>
> > > >>
> > > >>
> > > >> @Dawid: Is there any way to make -D and -P the same for gradle? Most
> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
> > support was only added by your hack. Could we change this
> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: uwe@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Uwe Schindler <uwe@thetaphi.de>
> > > >> Sent: Tuesday, March 15, 2022 1:40 PM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> I figured out that you can pass the test args at end of command
> line after
> > the URL. I added -Dtests.multiplier=1 on the run command line in
> jenkins. Hope
> > that helps:
> > > >>
> > > >>
> > > >>
> > > >> Now it starts tests like this:
> > > >>
> > > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> > > >>
> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> > Dtests.badapples=false -Dtests.multiplier=1'...
> > > >>
> > > >>
> > > >>
> > > >> I will try to do the same on ASF jenkins to prevent the same
> problem,
> > because I am working on setting up the nightly smoketester job for 9.x
> branch.
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: uwe@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Uwe Schindler <uwe@thetaphi.de>
> > > >> Sent: Tuesday, March 15, 2022 1:13 PM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Hi,
> > > >>
> > > >>
> > > >>
> > > >> I have a problem with running Smoketester (like on every release)
> with
> > Policeman Jenkins. There’s a job to execute smoke tester and it takes as
> > parameters the branch name and the version number (incl. hash).
> > > >>
> > > >>
> > > >>
> > > >> This worked for 9.0, but with 9.1 it hangs endless and does not
> finish:
> > > >>
> > > >> make sure no JARs/WARs in src dist...
> > > >>
> > > >> run "./gradlew --no-daemon check -p lucene/documentation"
> > > >>
> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> > Dtests.badapples=false '...
> > > >>
> > > >>
> > > >>
> > > >> After that nothing happens anymore. The CPUs use a lot at
> beginning, but
> > it hangs at end with one cpu core 100% occupied. From the parameters it
> > enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> > environment.
> > > >>
> > > >>
> > > >>
> > > >> There is one important thing to note: Jenkins has a
> gradle.properties with
> > the following lines (similar on ASF jenkins):
> > > >>
> > > >> org.gradle.parallel=true
> > > >>
> > > >> org.gradle.priority=normal
> > > >>
> > > >> org.gradle.daemon=false
> > > >>
> > > >>
> > > >>
> > > >> org.gradle.workers.max=6
> > > >>
> > > >> tests.jvms=6
> > > >>
> > > >> tests.multiplier=3
> > > >>
> > > >>
> > > >>
> > > >> The “tests.multiplier=3” looks like the problem. I have no idea how
> to stop
> > this, because the gradle properties are injected through the config
> file. Is there
> > a way to pass custom parameters. Maybe we should add
> “-Dtests.multiplier=1”
> > to the command line. At least in combination with “-Dtests.nightly=true”
> this
> > seems to break (see ASF Jenkins which has most nightly jobs taking
> forever)
> > > >>
> > > >>
> > > >>
> > > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1
> > branch?
> > > >>
> > > >>
> > > >>
> > > >> Uwe
> > > >>
> > > >>
> > > >>
> > > >> -----
> > > >>
> > > >> Uwe Schindler
> > > >>
> > > >> Achterdiek 19, D-28357 Bremen
> > > >>
> > > >> https://www.thetaphi.de
> > > >>
> > > >> eMail: uwe@thetaphi.de
> > > >>
> > > >>
> > > >>
> > > >> From: Julie Tibshirani <julietibs@gmail.com>
> > > >> Sent: Tuesday, March 15, 2022 1:57 AM
> > > >> To: dev@lucene.apache.org
> > > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> > > >>
> > > >>
> > > >>
> > > >> Please vote for release candidate 1 for Lucene 9.1.0
> > > >>
> > > >> The artifacts can be downloaded from:
> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> > a6114b532a273e370528675d551d3ddfa02f4679
> > > >>
> > > >> You can run the smoke tester directly with this command:
> > > >>
> > > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> > a6114b532a273e370528675d551d3ddfa02f4679
> > > >>
> > > >> The vote will be open for at least 72 hours i.e. until 2022-03-18
> 00:00 UTC.
> > > >>
> > > >> [ ] +1 approve
> > > >> [ ] +0 no opinion
> > > >> [ ] -1 disapprove (and reason why)
> > > >>
> > > >> Here is my +1.
> > > >>
> > > >>
> > > >>
> > > >> Julie
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > For additional commands, e-mail: dev-help@lucene.apache.org
> > >
> >
> >
> > --
> > Adrien
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Hi Julie,

If you haven't started a new build already, I would like to include
https://issues.apache.org/jira/browse/LUCENE-10469 in the next release
candidate. It is a performance bug that manifests with
MatchAllDocsQuery wrapped inside of a ConstantScoreQuery.

On Wed, Mar 16, 2022 at 2:37 AM Julie Tibshirani <julietibs@gmail.com> wrote:
>
> Thank you Uwe, that makes sense. Too bad I can't meet this Jenkins fellow, he seems very hardworking :)
>
> Julie
>
> On Tue, Mar 15, 2022 at 4:20 PM Uwe Schindler <uwe@thetaphi.de> wrote:
>>
>> Hi Julie,
>>
>>
>>
>> Thank you for respinning!
>>
>>
>>
>> About the GPG warnings: This is nothing critical. The warning message is a bit misleading and comes from the following fact:
>>
>> The smoke tester only imports the key file and verifies the signatures against that
>> The smoke tester does not get any information about other people signing your key, because it does not look up the keys from public key servers to figure out how many people have verified your key (in person meeting).
>>
>>
>>
>> The warning just says: “I was able to verify the signature and that it matches with a key from the key file of Apache. But I have no idea that you know the person or anybody else has verified this.” If you run smoke tester on your own it passes without warning, because you know yourself. ????
>>
>>
>>
>> To get rid of the warning you would need to import the keys and then check them with key servers for cross-signatures or mark them as valid (you tell GPG that you know the person). Jenkins cannot do this – he isn’t a person that can meet you! ????
>>
>>
>>
>> Uwe
>>
>>
>>
>> -----
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> https://www.thetaphi.de
>>
>> eMail: uwe@thetaphi.de
>>
>>
>>
>> From: Julie Tibshirani <julietibs@gmail.com>
>> Sent: Tuesday, March 15, 2022 9:14 PM
>> To: dev@lucene.apache.org
>> Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
>>
>>
>>
>> Thank you everyone who tested so far.
>>
>>
>>
>> As we discussed on the other thread, Dawid found that an important follow-up fix for LUCENE-10311 was not backported to branch_9_1. We decided it was worth cancelling this vote and respinning an RC2 with this fix. So this vote has failed. I will send out a new vote for RC2 tomorrow.
>>
>>
>>
>> Separately, I noticed a warning in Uwe's build log around my GPG key ("GPG: gpg: WARNING: This key is not certified with a trusted signature!"). I'm not sure if this indicates an issue with my new key? Please let me know if you have any insights/ suggestions -- I found the instructions for setting up keys to be complex and I may have missed something.
>>
>>
>>
>> Julie
>>
>>
>>
>> On Tue, Mar 15, 2022 at 9:11 AM Uwe Schindler <uwe@thetaphi.de> wrote:
>>
>> Hi Julie,
>>
>> Thanks for starting the release process! Many thanks for the work of fixing smoke tester. I was finally also able to run the smoke tester on my private Policeman Jenkins job to test the release (please note "-Ptests.multiplier=1" in command line):
>> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/12/console
>>
>> SUCCESS! [1:54:13.620821]
>> Finished: SUCCESS
>>
>> This tested Java 11 and Java 17 (Eclipse Temurin JDK), this is why it took approximately 2 hours on the otherwise beefy machine.
>>
>> I also unzipped the archives and verified Javadocs. Luke started with Windows and whitespace in path name. I was able to open an 8.x index from the backwards indexes.
>>
>> Unfortunately I had no time to do a real module system test with a project, but I trust the integration tests that we added. Looking forward to get responses from Elastic about migration of Lucene and Elasticsearch to the Java module system!
>>
>> Here is my +1 to release!
>>
>> Uwe
>> -----
>> Uwe Schindler
>> Achterdiek 19, D-28357 Bremen
>> https://www.thetaphi.de
>> eMail: uwe@thetaphi.de
>>
>> > -----Original Message-----
>> > From: Adrien Grand <jpountz@gmail.com>
>> > Sent: Tuesday, March 15, 2022 3:32 PM
>> > To: Lucene Dev <dev@lucene.apache.org>
>> > Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
>> >
>> > +1 [1:15:46.282120]
>> >
>> > On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com>
>> > wrote:
>> > >
>> > > > Could we change this propertyOrDefault() hack in Gradle to make -D have
>> > higher prio?
>> > >
>> > > Perhaps this wasn't explicit - yes, if you modify that method (and
>> > > propertyOrDefaultOrEnv) then you can control the "priority" of these
>> > > properties.
>> > >
>> > >
>> > > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com>
>> > wrote:
>> > > >
>> > > >
>> > > > > @Dawid: Is there any way to make -D and -P the same for gradle? Most
>> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
>> > support was only added by your hack. Could we change this
>> > propertyOrDefault() hack in Gradle to make -D have higher prio?
>> > > >
>> > > > Gradle doesn't recognize -D (system) properties at all within the build. I
>> > added it manually for people like you, who are used to it. Typically, you'd pass
>> > project properties with -P only. I would love to get rid of this -D option entirely,
>> > eventually...
>> > > >
>> > > > Dawid
>> > > >
>> > > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de>
>> > wrote:
>> > > >>
>> > > >> Hi,
>> > > >>
>> > > >>
>> > > >>
>> > > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D” does not work
>> > to override!
>> > > >>
>> > > >>
>> > > >>
>> > > >> -P (project prop) takes precedence over -D (system prop) and the user’s
>> > values in gradle.properties are injected into build as project properties.
>> > > >>
>> > > >>
>> > > >>
>> > > >> We should also change smoketester.py to pass the nightly with -P not -D,
>> > because those properties have highest precendence. Otherwise smoke tester
>> > can do different things behind the scenes. If you put tests.nightly=false into
>> > your gradle.properties, smoke tester won’t be able to override
>> > > >>
>> > > >>
>> > > >>
>> > > >> @Dawid: Is there any way to make -D and -P the same for gradle? Most
>> > developers are used to “-D” (as I am), but gradle expects “-P” and the -D
>> > support was only added by your hack. Could we change this
>> > propertyOrDefault() hack in Gradle to make -D have higher prio?
>> > > >>
>> > > >>
>> > > >>
>> > > >> Uwe
>> > > >>
>> > > >>
>> > > >>
>> > > >> -----
>> > > >>
>> > > >> Uwe Schindler
>> > > >>
>> > > >> Achterdiek 19, D-28357 Bremen
>> > > >>
>> > > >> https://www.thetaphi.de
>> > > >>
>> > > >> eMail: uwe@thetaphi.de
>> > > >>
>> > > >>
>> > > >>
>> > > >> From: Uwe Schindler <uwe@thetaphi.de>
>> > > >> Sent: Tuesday, March 15, 2022 1:40 PM
>> > > >> To: dev@lucene.apache.org
>> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
>> > > >>
>> > > >>
>> > > >>
>> > > >> Hi,
>> > > >>
>> > > >>
>> > > >>
>> > > >> I figured out that you can pass the test args at end of command line after
>> > the URL. I added -Dtests.multiplier=1 on the run command line in jenkins. Hope
>> > that helps:
>> > > >>
>> > > >>
>> > > >>
>> > > >> Now it starts tests like this:
>> > > >>
>> > > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
>> > > >>
>> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
>> > Dtests.badapples=false -Dtests.multiplier=1'...
>> > > >>
>> > > >>
>> > > >>
>> > > >> I will try to do the same on ASF jenkins to prevent the same problem,
>> > because I am working on setting up the nightly smoketester job for 9.x branch.
>> > > >>
>> > > >>
>> > > >>
>> > > >> Uwe
>> > > >>
>> > > >>
>> > > >>
>> > > >> -----
>> > > >>
>> > > >> Uwe Schindler
>> > > >>
>> > > >> Achterdiek 19, D-28357 Bremen
>> > > >>
>> > > >> https://www.thetaphi.de
>> > > >>
>> > > >> eMail: uwe@thetaphi.de
>> > > >>
>> > > >>
>> > > >>
>> > > >> From: Uwe Schindler <uwe@thetaphi.de>
>> > > >> Sent: Tuesday, March 15, 2022 1:13 PM
>> > > >> To: dev@lucene.apache.org
>> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
>> > > >>
>> > > >>
>> > > >>
>> > > >> Hi,
>> > > >>
>> > > >>
>> > > >>
>> > > >> I have a problem with running Smoketester (like on every release) with
>> > Policeman Jenkins. There’s a job to execute smoke tester and it takes as
>> > parameters the branch name and the version number (incl. hash).
>> > > >>
>> > > >>
>> > > >>
>> > > >> This worked for 9.0, but with 9.1 it hangs endless and does not finish:
>> > > >>
>> > > >> make sure no JARs/WARs in src dist...
>> > > >>
>> > > >> run "./gradlew --no-daemon check -p lucene/documentation"
>> > > >>
>> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
>> > Dtests.badapples=false '...
>> > > >>
>> > > >>
>> > > >>
>> > > >> After that nothing happens anymore. The CPUs use a lot at beginning, but
>> > it hangs at end with one cpu core 100% occupied. From the parameters it
>> > enabled -Dtests.nightly=true. Is this wanted or somehow coming from
>> > environment.
>> > > >>
>> > > >>
>> > > >>
>> > > >> There is one important thing to note: Jenkins has a gradle.properties with
>> > the following lines (similar on ASF jenkins):
>> > > >>
>> > > >> org.gradle.parallel=true
>> > > >>
>> > > >> org.gradle.priority=normal
>> > > >>
>> > > >> org.gradle.daemon=false
>> > > >>
>> > > >>
>> > > >>
>> > > >> org.gradle.workers.max=6
>> > > >>
>> > > >> tests.jvms=6
>> > > >>
>> > > >> tests.multiplier=3
>> > > >>
>> > > >>
>> > > >>
>> > > >> The “tests.multiplier=3” looks like the problem. I have no idea how to stop
>> > this, because the gradle properties are injected through the config file. Is there
>> > a way to pass custom parameters. Maybe we should add “-Dtests.multiplier=1”
>> > to the command line. At least in combination with “-Dtests.nightly=true” this
>> > seems to break (see ASF Jenkins which has most nightly jobs taking forever)
>> > > >>
>> > > >>
>> > > >>
>> > > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the 9.1
>> > branch?
>> > > >>
>> > > >>
>> > > >>
>> > > >> Uwe
>> > > >>
>> > > >>
>> > > >>
>> > > >> -----
>> > > >>
>> > > >> Uwe Schindler
>> > > >>
>> > > >> Achterdiek 19, D-28357 Bremen
>> > > >>
>> > > >> https://www.thetaphi.de
>> > > >>
>> > > >> eMail: uwe@thetaphi.de
>> > > >>
>> > > >>
>> > > >>
>> > > >> From: Julie Tibshirani <julietibs@gmail.com>
>> > > >> Sent: Tuesday, March 15, 2022 1:57 AM
>> > > >> To: dev@lucene.apache.org
>> > > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
>> > > >>
>> > > >>
>> > > >>
>> > > >> Please vote for release candidate 1 for Lucene 9.1.0
>> > > >>
>> > > >> The artifacts can be downloaded from:
>> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
>> > a6114b532a273e370528675d551d3ddfa02f4679
>> > > >>
>> > > >> You can run the smoke tester directly with this command:
>> > > >>
>> > > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
>> > > >> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
>> > a6114b532a273e370528675d551d3ddfa02f4679
>> > > >>
>> > > >> The vote will be open for at least 72 hours i.e. until 2022-03-18 00:00 UTC.
>> > > >>
>> > > >> [ ] +1 approve
>> > > >> [ ] +0 no opinion
>> > > >> [ ] -1 disapprove (and reason why)
>> > > >>
>> > > >> Here is my +1.
>> > > >>
>> > > >>
>> > > >>
>> > > >> Julie
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> > > For additional commands, e-mail: dev-help@lucene.apache.org
>> > >
>> >
>> >
>> > --
>> > Adrien
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> > For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org



--
Adrien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Hi Adrien, this is good timing since I was just about to start building RC2
now. I'll include it.

Julie

On Wed, Mar 16, 2022 at 4:19 AM Adrien Grand <jpountz@gmail.com> wrote:

> Hi Julie,
>
> If you haven't started a new build already, I would like to include
> https://issues.apache.org/jira/browse/LUCENE-10469 in the next release
> candidate. It is a performance bug that manifests with
> MatchAllDocsQuery wrapped inside of a ConstantScoreQuery.
>
> On Wed, Mar 16, 2022 at 2:37 AM Julie Tibshirani <julietibs@gmail.com>
> wrote:
> >
> > Thank you Uwe, that makes sense. Too bad I can't meet this Jenkins
> fellow, he seems very hardworking :)
> >
> > Julie
> >
> > On Tue, Mar 15, 2022 at 4:20 PM Uwe Schindler <uwe@thetaphi.de> wrote:
> >>
> >> Hi Julie,
> >>
> >>
> >>
> >> Thank you for respinning!
> >>
> >>
> >>
> >> About the GPG warnings: This is nothing critical. The warning message
> is a bit misleading and comes from the following fact:
> >>
> >> The smoke tester only imports the key file and verifies the signatures
> against that
> >> The smoke tester does not get any information about other people
> signing your key, because it does not look up the keys from public key
> servers to figure out how many people have verified your key (in person
> meeting).
> >>
> >>
> >>
> >> The warning just says: “I was able to verify the signature and that it
> matches with a key from the key file of Apache. But I have no idea that you
> know the person or anybody else has verified this.” If you run smoke tester
> on your own it passes without warning, because you know yourself. ????
> >>
> >>
> >>
> >> To get rid of the warning you would need to import the keys and then
> check them with key servers for cross-signatures or mark them as valid (you
> tell GPG that you know the person). Jenkins cannot do this – he isn’t a
> person that can meet you! ????
> >>
> >>
> >>
> >> Uwe
> >>
> >>
> >>
> >> -----
> >>
> >> Uwe Schindler
> >>
> >> Achterdiek 19, D-28357 Bremen
> >>
> >> https://www.thetaphi.de
> >>
> >> eMail: uwe@thetaphi.de
> >>
> >>
> >>
> >> From: Julie Tibshirani <julietibs@gmail.com>
> >> Sent: Tuesday, March 15, 2022 9:14 PM
> >> To: dev@lucene.apache.org
> >> Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
> >>
> >>
> >>
> >> Thank you everyone who tested so far.
> >>
> >>
> >>
> >> As we discussed on the other thread, Dawid found that an important
> follow-up fix for LUCENE-10311 was not backported to branch_9_1. We decided
> it was worth cancelling this vote and respinning an RC2 with this fix. So
> this vote has failed. I will send out a new vote for RC2 tomorrow.
> >>
> >>
> >>
> >> Separately, I noticed a warning in Uwe's build log around my GPG key
> ("GPG: gpg: WARNING: This key is not certified with a trusted signature!").
> I'm not sure if this indicates an issue with my new key? Please let me know
> if you have any insights/ suggestions -- I found the instructions for
> setting up keys to be complex and I may have missed something.
> >>
> >>
> >>
> >> Julie
> >>
> >>
> >>
> >> On Tue, Mar 15, 2022 at 9:11 AM Uwe Schindler <uwe@thetaphi.de> wrote:
> >>
> >> Hi Julie,
> >>
> >> Thanks for starting the release process! Many thanks for the work of
> fixing smoke tester. I was finally also able to run the smoke tester on my
> private Policeman Jenkins job to test the release (please note
> "-Ptests.multiplier=1" in command line):
> >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/12/console
> >>
> >> SUCCESS! [1:54:13.620821]
> >> Finished: SUCCESS
> >>
> >> This tested Java 11 and Java 17 (Eclipse Temurin JDK), this is why it
> took approximately 2 hours on the otherwise beefy machine.
> >>
> >> I also unzipped the archives and verified Javadocs. Luke started with
> Windows and whitespace in path name. I was able to open an 8.x index from
> the backwards indexes.
> >>
> >> Unfortunately I had no time to do a real module system test with a
> project, but I trust the integration tests that we added. Looking forward
> to get responses from Elastic about migration of Lucene and Elasticsearch
> to the Java module system!
> >>
> >> Here is my +1 to release!
> >>
> >> Uwe
> >> -----
> >> Uwe Schindler
> >> Achterdiek 19, D-28357 Bremen
> >> https://www.thetaphi.de
> >> eMail: uwe@thetaphi.de
> >>
> >> > -----Original Message-----
> >> > From: Adrien Grand <jpountz@gmail.com>
> >> > Sent: Tuesday, March 15, 2022 3:32 PM
> >> > To: Lucene Dev <dev@lucene.apache.org>
> >> > Subject: Re: [VOTE] Release Lucene 9.1.0 RC1
> >> >
> >> > +1 [1:15:46.282120]
> >> >
> >> > On Tue, Mar 15, 2022 at 3:19 PM Dawid Weiss <dawid.weiss@gmail.com>
> >> > wrote:
> >> > >
> >> > > > Could we change this propertyOrDefault() hack in Gradle to make
> -D have
> >> > higher prio?
> >> > >
> >> > > Perhaps this wasn't explicit - yes, if you modify that method (and
> >> > > propertyOrDefaultOrEnv) then you can control the "priority" of these
> >> > > properties.
> >> > >
> >> > >
> >> > > On Tue, Mar 15, 2022 at 3:17 PM Dawid Weiss <dawid.weiss@gmail.com>
> >> > wrote:
> >> > > >
> >> > > >
> >> > > > > @Dawid: Is there any way to make -D and -P the same for gradle?
> Most
> >> > developers are used to “-D” (as I am), but gradle expects “-P” and
> the -D
> >> > support was only added by your hack. Could we change this
> >> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> >> > > >
> >> > > > Gradle doesn't recognize -D (system) properties at all within the
> build. I
> >> > added it manually for people like you, who are used to it. Typically,
> you'd pass
> >> > project properties with -P only. I would love to get rid of this -D
> option entirely,
> >> > eventually...
> >> > > >
> >> > > > Dawid
> >> > > >
> >> > > > On Tue, Mar 15, 2022 at 2:57 PM Uwe Schindler <uwe@thetaphi.de>
> >> > wrote:
> >> > > >>
> >> > > >> Hi,
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Small correction, I have to pass “-Ptests.multiplier=1”, “-D”
> does not work
> >> > to override!
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> -P (project prop) takes precedence over -D (system prop) and the
> user’s
> >> > values in gradle.properties are injected into build as project
> properties.
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> We should also change smoketester.py to pass the nightly with -P
> not -D,
> >> > because those properties have highest precendence. Otherwise smoke
> tester
> >> > can do different things behind the scenes. If you put
> tests.nightly=false into
> >> > your gradle.properties, smoke tester won’t be able to override
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> @Dawid: Is there any way to make -D and -P the same for gradle?
> Most
> >> > developers are used to “-D” (as I am), but gradle expects “-P” and
> the -D
> >> > support was only added by your hack. Could we change this
> >> > propertyOrDefault() hack in Gradle to make -D have higher prio?
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Uwe
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> -----
> >> > > >>
> >> > > >> Uwe Schindler
> >> > > >>
> >> > > >> Achterdiek 19, D-28357 Bremen
> >> > > >>
> >> > > >> https://www.thetaphi.de
> >> > > >>
> >> > > >> eMail: uwe@thetaphi.de
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> From: Uwe Schindler <uwe@thetaphi.de>
> >> > > >> Sent: Tuesday, March 15, 2022 1:40 PM
> >> > > >> To: dev@lucene.apache.org
> >> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Hi,
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> I figured out that you can pass the test args at end of command
> line after
> >> > the URL. I added -Dtests.multiplier=1 on the run command line in
> jenkins. Hope
> >> > that helps:
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Now it starts tests like this:
> >> > > >>
> >> > > >> https://jenkins.thetaphi.de/job/Lucene-Release-Tester/11/console
> >> > > >>
> >> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> >> > Dtests.badapples=false -Dtests.multiplier=1'...
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> I will try to do the same on ASF jenkins to prevent the same
> problem,
> >> > because I am working on setting up the nightly smoketester job for
> 9.x branch.
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Uwe
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> -----
> >> > > >>
> >> > > >> Uwe Schindler
> >> > > >>
> >> > > >> Achterdiek 19, D-28357 Bremen
> >> > > >>
> >> > > >> https://www.thetaphi.de
> >> > > >>
> >> > > >> eMail: uwe@thetaphi.de
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> From: Uwe Schindler <uwe@thetaphi.de>
> >> > > >> Sent: Tuesday, March 15, 2022 1:13 PM
> >> > > >> To: dev@lucene.apache.org
> >> > > >> Subject: RE: [VOTE] Release Lucene 9.1.0 RC1
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Hi,
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> I have a problem with running Smoketester (like on every
> release) with
> >> > Policeman Jenkins. There’s a job to execute smoke tester and it takes
> as
> >> > parameters the branch name and the version number (incl. hash).
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> This worked for 9.0, but with 9.1 it hangs endless and does not
> finish:
> >> > > >>
> >> > > >> make sure no JARs/WARs in src dist...
> >> > > >>
> >> > > >> run "./gradlew --no-daemon check -p lucene/documentation"
> >> > > >>
> >> > > >> run tests w/ Java 11 and testArgs='-Dtests.nightly=true -
> >> > Dtests.badapples=false '...
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> After that nothing happens anymore. The CPUs use a lot at
> beginning, but
> >> > it hangs at end with one cpu core 100% occupied. From the parameters
> it
> >> > enabled -Dtests.nightly=true. Is this wanted or somehow coming from
> >> > environment.
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> There is one important thing to note: Jenkins has a
> gradle.properties with
> >> > the following lines (similar on ASF jenkins):
> >> > > >>
> >> > > >> org.gradle.parallel=true
> >> > > >>
> >> > > >> org.gradle.priority=normal
> >> > > >>
> >> > > >> org.gradle.daemon=false
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> org.gradle.workers.max=6
> >> > > >>
> >> > > >> tests.jvms=6
> >> > > >>
> >> > > >> tests.multiplier=3
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> The “tests.multiplier=3” looks like the problem. I have no idea
> how to stop
> >> > this, because the gradle properties are injected through the config
> file. Is there
> >> > a way to pass custom parameters. Maybe we should add
> “-Dtests.multiplier=1”
> >> > to the command line. At least in combination with
> “-Dtests.nightly=true” this
> >> > seems to break (see ASF Jenkins which has most nightly jobs taking
> forever)
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Does anybody complain if I commit a -Dtests.multiplier=1 to the
> 9.1
> >> > branch?
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Uwe
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> -----
> >> > > >>
> >> > > >> Uwe Schindler
> >> > > >>
> >> > > >> Achterdiek 19, D-28357 Bremen
> >> > > >>
> >> > > >> https://www.thetaphi.de
> >> > > >>
> >> > > >> eMail: uwe@thetaphi.de
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> From: Julie Tibshirani <julietibs@gmail.com>
> >> > > >> Sent: Tuesday, March 15, 2022 1:57 AM
> >> > > >> To: dev@lucene.apache.org
> >> > > >> Subject: [VOTE] Release Lucene 9.1.0 RC1
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Please vote for release candidate 1 for Lucene 9.1.0
> >> > > >>
> >> > > >> The artifacts can be downloaded from:
> >> > > >>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> >> > a6114b532a273e370528675d551d3ddfa02f4679
> >> > > >>
> >> > > >> You can run the smoke tester directly with this command:
> >> > > >>
> >> > > >> python3 -u dev-tools/scripts/smokeTestRelease.py \
> >> > > >>
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.1.0-RC1-rev-
> >> > a6114b532a273e370528675d551d3ddfa02f4679
> >> > > >>
> >> > > >> The vote will be open for at least 72 hours i.e. until
> 2022-03-18 00:00 UTC.
> >> > > >>
> >> > > >> [ ] +1 approve
> >> > > >> [ ] +0 no opinion
> >> > > >> [ ] -1 disapprove (and reason why)
> >> > > >>
> >> > > >> Here is my +1.
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> Julie
> >> > >
> >> > >
> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> > > For additional commands, e-mail: dev-help@lucene.apache.org
> >> > >
> >> >
> >> >
> >> > --
> >> > Adrien
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> > For additional commands, e-mail: dev-help@lucene.apache.org
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
>
> --
> Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>