Mailing List Archive

BUG: crm_mon prints status of clone instances being started as 'Started'
Hi all,

It seems like lib/pengine/clone.c/clone_print() doesn't respect pending
state of clone/ms resource instances in the cumulative output:

short_print(list_text, child_text, rsc->variant == pe_master ?
"Slaves" : "Started", options,
print_data);


in by-node output crm_mon prints correct "Starting".

Best,
Vladislav

_______________________________________________
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org
Re: BUG: crm_mon prints status of clone instances being started as 'Started' [ In reply to ]
I'll push this up soon:

diff --git a/lib/pengine/clone.c b/lib/pengine/clone.c
index 596f701..b83798a 100644
--- a/lib/pengine/clone.c
+++ b/lib/pengine/clone.c
@@ -438,6 +438,10 @@ clone_print(resource_t * rsc, const char *pre_text, long options, void *print_da
/* Unique, unmanaged or failed clone */
print_full = TRUE;

+ } else if (is_set(options, pe_print_pending) && native_pending_state(child_rsc) != NULL) {
+ /* In a pending state */
+ print_full = TRUE;
+
} else if (child_rsc->fns->active(child_rsc, TRUE)) {
/* Fully active anonymous clone */
node_t *location = child_rsc->fns->location(child_rsc, NULL, TRUE);


> On 10 Jan 2015, at 12:16 am, Vladislav Bogdanov <bubble@hoster-ok.com> wrote:
>
> Hi all,
>
> It seems like lib/pengine/clone.c/clone_print() doesn't respect pending state of clone/ms resource instances in the cumulative output:
>
> short_print(list_text, child_text, rsc->variant == pe_master ? "Slaves" : "Started", options,
> print_data);
>
>
> in by-node output crm_mon prints correct "Starting".
>
> Best,
> Vladislav
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org


_______________________________________________
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org
Re: BUG: crm_mon prints status of clone instances being started as 'Started' [ In reply to ]
That fixes the issue, thanks.

12.01.2015 03:38, Andrew Beekhof wrote:
> I'll push this up soon:
>
> diff --git a/lib/pengine/clone.c b/lib/pengine/clone.c
> index 596f701..b83798a 100644
> --- a/lib/pengine/clone.c
> +++ b/lib/pengine/clone.c
> @@ -438,6 +438,10 @@ clone_print(resource_t * rsc, const char *pre_text, long options, void *print_da
> /* Unique, unmanaged or failed clone */
> print_full = TRUE;
>
> + } else if (is_set(options, pe_print_pending) && native_pending_state(child_rsc) != NULL) {
> + /* In a pending state */
> + print_full = TRUE;
> +
> } else if (child_rsc->fns->active(child_rsc, TRUE)) {
> /* Fully active anonymous clone */
> node_t *location = child_rsc->fns->location(child_rsc, NULL, TRUE);
>
>
>> On 10 Jan 2015, at 12:16 am, Vladislav Bogdanov <bubble@hoster-ok.com> wrote:
>>
>> Hi all,
>>
>> It seems like lib/pengine/clone.c/clone_print() doesn't respect pending state of clone/ms resource instances in the cumulative output:
>>
>> short_print(list_text, child_text, rsc->variant == pe_master ? "Slaves" : "Started", options,
>> print_data);
>>
>>
>> in by-node output crm_mon prints correct "Starting".
>>
>> Best,
>> Vladislav
>>
>> _______________________________________________
>> Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
>> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>>
>> Project Home: http://www.clusterlabs.org
>> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>> Bugs: http://bugs.clusterlabs.org
>
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org
>


_______________________________________________
Pacemaker mailing list: Pacemaker@oss.clusterlabs.org
http://oss.clusterlabs.org/mailman/listinfo/pacemaker

Project Home: http://www.clusterlabs.org
Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
Bugs: http://bugs.clusterlabs.org