Mailing List Archive

[PATCH 0 of 2] Autotoolize build
Lars,

I did this as an exercise of sorts to understand how this compiles and
what its dependencies are. Considering the code base is quite small
it may seem like a pointless stunt to jump through all the autofoo
hoops, but it makes life that much easier for distro packagers.

Feel free to apply this as you see fit.

Cheers,
Florian
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On Tue, May 29, 2012 at 2:27 PM, Florian Haas <florian@hastexo.com> wrote:
> Lars,
>
> I did this as an exercise of sorts to understand how this compiles and
> what its dependencies are. Considering the code base is quite small
> it may seem like a pointless stunt to jump through all the autofoo
> hoops, but it makes life that much easier for distro packagers.

Forgot to mention this in the original cover message, for those who
haven't been following the discussion: this is for sbd which is just
spinning off from cluster-glue.

Cheers,
Florian

--
Need help with High Availability?
http://www.hastexo.com/now
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On 2012-05-29T14:31:20, Florian Haas <florian@hastexo.com> wrote:

> Forgot to mention this in the original cover message, for those who
> haven't been following the discussion: this is for sbd which is just
> spinning off from cluster-glue.

Thanks, I've merged them both!


Regards,
Lars

--
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On Tue, May 29, 2012 at 4:32 PM, Lars Marowsky-Bree <lmb@suse.com> wrote:
> On 2012-05-29T14:31:20, Florian Haas <florian@hastexo.com> wrote:
>
>> Forgot to mention this in the original cover message, for those who
>> haven't been following the discussion: this is for sbd which is just
>> spinning off from cluster-glue.
>
> Thanks, I've merged them both!

In case you're wondering why I didn't use PKG_CHECK_MODULES for the PE
libraries: their pkg-config file is currently broken; Andrew has a
pull request for Pacemaker for that.

Cheers,
Florian
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On 2012-05-29T17:56:59, Florian Haas <florian@hastexo.com> wrote:

> In case you're wondering why I didn't use PKG_CHECK_MODULES for the PE
> libraries: their pkg-config file is currently broken; Andrew has a
> pull request for Pacemaker for that.

I was wondering more about how to build this against older codebases,
but then decided not to bother ;-)

The code seems to be working quite well. A README and a manpage would
probably be good ideas ...


Regards,
Lars

--
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On Tue, May 29, 2012 at 6:26 PM, Lars Marowsky-Bree <lmb@suse.com> wrote:
> On 2012-05-29T17:56:59, Florian Haas <florian@hastexo.com> wrote:
>
>> In case you're wondering why I didn't use PKG_CHECK_MODULES for the PE
>> libraries: their pkg-config file is currently broken; Andrew has a
>> pull request for Pacemaker for that.
>
> I was wondering more about how to build this against older codebases,
> but then decided not to bother ;-)

Yeah, it seems you just broke the build by including cluster/stack.h
and not bothering to add an AC_CHECK_HEADERS to configure.ac. Where
does that come from, is that new to Pacemaker?

> The code seems to be working quite well. A README and a manpage would
> probably be good ideas ...

Well autofoo already gave you an INSTALL file, and you can use
help2man for the man page generation (look at booth for the
Makefile.am and configure.ac hack). For the README, copy your wiki
page.

--
Need help with High Availability?
http://www.hastexo.com/now
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On 2012-05-29T18:34:15, Florian Haas <florian@hastexo.com> wrote:

> Yeah, it seems you just broke the build by including cluster/stack.h
> and not bothering to add an AC_CHECK_HEADERS to configure.ac. Where
> does that come from, is that new to Pacemaker?

Uh? It builds here on the 1.1.7 pacemaker version.

The integration with the cluster stack is rather specific to whatever
pacemaker/corosync version + configuration you build against.
Unfortunately.


Regards,
Lars

--
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On Tue, May 29, 2012 at 6:38 PM, Lars Marowsky-Bree <lmb@suse.com> wrote:
> On 2012-05-29T18:34:15, Florian Haas <florian@hastexo.com> wrote:
>
>> Yeah, it seems you just broke the build by including cluster/stack.h
>> and not bothering to add an AC_CHECK_HEADERS to configure.ac. Where
>> does that come from, is that new to Pacemaker?
>
> Uh? It builds here on the 1.1.7 pacemaker version.
>
> The integration with the cluster stack is rather specific to whatever
> pacemaker/corosync version + configuration you build against.
> Unfortunately.

Well that's what #ifdef HAVE_CLUSTER_STACK_H and friends are good for, no?

Florian
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH 0 of 2] Autotoolize build [ In reply to ]
On 2012-05-29T18:57:30, Florian Haas <florian@hastexo.com> wrote:

> > The integration with the cluster stack is rather specific to whatever
> > pacemaker/corosync version + configuration you build against.
> > Unfortunately.
> Well that's what #ifdef HAVE_CLUSTER_STACK_H and friends are good for, no?

I know. I just didn't know before that this was one of those cases ;-)


Regards,
Lars

--
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/