Mailing List Archive

Request to everybody adding tag
Hi

Everybody adding tag please add "-a" or "-s" option.
Because the script uses "git describe" when I make "rpm package ", a package is made with a strange value.

Regards,
Tomo

--
Tomoya Nozawa

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: Request to everybody adding tag [ In reply to ]
On Mon, May 28, 2012 at 04:40:04PM +0900, nozawat@gmail.com wrote:
> Hi
>
> Everybody adding tag please add "-a" or "-s" option.
> Because the script uses "git describe" when I make "rpm package ", a package is made with a strange value.

Even though many Pacemaker tags are neither signed nor annotated as well
(afaics), given the timing, I assume you refer to the recent
resource-agents v3.9.3 release. Signed tag has been added for that one.


Did you know "git describe --tags" ?


Thanks,

--
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: Request to everybody adding tag [ In reply to ]
Hi Lars,

> resource-agents v3.9.3 release. Signed tag has been added for that one.
Thanks for your quick response.

> Did you know "git describe --tags" ?
I did not know it.
Should I make modifications as follows?

----------------
diff --git a/make/git-version-gen b/make/git-version-gen
index 795a98b..1a9a740 100755
--- a/make/git-version-gen
+++ b/make/git-version-gen
@@ -102,8 +102,8 @@ then
# directory, and "git describe" output looks sensible, use that to
# derive a version string.
elif test "`git log -1 --pretty=format:x . 2>&1`" = x \
- && v=`git describe --abbrev=4 --match='v*' HEAD 2>/dev/null \
- || git describe --abbrev=4 HEAD 2>/dev/null` \
+ && v=`git describe --tag --abbrev=4 --match='v*' HEAD 2>/dev/null \
+ || git describe --tag --abbrev=4 HEAD 2>/dev/null` \
&& v=`printf '%s\n' "$v" | sed "$tag_sed_script"` \
&& case $v in
v[0-9]*) ;;
----------------

Regards,
Tomo

On Wed, 30 May 2012 10:47:56 +0200
Lars Ellenberg <lars.ellenberg@linbit.com> wrote:

> On Mon, May 28, 2012 at 04:40:04PM +0900, nozawat@gmail.com wrote:
> > Hi
> >
> > Everybody adding tag please add "-a" or "-s" option.
> > Because the script uses "git describe" when I make "rpm package ", a package is made with a strange value.
>
> Even though many Pacemaker tags are neither signed nor annotated as well
> (afaics), given the timing, I assume you refer to the recent
> resource-agents v3.9.3 release. Signed tag has been added for that one.
>
>
> Did you know "git describe --tags" ?
>
>
> Thanks,
>
> --
> : Lars Ellenberg
> : LINBIT | Your Way to High Availability
> : DRBD/HA support and consulting http://www.linbit.com
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

--
Tomoya Nozawa

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/