Mailing List Archive: Major mysql-proxy resource agent update

Major mysql-proxy resource agent update - request for review

May 15, 2012, 3:21 AM

Post #1 of 7 (3669 views)

Hi!

I revisited the mysql-proxy resource agent and introduced a fair number
of changes. I kindly request someone to review them and provide
me with some feedback!

I still have a number of TODOs left but don't know if I'll have
them ready for the release candidate.

Moreover, I have only run the ocft tests and have not (yet) been using
the updated resource agent in my environment. If in doubt about the
impact of my changes, you can also leave them out for the upcoming
release.

Cheers,
Raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: Major mysql-proxy resource agent update - request for review [ In reply to ]

dejan at suse

May 15, 2012, 3:57 AM

Post #2 of 7 (3571 views)

Permalink

Hi Raoul,

On Tue, May 15, 2012 at 12:21:08PM +0200, Raoul Bhatia [IPAX] wrote:
> Hi!
>
> I revisited the mysql-proxy resource agent and introduced a fair number
> of changes. I kindly request someone to review them and provide
> me with some feedback!

Where's the changes? Nothing attached here. No URLs either. :)

Dejan

>
> I still have a number of TODOs left but don't know if I'll have
> them ready for the release candidate.
>
>
> Moreover, I have only run the ocft tests and have not (yet) been using
> the updated resource agent in my environment. If in doubt about the
> impact of my changes, you can also leave them out for the upcoming
> release.
>
>
> Cheers,
> Raoul
> --
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
> Technischer Leiter
>
> IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
> Barawitzkagasse 10/2/2/11 email. office@ipax.at
> 1190 Wien tel. +43 1 3670030
> FN 277995t HG Wien fax. +43 1 3670030 15
> ____________________________________________________________________
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: Major mysql-proxy resource agent update - request for review [ In reply to ]

r.bhatia at ipax

May 15, 2012, 4:15 AM

Post #3 of 7 (3592 views)

Permalink

On 2012-05-15 12:57, Dejan Muhamedagic wrote:
> Hi Raoul,
>
> On Tue, May 15, 2012 at 12:21:08PM +0200, Raoul Bhatia [IPAX] wrote:
>> Hi!
>>
>> I revisited the mysql-proxy resource agent and introduced a fair number
>> of changes. I kindly request someone to review them and provide
>> me with some feedback!
>
> Where's the changes? Nothing attached here. No URLs either. :)

wups :)
https://github.com/raoulbhatia/resource-agents/tree/mysql-proxy

Thanks,
Raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: Major mysql-proxy resource agent update - request for review [ In reply to ]

dejan at suse

May 15, 2012, 4:45 AM

Post #4 of 7 (3598 views)

Permalink

On Tue, May 15, 2012 at 01:15:16PM +0200, Raoul Bhatia [IPAX] wrote:
> On 2012-05-15 12:57, Dejan Muhamedagic wrote:
> >Hi Raoul,
> >
> >On Tue, May 15, 2012 at 12:21:08PM +0200, Raoul Bhatia [IPAX] wrote:
> >>Hi!
> >>
> >>I revisited the mysql-proxy resource agent and introduced a fair number
> >>of changes. I kindly request someone to review them and provide
> >>me with some feedback!
> >
> >Where's the changes? Nothing attached here. No URLs either. :)
>
> wups :)
> https://github.com/raoulbhatia/resource-agents/tree/mysql-proxy

Looks OK to me. If it works for you (you already have an ocft
thing, commendable!), then please create a pull request. Or can I
also pull directly from this branch?

Cheers,

Dejan

> Thanks,
> Raoul
> --
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
> Technischer Leiter
>
> IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
> Barawitzkagasse 10/2/2/11 email. office@ipax.at
> 1190 Wien tel. +43 1 3670030
> FN 277995t HG Wien fax. +43 1 3670030 15
> ____________________________________________________________________
>
>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: Major mysql-proxy resource agent update - request for review [ In reply to ]

r.bhatia at ipax

May 15, 2012, 5:18 AM

Post #5 of 7 (3569 views)

Permalink

On 2012-05-15 13:45, Dejan Muhamedagic wrote:
> Looks OK to me. If it works for you (you already have an ocft
> thing, commendable!), then please create a pull request. Or can I
> also pull directly from this branch?

Thank you. Please let me know how to proceed regarding
https://github.com/raoulbhatia/resource-agents/commit/cb6990007fac3b705f8b10ceed3d74f479524597#commitcomment-1332408

should i implement a seperate "validate_these_things_on_start_only()"
function?

Otherwise, i will issue a pull request soon.
(Maybe i get some more feedback from others by tomorrow?)

Thanks,
Raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: Major mysql-proxy resource agent update - request for review [ In reply to ]

r.bhatia at ipax

May 23, 2012, 1:51 AM

Post #6 of 7 (3542 views)

Permalink

On 2012-05-15 13:45, Dejan Muhamedagic wrote:
> On Tue, May 15, 2012 at 01:15:16PM +0200, Raoul Bhatia [IPAX] wrote:
>> On 2012-05-15 12:57, Dejan Muhamedagic wrote:
>>> Hi Raoul,
>>>
>>> On Tue, May 15, 2012 at 12:21:08PM +0200, Raoul Bhatia [IPAX] wrote:
>>>> Hi!
>>>>
>>>> I revisited the mysql-proxy resource agent and introduced a fair number
>>>> of changes. I kindly request someone to review them and provide
>>>> me with some feedback!
>>>
>>> Where's the changes? Nothing attached here. No URLs either. :)
>>
>> wups :)
>> https://github.com/raoulbhatia/resource-agents/tree/mysql-proxy
>
> Looks OK to me. If it works for you (you already have an ocft
> thing, commendable!), then please create a pull request. Or can I
> also pull directly from this branch?

I haven't heard back of anyone but you and haven't been able to
thoroughly test every new aspect of the resource agent yet.

Especially the new in-depth monitoring is not in production use right
now (will be in the next couple of weeks, hopefully).

Therefore, i would suggest to keep these patches out of the release
so that we spare us of an immediate bug fix release in case something
is not working as expected.

What do you think?

Cheers,
Raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: Major mysql-proxy resource agent update - request for review [ In reply to ]

dejan at suse

May 23, 2012, 2:06 AM

Post #7 of 7 (3563 views)

Permalink

On Wed, May 23, 2012 at 10:51:48AM +0200, Raoul Bhatia [IPAX] wrote:
> On 2012-05-15 13:45, Dejan Muhamedagic wrote:
> >On Tue, May 15, 2012 at 01:15:16PM +0200, Raoul Bhatia [IPAX] wrote:
> >>On 2012-05-15 12:57, Dejan Muhamedagic wrote:
> >>>Hi Raoul,
> >>>
> >>>On Tue, May 15, 2012 at 12:21:08PM +0200, Raoul Bhatia [IPAX] wrote:
> >>>>Hi!
> >>>>
> >>>>I revisited the mysql-proxy resource agent and introduced a fair number
> >>>>of changes. I kindly request someone to review them and provide
> >>>>me with some feedback!
> >>>
> >>>Where's the changes? Nothing attached here. No URLs either. :)
> >>
> >>wups :)
> >>https://github.com/raoulbhatia/resource-agents/tree/mysql-proxy
> >
> >Looks OK to me. If it works for you (you already have an ocft
> >thing, commendable!), then please create a pull request. Or can I
> >also pull directly from this branch?
>
> I haven't heard back of anyone but you and haven't been able to
> thoroughly test every new aspect of the resource agent yet.
>
> Especially the new in-depth monitoring is not in production use right
> now (will be in the next couple of weeks, hopefully).
>
> Therefore, i would suggest to keep these patches out of the release
> so that we spare us of an immediate bug fix release in case something
> is not working as expected.

I love quick bug fix releases ;-)

> What do you think?

Agreed. Let's keep for the next one.

Cheers,

Dejan

> Cheers,
> Raoul
> --
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
> Technischer Leiter
>
> IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
> Barawitzkagasse 10/2/2/11 email. office@ipax.at
> 1190 Wien tel. +43 1 3670030
> FN 277995t HG Wien fax. +43 1 3670030 15
> ____________________________________________________________________
>
>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/