Mailing List Archive

ocf:heartbeat:postfix postfix_running (was: Re: [Patch]The patch which revises log and an unnecessary loop for postfix resource agent.)
On 2011-11-18 15:16, Raoul Bhatia [IPAX] wrote:
> 1. we do not capture the "the Postfix mail system is not running"
> output. maybe this is a result from running in an interactive shell?

i can answer this myself.

postfix, at least on debian, only displays the output to stdout if
there is a connected terminal.

e.g.
> # postfix blar; echo $?
> postfix/postfix-script: fatal: usage: postfix start (or stop, reload, abort, flush, check, status, set-permissions, upgrade-configuration)
> 1
> # ssh localhost postfix blar; echo $?
> 1

so i do not know whether there is any sense in logging
the postfix_running output.

> 2. we log an error (rc 1) which actually is expected and good
> (postfix is not running; we're eligible to start it)
>
> the same happens upon stopping postfix:
>> Nov 18 15:01:07 m01 crmd: [2063]: info: do_lrm_rsc_op: Performing key=116:55885:0:9582c8d2-c69a-4d79-91f6-04ea7bbe1853 op=m-mail-postfix_stop_0 )
>> Nov 18 15:01:07 m01 lrmd: [2060]: info: rsc:m-mail-postfix stop[175] (pid 10420)
>> Nov 18 15:01:08 m01 postfix/postfix-script[10632]: the Postfix mail system is not running
>> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
>> Nov 18 15:01:08 m01 postfix/postfix-script[10652]: the Postfix mail system is not running
>> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
>> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix stopped.
>> Nov 18 15:01:08 m01 lrmd: [2060]: info: operation stop[175] on m-mail-postfix for client 2063: pid 10420 exited with return code 0

this is still a pending issue.

thanks,
raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: ocf:heartbeat:postfix postfix_running (was: Re: [Patch]The patch which revises log and an unnecessary loop for postfix resource agent.) [ In reply to ]
Hi Raoul,

> > 2. we log an error (rc 1) which actually is expected and good
> > (postfix is not running; we're eligible to start it)
> >
> > the same happens upon stopping postfix:
> >> Nov 18 15:01:07 m01 crmd: [2063]: info: do_lrm_rsc_op: Performing key=116:55885:0:9582c8d2-c69a-4d79-91f6-04ea7bbe1853 op=m-mail-postfix_stop_0 )
> >> Nov 18 15:01:07 m01 lrmd: [2060]: info: rsc:m-mail-postfix stop[175] (pid 10420)
> >> Nov 18 15:01:08 m01 postfix/postfix-script[10632]: the Postfix mail system is not running
> >> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
> >> Nov 18 15:01:08 m01 postfix/postfix-script[10652]: the Postfix mail system is not running
> >> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
> >> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix stopped.
> >> Nov 18 15:01:08 m01 lrmd: [2060]: info: operation stop[175] on m-mail-postfix for client 2063: pid 10420 exited with return code 0
>
> this is still a pending issue.

In my environment, the same log does not appear.

Nov 21 10:48:22 rhel6-1 attrd: [5964]: info: attrd_ha_callback: Update relayed from rhel6-2
Nov 21 10:48:22 rhel6-1 attrd: [5964]: info: attrd_trigger_update: Sending flush op to all hosts for: shutdown (1321840102)
Nov 21 10:48:22 rhel6-1 attrd: [5964]: info: attrd_perform_update: Sent update 8: shutdown=1321840102
Nov 21 10:48:23 rhel6-1 lrmd: [5962]: info: cancel_op: operation monitor[4] on prmDummy1 for client 5965, its parameters: CRM_meta_name=[monitor] crm_feature_set=[3.0.1] CRM_meta_on_fail=[restart] CRM_meta_interval=[10000] CRM_meta_timeout=[20000] cancelled
Nov 21 10:48:23 rhel6-1 crmd: [5965]: info: do_lrm_rsc_op: Performing key=6:2:0:bf49e695-7079-40fd-803b-f732619084f4 op=prmDummy1_stop_0 )
Nov 21 10:48:23 rhel6-1 lrmd: [5962]: info: rsc:prmDummy1 stop[5] (pid 6488)
Nov 21 10:48:23 rhel6-1 crmd: [5965]: info: process_lrm_event: LRM operation prmDummy1_monitor_10000 (call=4, status=1, cib-update=0, confirmed=true) Cancelled
Nov 21 10:48:26 rhel6-1 postfix(prmDummy1)[6488]: [6637]: INFO: Postfix status: ''. 1
Nov 21 10:48:26 rhel6-1 postfix(prmDummy1)[6488]: [6639]: INFO: Postfix stopped.
Nov 21 10:48:26 rhel6-1 lrmd: [5962]: info: operation stop[5] on prmDummy1 for client 5965: pid 6488 exited with return code 0
Nov 21 10:48:26 rhel6-1 crmd: [5965]: info: process_lrm_event: LRM operation prmDummy1_stop_0 (call=5, rc=0, cib-update=14, confirmed=true) ok
Nov 21 10:48:27 rhel6-1 crmd: [5965]: info: handle_request: Shutting down

It is judged that postfix works definitely and stops.

The version that I confirmed is 2.6.6 on RHEL6.1.

There seems to be a mistake with one patch.
The "postfix status" command does not seem to return a detailed result.
This is the same as "postfix check "command.

I think that next is more right.
* I abolished output and omitted output from log.

(snip)
postfix_running() {
local loglevel
loglevel=${1:-err}

# run Postfix status if available
if ocf_is_true $status_support; then
$binary $OPTION_CONFIG_DIR status 2>&1
ret=$?
if [ $ret -ne 0 ]; then
ocf_log $loglevel "Postfix status:" $ret
fi
return $ret
fi
(snip)

Best Regards,
Hideo Yamauchi.




--- On Sat, 2011/11/19, Raoul Bhatia [IPAX] <r.bhatia@ipax.at> wrote:

> On 2011-11-18 15:16, Raoul Bhatia [IPAX] wrote:
> > 1. we do not capture the "the Postfix mail system is not running"
> >      output. maybe this is a result from running in an interactive shell?
>
> i can answer this myself.
>
> postfix, at least on debian, only displays the output to stdout if
> there is a connected terminal.
>
> e.g.
> > # postfix blar; echo $?
> > postfix/postfix-script: fatal: usage: postfix start (or stop, reload, abort, flush, check, status, set-permissions, upgrade-configuration)
> > 1
> > # ssh localhost postfix blar; echo $?
> > 1
>
> so i do not know whether there is any sense in logging
> the postfix_running output.
>
> > 2. we log an error (rc 1) which actually is expected and good
> >     (postfix is not running; we're eligible to start it)
> >
> > the same happens upon stopping postfix:
> >> Nov 18 15:01:07 m01 crmd: [2063]: info: do_lrm_rsc_op: Performing key=116:55885:0:9582c8d2-c69a-4d79-91f6-04ea7bbe1853 op=m-mail-postfix_stop_0 )
> >> Nov 18 15:01:07 m01 lrmd: [2060]: info: rsc:m-mail-postfix stop[175] (pid 10420)
> >> Nov 18 15:01:08 m01 postfix/postfix-script[10632]: the Postfix mail system is not running
> >> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
> >> Nov 18 15:01:08 m01 postfix/postfix-script[10652]: the Postfix mail system is not running
> >> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix status: ''. 1
> >> Nov 18 15:01:08 m01 postfix[10420]: INFO: Postfix stopped.
> >> Nov 18 15:01:08 m01 lrmd: [2060]: info: operation stop[175] on m-mail-postfix for client 2063: pid 10420 exited with return code 0
>
> this is still a pending issue.
>
> thanks,
> raoul
> --
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc.          email.          r.bhatia@ipax.at
> Technischer Leiter
>
> IPAX - Aloy Bhatia Hava OG          web.          http://www.ipax.at
> Barawitzkagasse 10/2/2/11           email.            office@ipax.at
> 1190 Wien                           tel.               +43 1 3670030
> FN 277995t HG Wien                  fax.            +43 1 3670030 15
> ____________________________________________________________________
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: ocf:heartbeat:postfix postfix_running (was: Re: [Patch]The patch which revises log and an unnecessary loop for postfix resource agent.) [ In reply to ]
Hi Hideo-san!

On 2011-11-21 03:07, renayama19661014@ybb.ne.jp wrote:
> It is judged that postfix works definitely and stops.
>
> The version that I confirmed is 2.6.6 on RHEL6.1.
>
> There seems to be a mistake with one patch.
> The "postfix status" command does not seem to return a detailed result.
> This is the same as "postfix check "command.
>
> I think that next is more right.
> * I abolished output and omitted output from log.
>
> (snip)
> postfix_running() {
> local loglevel
> loglevel=${1:-err}
>
> # run Postfix status if available
> if ocf_is_true $status_support; then
> $binary $OPTION_CONFIG_DIR status 2>&1
> ret=$?
> if [ $ret -ne 0 ]; then
> ocf_log $loglevel "Postfix status:" $ret
> fi
> return $ret
> fi
> (snip)

i applied this change and also updated the other of ocf_log lines
a little bit:

https://github.com/raoulbhatia/resource-agents/commit/4a5afaa217

i would like to resolve another issue though:

if we expect to log an error, e.g.:

1. postfix stop
2. call postfix_running to see if postfix actually stopped.

so there is an expected error if postfix_running which will get
logged and will possibly trouble the admin, right?

thinking about how to solve this for the postfix ra (e.g. using a
"-q" parameter) i thought about using the ocf_run function.
but the ocf_run function will log an error too...

so i'll leave this issue until my other email is answered ;)

cheers,
raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia@ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office@ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: ocf:heartbeat:postfix postfix_running (was: Re: [Patch]The patch which revises log and an unnecessary loop for postfix resource agent.) [ In reply to ]
Hi Raoul,

Thank you for comment.

> https://github.com/raoulbhatia/resource-agents/commit/4a5afaa217

All right!
I confirmed it about your modified contents.

Cheers,
Hideo Yamauchi.



--- On Tue, 2011/11/22, Raoul Bhatia [IPAX] <r.bhatia@ipax.at> wrote:

> Hi Hideo-san!
>
> On 2011-11-21 03:07, renayama19661014@ybb.ne.jp wrote:
> > It is judged that postfix works definitely and stops.
> >
> > The version that I confirmed is 2.6.6 on RHEL6.1.
> >
> > There seems to be a mistake with one patch.
> > The "postfix status" command does not seem to return a detailed result.
> > This is the same as "postfix check "command.
> >
> > I think that next is more right.
> >   * I abolished output and omitted output from log.
> >
> > (snip)
> > postfix_running() {
> >      local loglevel
> >      loglevel=${1:-err}
> >
> >      # run Postfix status if available
> >      if ocf_is_true $status_support; then
> >          $binary $OPTION_CONFIG_DIR status 2>&1
> >          ret=$?
> >          if [ $ret -ne 0 ]; then
> >              ocf_log $loglevel "Postfix status:" $ret
> >          fi
> >          return $ret
> >      fi
> > (snip)
>
> i applied this change and also updated the other of ocf_log lines
> a little bit:
>
> https://github.com/raoulbhatia/resource-agents/commit/4a5afaa217
>
> i would like to resolve another issue though:
>
> if we expect to log an error, e.g.:
>
> 1. postfix stop
> 2. call postfix_running to see if postfix actually stopped.
>
> so there is an expected error if postfix_running which will get
> logged and will possibly trouble the admin, right?
>
> thinking about how to solve this for the postfix ra (e.g. using a
> "-q" parameter) i thought about using the ocf_run function.
> but the ocf_run function will log an error too...
>
> so i'll leave this issue until my other email is answered ;)
>
> cheers,
> raoul
> --
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc.          email.          r.bhatia@ipax.at
> Technischer Leiter
>
> IPAX - Aloy Bhatia Hava OG          web.          http://www.ipax.at
> Barawitzkagasse 10/2/2/11           email.            office@ipax.at
> 1190 Wien                           tel.               +43 1 3670030
> FN 277995t HG Wien                  fax.            +43 1 3670030 15
> ____________________________________________________________________
>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/