Mailing List Archive: [PATCH] ocf-tester permits a space character

[PATCH] ocf-tester permits a space character

Oct 17, 2011, 7:12 PM

Post #1 of 3 (906 views)

Hi

ocf-tester command is failed when -o option includes a space
character, see below.
------------------
# /usr/sbin/ocf-tester -n postgresql -o
pgctl="/usr/local/pgsql/bin/pg_ctl" -o
psql="/usr/local/pgsql/bin/psql" -o pgdata="/var/lib/pgsql/9.1/data/"
-o start_opt="-p 5432" pgsql
Beginning tests for pgsql...
/usr/sbin/ocf-tester: line 263: export: `5432': not a valid identifier
------------------

I attached a patch.

Best Regards,
Takatoshi MATSUO

Re: [PATCH] ocf-tester permits a space character [ In reply to ]

dejan at suse

Oct 18, 2011, 6:02 AM

Post #2 of 3 (879 views)

Permalink

Hi Takatoshi-san,

On Tue, Oct 18, 2011 at 11:12:35AM +0900, Takatoshi MATSUO wrote:
> Hi
>
> ocf-tester command is failed when -o option includes a space
> character, see below.
> ------------------
> # /usr/sbin/ocf-tester -n postgresql -o
> pgctl="/usr/local/pgsql/bin/pg_ctl" -o
> psql="/usr/local/pgsql/bin/psql" -o pgdata="/var/lib/pgsql/9.1/data/"
> -o start_opt="-p 5432" pgsql
> Beginning tests for pgsql...
> /usr/sbin/ocf-tester: line 263: export: `5432': not a valid identifier
> ------------------
>
> I attached a patch.

Many thanks for the patch. It's in the git repository now.

Cheers,

Dejan

> Best Regards,
> Takatoshi MATSUO

> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Re: [PATCH] ocf-tester permits a space character [ In reply to ]

matsuo.tak at gmail

Oct 18, 2011, 6:38 AM

Post #3 of 3 (869 views)

Permalink

Hi Dejan

Thank you for applying.

Best Regards,
Takatoshi MATSUO

2011/10/18 Dejan Muhamedagic <dejan@suse.de>:
> Hi Takatoshi-san,
>
> On Tue, Oct 18, 2011 at 11:12:35AM +0900, Takatoshi MATSUO wrote:
>> Hi
>>
>> ocf-tester command is failed when -o option includes a space
>> character, see below.
>> ------------------
>> # /usr/sbin/ocf-tester Â -n postgresql -o
>> pgctl="/usr/local/pgsql/bin/pg_ctl" -o
>> psql="/usr/local/pgsql/bin/psql" -o pgdata="/var/lib/pgsql/9.1/data/"
>> -o start_opt="-p 5432" pgsql
>> Beginning tests for pgsql...
>> /usr/sbin/ocf-tester: line 263: export: `5432': not a valid identifier
>> ------------------
>>
>> I attached a patch.
>
> Many thanks for the patch. It's in the git repository now.
>
> Cheers,
>
> Dejan
>
>> Best Regards,
>> Takatoshi MATSUO
>
>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Mailing List Archive

Mailing List Archive

Attached Files: