Mailing List Archive: List of possible duplicated include files in include/

List of possible duplicated include files in include/

Nov 4, 2007, 10:44 AM

Post #1 of 4 (749 views)

Here the number of false positives is overhelming, but perhaps there
are also _real_ duplicated include somewhere in the bunch:

include/acpi/acpi_bus.h:
#include <linux/device.h>

include/asm-alpha/core_cia.h:
#include <asm/io_trivial.h>

include/asm-arm/atomic.h:
#include <asm/system.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/clps7111.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/cs89712.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/clps7111.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-ia64/pgtable.h:
#include <asm/processor.h>

include/asm-m32r/m32r.h:
#include <asm/m32700ut/m32700ut_pld.h>

include/asm-mips/bitops.h:
#include <asm-generic/bitops/fls64.h>

include/asm-mips/tx4938/tx4938.h:
#include <asm/byteorder.h>

include/asm-powerpc/io.h:
#include <asm/io-defs.h>

include/asm-x86/elf.h:
#include <asm/processor.h>

include/asm-x86/msr.h:
#include <linux/errno.h>

include/asm-x86/smp_64.h:
#include <asm/thread_info.h>

include/linux/aio.h:
#include <linux/uio.h>

include/linux/aio.h:
#include <linux/aio_abi.h>

include/linux/atalk.h:
#include <asm/byteorder.h>

include/linux/cgroup.h:
#include <linux/cgroup_subsys.h>

include/linux/icmpv6.h:
#include <linux/skbuff.h>

include/linux/igmp.h:
#include <linux/skbuff.h>

include/linux/udp.h:
#include <linux/types.h>

include/net/ieee80211.h:
#include <linux/wireless.h>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: List of possible duplicated include files in include/ [ In reply to ]

rpjday at crashcourse

Nov 4, 2007, 10:48 AM

Post #2 of 4 (715 views)

Permalink

On Sun, 4 Nov 2007, Marco Costalba wrote:

> Here the number of false positives is overhelming, but perhaps there
> are also _real_ duplicated include somewhere in the bunch:
>
> include/acpi/acpi_bus.h:
> #include <linux/device.h>

... snip header file output ...

i deliberately left out header files from my script output. i can
tweak the script and add this to the web page as well.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: List of possible duplicated include files in include/ [ In reply to ]

mcostalba at gmail

Nov 4, 2007, 10:52 AM

Post #3 of 4 (717 views)

Permalink

On 11/4/07, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> On Sun, 4 Nov 2007, Marco Costalba wrote:
>
> > Here the number of false positives is overhelming, but perhaps there
> > are also _real_ duplicated include somewhere in the bunch:
> >
> > include/acpi/acpi_bus.h:
> > #include <linux/device.h>
>
> ... snip header file output ...
>
> i deliberately left out header files from my script output. i can
> tweak the script and add this to the web page as well.
>

Here the real job is to fliter out false positives more then print out
the list I would say ;-)

Marco
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: List of possible duplicated include files in include/ [ In reply to ]

rpjday at crashcourse

Nov 4, 2007, 11:01 AM

Post #4 of 4 (711 views)

Permalink

On Sun, 4 Nov 2007, Marco Costalba wrote:

> On 11/4/07, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > On Sun, 4 Nov 2007, Marco Costalba wrote:
> >
> > > Here the number of false positives is overhelming, but perhaps
> > > there are also _real_ duplicated include somewhere in the bunch:
> > >
> > > include/acpi/acpi_bus.h:
> > > #include <linux/device.h>
> >
> > ... snip header file output ...
> >
> > i deliberately left out header files from my script output. i can
> > tweak the script and add this to the web page as well.
> >
>
> Here the real job is to fliter out false positives more then print
> out the list I would say ;-)

i don't think there are a lot of false positives there and, in any
event, it's a case of diminishing returns -- if you can get most of
what you want with two minutes of quick-and-dirty scripting, there's
not much point in spending another 10 or 15 minutes trying to tidy
things up only a little.

just my $0.02 canadian, which is finally worth more than $0.02
american. :-)

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/