Mailing List Archive: [PATCH] Fix missing include of list.h in sysfs.h

[PATCH] Fix missing include of list.h in sysfs.h

Jan 17, 2007, 8:51 AM

Post #1 of 3 (319 views)

Sysfs.h uses definitions (e.g. struct list_head s_sibling) from list.h
but does not include it.

Signed-off-by: Frank Haverkamp <haver@vnet.ibm.com>
---
include/linux/sysfs.h | 1 +
1 file changed, 1 insertion(+)

--- ubi-2.6.git.orig/include/linux/sysfs.h
+++ ubi-2.6.git/include/linux/sysfs.h
@@ -11,6 +11,7 @@
#define _SYSFS_H_

#include <linux/compiler.h>
+#include <linux/list.h>
#include <asm/atomic.h>

struct kobject;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Fix missing include of list.h in sysfs.h [ In reply to ]

greg at kroah

Jan 17, 2007, 1:14 PM

Post #2 of 3 (303 views)

Permalink

On Wed, Jan 17, 2007 at 05:51:18PM +0100, Frank Haverkamp wrote:
> Sysfs.h uses definitions (e.g. struct list_head s_sibling) from list.h
> but does not include it.
>
> Signed-off-by: Frank Haverkamp <haver@vnet.ibm.com>
> ---
> include/linux/sysfs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> --- ubi-2.6.git.orig/include/linux/sysfs.h
> +++ ubi-2.6.git/include/linux/sysfs.h
> @@ -11,6 +11,7 @@
> #define _SYSFS_H_
>
> #include <linux/compiler.h>
> +#include <linux/list.h>
> #include <asm/atomic.h>

Does this currently cause a build error on any platform for 2.6.20-rc5?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Fix missing include of list.h in sysfs.h [ In reply to ]

haver at vnet

Jan 18, 2007, 12:25 AM

Post #3 of 3 (301 views)

Permalink

Hi Greg,

On Wed, 2007-01-17 at 13:14 -0800, Greg KH wrote:

> Does this currently cause a build error on any platform for 2.6.20-rc5?

Not that I know of. I saw it because a friend of mine tried to port
some old code and played with the include ordering. Somehow he got
a compile error doing it, and we found that it is strange that sysfs.h
is using structs from list.h but is not including it. As result I sent
the patch to propose that it gets included to avoid any possible
trouble.

Frank

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/