Mailing List Archive: [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute

[PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning

Apr 14, 2024, 9:43 AM

Post #1 of 3 (8 views)

The preceding "&" before th1520_execute_tuning is useless, remove it.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
index 7b55acd9830c..6206ff7615e8 100644
--- a/drivers/mmc/host/sdhci-of-dwcmshc.c
+++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
@@ -822,7 +822,7 @@ static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
.reset = th1520_sdhci_reset,
.adma_write_desc = dwcmshc_adma_write_desc,
.voltage_switch = dwcmshc_phy_1_8v_init,
- .platform_execute_tuning = &th1520_execute_tuning,
+ .platform_execute_tuning = th1520_execute_tuning,
};

static const struct sdhci_ops sdhci_dwcmshc_cv18xx_ops = {
--
2.43.0

Re: [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning [ In reply to ]

adrian.hunter at intel

Apr 14, 2024, 11:14 PM

Post #2 of 3 (4 views)

Permalink

On 14/04/24 19:43, Jisheng Zhang wrote:
> The preceding "&" before th1520_execute_tuning is useless, remove it.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 7b55acd9830c..6206ff7615e8 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -822,7 +822,7 @@ static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
> .reset = th1520_sdhci_reset,
> .adma_write_desc = dwcmshc_adma_write_desc,
> .voltage_switch = dwcmshc_phy_1_8v_init,
> - .platform_execute_tuning = &th1520_execute_tuning,
> + .platform_execute_tuning = th1520_execute_tuning,
> };
>
> static const struct sdhci_ops sdhci_dwcmshc_cv18xx_ops = {

Re: [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning [ In reply to ]

ulf.hansson at linaro

Apr 25, 2024, 9:21 AM

Post #3 of 3 (1 views)

Permalink

On Sun, 14 Apr 2024 at 18:57, Jisheng Zhang <jszhang@kernel.org> wrote:
>
> The preceding "&" before th1520_execute_tuning is useless, remove it.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

Applied for next, thanks!

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 7b55acd9830c..6206ff7615e8 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -822,7 +822,7 @@ static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
> .reset = th1520_sdhci_reset,
> .adma_write_desc = dwcmshc_adma_write_desc,
> .voltage_switch = dwcmshc_phy_1_8v_init,
> - .platform_execute_tuning = &th1520_execute_tuning,
> + .platform_execute_tuning = th1520_execute_tuning,
> };
>
> static const struct sdhci_ops sdhci_dwcmshc_cv18xx_ops = {
> --
> 2.43.0
>