Mailing List Archive: [PATCH v2 0/5] mmc: Constify struct sdhci

[PATCH v2 0/5] mmc: Constify struct sdhci_ops

Apr 14, 2024, 7:07 AM

Post #1 of 3 (2 views)

Hi,

Changes in v2:
- Patch 5 - sdhci-s3c: add __maybe_unused, reported by kernel test
robot.
- Link to v1: https://lore.kernel.org/r/20240414-mmc-const-sdhci-ops-v1-0-178539d68093@kernel.org

The local struct sdhci_ops can be made const for code safety.
No dependencies.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (5):
mmc: sdhci-esdhc-mcf: Constify struct sdhci_ops
mmc: sdhci-omap: Constify struct sdhci_ops
mmc: sdhci-sprd: Constify struct sdhci_ops
mmc: sdhci_am654: Constify struct sdhci_ops
mmc: sdhci-s3c: Choose sdhci_ops based on variant

drivers/mmc/host/sdhci-esdhc-mcf.c | 2 +-
drivers/mmc/host/sdhci-omap.c | 2 +-
drivers/mmc/host/sdhci-s3c.c | 31 +++++++++++++++++--------------
drivers/mmc/host/sdhci-sprd.c | 2 +-
drivers/mmc/host/sdhci_am654.c | 6 +++---
5 files changed, 23 insertions(+), 20 deletions(-)
---
base-commit: f67245b3062cdc225b37003085bdb2916e1670b6
change-id: 20240414-mmc-const-sdhci-ops-c85762883004

Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>

Re: [PATCH v2 0/5] mmc: Constify struct sdhci_ops [ In reply to ]

adrian.hunter at intel

Apr 14, 2024, 11:07 PM

Post #2 of 3 (2 views)

Permalink

On 14/04/24 17:07, Krzysztof Kozlowski wrote:
> Hi,
>
> Changes in v2:
> - Patch 5 - sdhci-s3c: add __maybe_unused, reported by kernel test
> robot.
> - Link to v1: https://lore.kernel.org/r/20240414-mmc-const-sdhci-ops-v1-0-178539d68093@kernel.org
>
> The local struct sdhci_ops can be made const for code safety.
> No dependencies.
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (5):
> mmc: sdhci-esdhc-mcf: Constify struct sdhci_ops
> mmc: sdhci-omap: Constify struct sdhci_ops
> mmc: sdhci-sprd: Constify struct sdhci_ops
> mmc: sdhci_am654: Constify struct sdhci_ops
> mmc: sdhci-s3c: Choose sdhci_ops based on variant
>
> drivers/mmc/host/sdhci-esdhc-mcf.c | 2 +-
> drivers/mmc/host/sdhci-omap.c | 2 +-
> drivers/mmc/host/sdhci-s3c.c | 31 +++++++++++++++++--------------
> drivers/mmc/host/sdhci-sprd.c | 2 +-
> drivers/mmc/host/sdhci_am654.c | 6 +++---
> 5 files changed, 23 insertions(+), 20 deletions(-)
> ---
> base-commit: f67245b3062cdc225b37003085bdb2916e1670b6
> change-id: 20240414-mmc-const-sdhci-ops-c85762883004
>
> Best regards,

For all:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Re: [PATCH v2 0/5] mmc: Constify struct sdhci_ops [ In reply to ]

ulf.hansson at linaro

Apr 25, 2024, 9:21 AM

Post #3 of 3 (2 views)

Permalink

On Sun, 14 Apr 2024 at 16:07, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Hi,
>
> Changes in v2:
> - Patch 5 - sdhci-s3c: add __maybe_unused, reported by kernel test
> robot.
> - Link to v1: https://lore.kernel.org/r/20240414-mmc-const-sdhci-ops-v1-0-178539d68093@kernel.org
>
> The local struct sdhci_ops can be made const for code safety.
> No dependencies.
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (5):
> mmc: sdhci-esdhc-mcf: Constify struct sdhci_ops
> mmc: sdhci-omap: Constify struct sdhci_ops
> mmc: sdhci-sprd: Constify struct sdhci_ops
> mmc: sdhci_am654: Constify struct sdhci_ops
> mmc: sdhci-s3c: Choose sdhci_ops based on variant
>
> drivers/mmc/host/sdhci-esdhc-mcf.c | 2 +-
> drivers/mmc/host/sdhci-omap.c | 2 +-
> drivers/mmc/host/sdhci-s3c.c | 31 +++++++++++++++++--------------
> drivers/mmc/host/sdhci-sprd.c | 2 +-
> drivers/mmc/host/sdhci_am654.c | 6 +++---
> 5 files changed, 23 insertions(+), 20 deletions(-)
> ---

Applied for next, thanks!

Kind regards
Uffe