Mailing List Archive: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

[PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

Mar 27, 2024, 10:48 AM

Post #1 of 4 (4 views)

Core in spi_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpu/drm/tiny/ili9225.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c
index dd8b0a181be9..eb1213352bce 100644
--- a/drivers/gpu/drm/tiny/ili9225.c
+++ b/drivers/gpu/drm/tiny/ili9225.c
@@ -447,7 +447,6 @@ static void ili9225_shutdown(struct spi_device *spi)
static struct spi_driver ili9225_spi_driver = {
.driver = {
.name = "ili9225",
- .owner = THIS_MODULE,
.of_match_table = ili9225_of_match,
},
.id_table = ili9225_id,
--
2.34.1

Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment [ In reply to ]

david at lechnology

Mar 27, 2024, 4:14 PM

Post #2 of 4 (4 views)

Permalink

On 3/27/24 12:48 PM, Krzysztof Kozlowski wrote:
> Core in spi_register_driver() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Acked-by: David Lechner <david@lechnology.com>

Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment [ In reply to ]

krzysztof.kozlowski at linaro

Apr 23, 2024, 11:45 PM

Post #3 of 4 (1 views)

Permalink

On 27/03/2024 18:48, Krzysztof Kozlowski wrote:
> Core in spi_register_driver() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/gpu/drm/tiny/ili9225.c | 1 -
> 1 file changed, 1 deletion(-)

It has been almost a month. Any comments on this patchset? Can this be
picked up?

Best regards,
Krzysztof

Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment [ In reply to ]

noralf at tronnes

Apr 26, 2024, 7:08 AM

Post #4 of 4 (1 views)

Permalink

On 4/24/24 08:45, Krzysztof Kozlowski wrote:
> On 27/03/2024 18:48, Krzysztof Kozlowski wrote:
>> Core in spi_register_driver() already sets the .owner, so driver
>> does not need to.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> drivers/gpu/drm/tiny/ili9225.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> It has been almost a month. Any comments on this patchset? Can this be
> picked up?
>

Thanks for cleaning up, patches applied to drm-misc-next.

Noralf.