Mailing List Archive: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings

[PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings

Mar 12, 2017, 6:20 AM

Post #1 of 5 (15 views)

Submitters of device tree binding documentation may forget to CC
the subsystem maintainer if this is missing.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org
---
Please apply this patch directly if you want to be involved in device
tree binding documentation for your subsystem.

v2:
- No changes.

Impact on next-20170310:

+Jason Cooper <jason@lakedaemon.net> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
+Andrew Lunn <andrew@lunn.ch> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
+Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
+Gregory Clement <gregory.clement@free-electrons.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
+linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell Dove/MV78xx0/Orion SOC support)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6428d3c82fce9670..ce461fefec6c9463 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1486,6 +1486,7 @@ M: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
M: Gregory Clement <gregory.clement@free-electrons.com>
L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
S: Maintained
+F: Documentation/devicetree/bindings/soc/dove/
F: arch/arm/mach-dove/
F: arch/arm/mach-mv78xx0/
F: arch/arm/mach-orion5x/
--
2.7.4

Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings [ In reply to ]

jason at lakedaemon

Mar 13, 2017, 6:20 AM

Post #2 of 5 (12 views)

Permalink

Hi Geert,

On Sun, Mar 12, 2017 at 02:16:49PM +0100, Geert Uytterhoeven wrote:
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> Please apply this patch directly if you want to be involved in device
> tree binding documentation for your subsystem.
>
> v2:
> - No changes.
>
> Impact on next-20170310:
>
> +Jason Cooper <jason@lakedaemon.net> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Andrew Lunn <andrew@lunn.ch> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Gregory Clement <gregory.clement@free-electrons.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> +linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@vger.kernel.org (open list)
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6428d3c82fce9670..ce461fefec6c9463 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1486,6 +1486,7 @@ M: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> M: Gregory Clement <gregory.clement@free-electrons.com>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> +F: Documentation/devicetree/bindings/soc/dove/

I'm not opposed to the idea, but I'm not seeing how we can do this
completely. What you've added only covers dove soc bindings. There's
orion5x, kirkwood, and all the newer mvebu socs. Not to mention a lot
of IP blocks we care about that aren't SoC- or Marvell-specific.

The dts files have a much more clear file pattern -> maintainer pairing.
Perhaps we should make checkpatch smarter? e.g. compatible strings
found in changed binding docs are searched for in dts{i} files. Hits
are mapped to maintainers.

thoughts?

thx,

Jason.

Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings [ In reply to ]

geert at linux-m68k

Mar 17, 2017, 6:20 AM

Post #3 of 5 (12 views)

Permalink

Hi Jason,

On Mon, Mar 13, 2017 at 2:01 PM, Jason Cooper <jason@lakedaemon.net> wrote:
> On Sun, Mar 12, 2017 at 02:16:49PM +0100, Geert Uytterhoeven wrote:
>> Submitters of device tree binding documentation may forget to CC
>> the subsystem maintainer if this is missing.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: Jason Cooper <jason@lakedaemon.net>
>> Cc: Andrew Lunn <andrew@lunn.ch>
>> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> Cc: Gregory Clement <gregory.clement@free-electrons.com>
>> Cc: linux-arm-kernel@lists.infradead.org
>> ---
>> Please apply this patch directly if you want to be involved in device
>> tree binding documentation for your subsystem.
>>
>> v2:
>> - No changes.
>>
>> Impact on next-20170310:
>>
>> +Jason Cooper <jason@lakedaemon.net> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> +Andrew Lunn <andrew@lunn.ch> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> +Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> +Gregory Clement <gregory.clement@free-electrons.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>> Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>> +linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell Dove/MV78xx0/Orion SOC support)
>> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>> linux-kernel@vger.kernel.org (open list)
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6428d3c82fce9670..ce461fefec6c9463 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1486,6 +1486,7 @@ M: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> M: Gregory Clement <gregory.clement@free-electrons.com>
>> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>> S: Maintained
>> +F: Documentation/devicetree/bindings/soc/dove/
>
> I'm not opposed to the idea, but I'm not seeing how we can do this
> completely. What you've added only covers dove soc bindings. There's
> orion5x, kirkwood, and all the newer mvebu socs. Not to mention a lot
> of IP blocks we care about that aren't SoC- or Marvell-specific.

There's no orion5x, kirkwood, mvebu, ... under
Documentation/devicetree/bindings/soc.

> The dts files have a much more clear file pattern -> maintainer pairing.
> Perhaps we should make checkpatch smarter? e.g. compatible strings
> found in changed binding docs are searched for in dts{i} files. Hits
> are mapped to maintainers.

The DTS files are maintained by a platform maintainer, while my patch
series was about Linux kernel subsystem maintainers.

In this particular case both maintainers are the same, but this is not true in
general. Hence deriving a platform maintainer from a Linux subsystem specific
binding document is the wrong way around.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings [ In reply to ]

jason at lakedaemon

Mar 17, 2017, 6:20 AM

Post #4 of 5 (12 views)

Permalink

Hi Geert,

On Fri, Mar 17, 2017 at 01:02:26PM +0100, Geert Uytterhoeven wrote:
> In this particular case both maintainers are the same, but this is not true in
> general. Hence deriving a platform maintainer from a Linux subsystem specific
> binding document is the wrong way around.

Ack.

thx,

Jason.

Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings [ In reply to ]

gregory.clement at free-electrons

Mar 23, 2017, 10:20 AM

Post #5 of 5 (10 views)

Permalink

Hi Geert,

On dim., mars 12 2017, Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: linux-arm-kernel@lists.infradead.org

Applied on mvebu/soc

Thanks,

Gregory

> ---
> Please apply this patch directly if you want to be involved in device
> tree binding documentation for your subsystem.
>
> v2:
> - No changes.
>
> Impact on next-20170310:
>
> +Jason Cooper <jason@lakedaemon.net> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Andrew Lunn <andrew@lunn.ch> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> +Gregory Clement <gregory.clement@free-electrons.com> (maintainer:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> +linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell Dove/MV78xx0/Orion SOC support)
> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@vger.kernel.org (open list)
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6428d3c82fce9670..ce461fefec6c9463 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1486,6 +1486,7 @@ M: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> M: Gregory Clement <gregory.clement@free-electrons.com>
> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> +F: Documentation/devicetree/bindings/soc/dove/
> F: arch/arm/mach-dove/
> F: arch/arm/mach-mv78xx0/
> F: arch/arm/mach-orion5x/
> --
> 2.7.4
>

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com