Mailing List Archive: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning

[PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning

Jan 23, 2015, 11:11 AM

Post #1 of 3 (89 views)

This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature
of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
so that 80 character line over warning to be reduced.

Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
index 81fab2d..1de843d 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.c
+++ b/drivers/staging/comedi/drivers/jr3_pci.c
@@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
return 0;
}

-static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
+static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
+ *s)
{
struct jr3_pci_subdev_private *spriv = s->private;
struct jr3_pci_poll_delay result = poll_delay_min_max(1000, 2000);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning [ In reply to ]

gregkh at linuxfoundation

Jan 23, 2015, 6:29 PM

Post #2 of 3 (86 views)

Permalink

On Sat, Jan 24, 2015 at 12:41:20AM +0530, jitendra kumar khasdev wrote:
> This is patch to file jr3_pci.c that fix up warning line
> over 80 character which is found by checkpatch tool. Made change into signature
> of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
> so that 80 character line over warning to be reduced.

The irony of not properly line-wrapping your changelog comment for a
patch that you are fixing up proper line size is huge :)

>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> index 81fab2d..1de843d 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.c
> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> @@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
> return 0;
> }
>
> -static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
> +static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
> + *s)

Be reasonable, this is now looks worse than the code did before, just
leave this as-is, coding style is a guideline, not hard rules.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning [ In reply to ]

abbotti at mev

Jan 26, 2015, 3:20 AM

Post #3 of 3 (82 views)

Permalink

On 23/01/15 19:11, jitendra kumar khasdev wrote:
> This is patch to file jr3_pci.c that fix up warning line
> over 80 character which is found by checkpatch tool. Made change into signature
> of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
> so that 80 character line over warning to be reduced.
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> index 81fab2d..1de843d 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.c
> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> @@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
> return 0;
> }
>
> -static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
> +static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
> + *s)

I think it looks better wrapped like this:

static struct jr3_pci_poll_delay
jr3_pci_poll_subdevice(struct comedi_subdevice *s)

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/