Mailing List Archive: [PATCH] ivtv: Declare MODULE

[PATCH] ivtv: Declare MODULE_FIRMWARE usage

Jul 26, 2012, 11:26 AM

Post #1 of 4 (3191 views)

Cc: Andy Walls <awalls@md.metrocast.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: ivtv-devel@ivtvdriver.org
Cc: linux-media@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
index 02c5ade..6ec7705 100644
--- a/drivers/media/video/ivtv/ivtv-firmware.c
+++ b/drivers/media/video/ivtv/ivtv-firmware.c
@@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where)

return res;
}
+
+MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME);
+MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME);
+MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME);
--
1.7.9.5

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage [ In reply to ]

awalls at md

Jul 26, 2012, 3:21 PM

Post #2 of 4 (3028 views)

Permalink

On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
> Cc: Andy Walls <awalls@md.metrocast.net>
> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> Cc: ivtv-devel@ivtvdriver.org
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
> drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
> index 02c5ade..6ec7705 100644
> --- a/drivers/media/video/ivtv/ivtv-firmware.c
> +++ b/drivers/media/video/ivtv/ivtv-firmware.c
> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where)
>
> return res;
> }
> +
> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME);
> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME);
> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME);

Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the
CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even
in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME
file is non-fatal.)

I would not want anything in user-space or kernel space preventing the
ivtv module from loading, if some of those files don't exist.

Regards,
Andy

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage [ In reply to ]

tim.gardner at canonical

Jul 27, 2012, 8:45 AM

Post #3 of 4 (3034 views)

Permalink

On 07/26/2012 04:21 PM, Andy Walls wrote:
> On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
>> Cc: Andy Walls <awalls@md.metrocast.net>
>> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>> Cc: ivtv-devel@ivtvdriver.org
>> Cc: linux-media@vger.kernel.org
>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>> ---
>> drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
>> index 02c5ade..6ec7705 100644
>> --- a/drivers/media/video/ivtv/ivtv-firmware.c
>> +++ b/drivers/media/video/ivtv/ivtv-firmware.c
>> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where)
>>
>> return res;
>> }
>> +
>> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME);
>> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME);
>> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME);
>
> Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the
> CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even
> in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME
> file is non-fatal.)
>
> I would not want anything in user-space or kernel space preventing the
> ivtv module from loading, if some of those files don't exist.
>
> Regards,
> Andy
>

MODULE_FIRMWARE is informational only and has no runtime impact.

rtg
--
Tim Gardner tim.gardner@canonical.com

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage [ In reply to ]

awalls at md

Jul 28, 2012, 9:52 AM

Post #4 of 4 (3026 views)

Permalink

On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote:
> On 07/26/2012 04:21 PM, Andy Walls wrote:
> > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
> >> Cc: Andy Walls <awalls@md.metrocast.net>
> >> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> >> Cc: ivtv-devel@ivtvdriver.org
> >> Cc: linux-media@vger.kernel.org
> >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> >> ---
> >> drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
> >> index 02c5ade..6ec7705 100644
> >> --- a/drivers/media/video/ivtv/ivtv-firmware.c
> >> +++ b/drivers/media/video/ivtv/ivtv-firmware.c
> >> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where)
> >>
> >> return res;
> >> }
> >> +
> >> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME);
> >> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME);
> >> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME);
> >
> > Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the
> > CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even
> > in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME
> > file is non-fatal.)
> >
> > I would not want anything in user-space or kernel space preventing the
> > ivtv module from loading, if some of those files don't exist.
> >
> > Regards,
> > Andy
> >
>
> MODULE_FIRMWARE is informational only and has no runtime impact.

OK.

Acked-by: Andy Walls <awalls@md.metrocast.net>

Regards,
Andy

>
> rtg

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel