Mailing List Archive: [PATCH 06/21]drivers:media:cx23418.h remove one to many l's in the word.

[PATCH 06/21]drivers:media:cx23418.h remove one to many l's in the word.

Feb 24, 2011, 10:11 PM

Post #1 of 3 (2762 views)

The patch below removes an extra "l" in the word.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
drivers/media/video/cx18/cx23418.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
index 7e40035..935f557 100644
--- a/drivers/media/video/cx18/cx23418.h
+++ b/drivers/media/video/cx18/cx23418.h
@@ -477,7 +477,7 @@
/* The are no buffers ready. Try again soon! */
#define CXERR_NODATA_AGAIN 0x00001E

-/* The stream is stopping. Function not alllowed now! */
+/* The stream is stopping. Function not allowed now! */
#define CXERR_STOPPING_STATUS 0x00001F

/* Trying to access hardware when the power is turned OFF */
--
1.7.4.1

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Re: [PATCH 06/21]drivers:media:cx23418.h remove one to many l's in the word. [ In reply to ]

awalls at md

Feb 25, 2011, 4:51 PM

Post #2 of 3 (2676 views)

Permalink

On Thu, 2011-02-24 at 22:11 -0800, Justin P. Mattock wrote:
> The patch below removes an extra "l" in the word.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
> ---
> drivers/media/video/cx18/cx23418.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
> index 7e40035..935f557 100644
> --- a/drivers/media/video/cx18/cx23418.h
> +++ b/drivers/media/video/cx18/cx23418.h
> @@ -477,7 +477,7 @@
> /* The are no buffers ready. Try again soon! */
> #define CXERR_NODATA_AGAIN 0x00001E
>
> -/* The stream is stopping. Function not alllowed now! */
> +/* The stream is stopping. Function not allowed now! */

If the spelling mistake is worthy of a fix, why isn't the egregious
grammar mistake also worth fixing?

Also, those aren't the only spelling and grammar mistakes in comments in
that file.

-Andy

> #define CXERR_STOPPING_STATUS 0x00001F
>
> /* Trying to access hardware when the power is turned OFF */

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Re: [PATCH 06/21]drivers:media:cx23418.h remove one to many l's in the word. [ In reply to ]

justinmattock at gmail

Feb 25, 2011, 5:23 PM

Post #3 of 3 (2666 views)

Permalink

On 02/25/2011 04:51 PM, Andy Walls wrote:
> On Thu, 2011-02-24 at 22:11 -0800, Justin P. Mattock wrote:
>> The patch below removes an extra "l" in the word.
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> drivers/media/video/cx18/cx23418.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/video/cx18/cx23418.h b/drivers/media/video/cx18/cx23418.h
>> index 7e40035..935f557 100644
>> --- a/drivers/media/video/cx18/cx23418.h
>> +++ b/drivers/media/video/cx18/cx23418.h
>> @@ -477,7 +477,7 @@
>> /* The are no buffers ready. Try again soon! */
>> #define CXERR_NODATA_AGAIN 0x00001E
>>
>> -/* The stream is stopping. Function not alllowed now! */
>> +/* The stream is stopping. Function not allowed now! */
> If the spelling mistake is worthy of a fix, why isn't the egregious
> grammar mistake also worth fixing?
>
> Also, those aren't the only spelling and grammar mistakes in comments in
> that file.
>
> -Andy
>
>> #define CXERR_STOPPING_STATUS 0x00001F
>>
>> /* Trying to access hardware when the power is turned OFF */
>
>
at the time of putting the patch together I was only grepping for
certain things("l")
and not really looking at the rest.. I can resend this..

cheers,

Justin P. Mattock