Mailing List Archive

Re: [PATCH 02/35] ivtv: use kthread_worker instead of workqueue
On Mon, 2010-06-28 at 23:03 +0200, Tejun Heo wrote:
> Upcoming workqueue updates will no longer guarantee fixed workqueue to
> worker kthread association, so giving RT priority to the irq worker
> won't work. Use kthread_worker which guarantees specific kthread
> association instead. This also makes setting the priority cleaner.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Andy Walls <awalls@md.metrocast.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: ivtv-devel@ivtvdriver.org
> Cc: linux-media@vger.kernel.org


Assuming the new kthread_worker implementation is OK, this change for
ivtv looks good.

Reviewed-by: Andy Walls <awalls@md.metrocast.net>
Acked-by: Andy Walls <awalls@md.metrocast.net>

Regards,
Andy

> drivers/media/video/ivtv/ivtv-driver.c | 26 ++++++++++++++++----------
> drivers/media/video/ivtv/ivtv-driver.h | 8 ++++----
> drivers/media/video/ivtv/ivtv-irq.c | 15 +++------------
> drivers/media/video/ivtv/ivtv-irq.h | 2 +-
> 4 files changed, 24 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/media/video/ivtv/ivtv-driver.c b/drivers/media/video/ivtv/ivtv-driver.c
> index 1b79475..49e0b1c 100644
> --- a/drivers/media/video/ivtv/ivtv-driver.c
> +++ b/drivers/media/video/ivtv/ivtv-driver.c



_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
Re: [PATCH 02/35] ivtv: use kthread_worker instead of workqueue [ In reply to ]
On Tue, 2010-07-06 at 09:01 +0200, Tejun Heo wrote:
> On 07/05/2010 07:11 PM, Andy Walls wrote:
> > Assuming the new kthread_worker implementation is OK, this change for
> > ivtv looks good.
> >
> > Reviewed-by: Andy Walls <awalls@md.metrocast.net>
> > Acked-by: Andy Walls <awalls@md.metrocast.net>
>
> May I route this patch through wq branch? As it's not clear how this
> whole patchset will end up, I think it would be better to keep things
> isolated in this branch.

Yes, I think that is the best way to do things.

Regards,
Andy



_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel