Mailing List Archive

[PATCH] ivtv-utils ps-analyzer: Fix and enhance ivtv private packet decoding
Hans,

Since you're going to release a new ivtv-utils soon: could you include
the functionality in the attached patches?

The *patch2 file is just a stripped down and renamed videodev2.h header
file for the ivtv VBI private packet payload definitions. If you're
fixing up the types so videodev2.h can be included without the compile
errors, then this custom header may not be needed.

Thanks.

Regards,
Andy
Re: [PATCH] ivtv-utils ps-analyzer: Fix and enhance ivtv private packet decoding [ In reply to ]
On Friday 15 May 2009 17:48:06 Andy Walls wrote:
> Hans,
>
> Since you're going to release a new ivtv-utils soon: could you include
> the functionality in the attached patches?
>
> The *patch2 file is just a stripped down and renamed videodev2.h header
> file for the ivtv VBI private packet payload definitions. If you're
> fixing up the types so videodev2.h can be included without the compile
> errors, then this custom header may not be needed.

Thanks! I've applied this.

Can you verify that the ivtv-utils trunk is compiling fine?

See http://www.ivtvdriver.org/index.php/Svn_checkout for checkout
instructions.

If all works fine for you, then I'll make a new 1.4.0 release.

Regards,

Hans

--
Hans Verkuil - video4linux developer - sponsored by TANDBERG

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
Re: [PATCH] ivtv-utils ps-analyzer: Fix and enhance ivtv private packet decoding [ In reply to ]
On Thursday 21 May 2009 16:36, Hans Verkuil wrote:
> On Friday 15 May 2009 17:48:06 Andy Walls wrote:
> > Hans,
> >
> > Since you're going to release a new ivtv-utils soon: could you include
> > the functionality in the attached patches?
> >
> > The *patch2 file is just a stripped down and renamed videodev2.h header
> > file for the ivtv VBI private packet payload definitions. If you're
> > fixing up the types so videodev2.h can be included without the compile
> > errors, then this custom header may not be needed.
>
> Thanks! I've applied this.
>
> Can you verify that the ivtv-utils trunk is compiling fine?
>
> See http://www.ivtvdriver.org/index.php/Svn_checkout for checkout
> instructions.
>
> If all works fine for you, then I'll make a new 1.4.0 release.
>
> Regards,
>
> Hans


I just downloaded the svn trunk version, and tried to compile. This is my
unsuccessful result on Linux 2.6.29.2 x86_64:
:

[marc@pcprive ivtv]$ make
make -C utils all
make[1]: Entering directory `/home/marc/dl2/ivtv-trunk/ivtv/utils'
g++ -D_GNU_SOURCE -O2 -Wall -g -I. -c -o v4l2-ctl.o v4l2-ctl.cpp
v4l2-ctl.cpp: In function 'void print_qctrl(int, v4l2_queryctrl*,
v4l2_ext_control*, int)':
v4l2-ctl.cpp:573: warning: format '%lld' expects type 'long long int', but
argument 3 has type '__s64'
v4l2-ctl.cpp: In function 'void printjpegcomp(const v4l2_jpegcompression&)':
v4l2-ctl.cpp:793: warning: format '%08lx' expects type 'long unsigned int',
but argument 2 has type 'unsigned int'
v4l2-ctl.cpp: In function 'void list_devices()':
v4l2-ctl.cpp:1152: warning: suggest parentheses around assignment used as
truth value
v4l2-ctl.cpp: In function 'int main(int, char**)':
v4l2-ctl.cpp:1780: warning: comparison between signed and unsigned integer
expressions
v4l2-ctl.cpp:1790: warning: comparison between signed and unsigned integer
expressions
v4l2-ctl.cpp:1393: warning: 'overlay_fmt_ptr' may be used uninitialized in
this function
v4l2-ctl.cpp:1392: warning: 'set_overlay_fmt_ptr' may be used uninitialized in
this function
v4l2-ctl.cpp: At global scope:
v4l2-ctl.cpp:896: warning: 'char* pts_to_string(char*, long unsigned int)'
defined but not used
g++ -lm -o v4l2-ctl v4l2-ctl.o
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o ivtv-ctl.o ivtv-ctl.c
ivtv-ctl.c: In function 'main':
ivtv-ctl.c:557: error: 'VIDEO_GET_PTS' undeclared (first use in this function)
ivtv-ctl.c:557: error: (Each undeclared identifier is reported only once
ivtv-ctl.c:557: error: for each function it appears in.)
ivtv-ctl.c:558: error: 'VIDEO_GET_FRAME_COUNT' undeclared (first use in this
function)
ivtv-ctl.c:575: warning: format '%04llx' expects type 'long long unsigned
int', but argument 2 has type '__u64'
ivtv-ctl.c:580: warning: format '%04llx' expects type 'long long unsigned
int', but argument 2 has type '__u64'
ivtv-ctl.c:590: warning: format '%04llx' expects type 'long long unsigned
int', but argument 2 has type '__u64'
ivtv-ctl.c:593: warning: format '%04llx' expects type 'long long unsigned
int', but argument 2 has type '__u64'
ivtv-ctl.c:596: warning: format '%04llx' expects type 'long long unsigned
int', but argument 2 has type '__u64'
ivtv-ctl.c:640: error: 'AUDIO_BILINGUAL_CHANNEL_SELECT' undeclared (first use
in this function)
make[1]: *** [ivtv-ctl.o] Error 1
make[1]: Leaving directory `/home/marc/dl2/ivtv-trunk/ivtv/utils'
make: *** [all] Error 2

yours,
Marc

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
Re: [PATCH] ivtv-utils ps-analyzer: Fix and enhance ivtv private packet decoding [ In reply to ]
On Thursday 21 May 2009 22:22:22 Marc Kessels wrote:
> On Thursday 21 May 2009 16:36, Hans Verkuil wrote:
> > On Friday 15 May 2009 17:48:06 Andy Walls wrote:
> > > Hans,
> > >
> > > Since you're going to release a new ivtv-utils soon: could you
> > > include the functionality in the attached patches?
> > >
> > > The *patch2 file is just a stripped down and renamed videodev2.h
> > > header file for the ivtv VBI private packet payload definitions. If
> > > you're fixing up the types so videodev2.h can be included without the
> > > compile errors, then this custom header may not be needed.
> >
> > Thanks! I've applied this.
> >
> > Can you verify that the ivtv-utils trunk is compiling fine?
> >
> > See http://www.ivtvdriver.org/index.php/Svn_checkout for checkout
> > instructions.
> >
> > If all works fine for you, then I'll make a new 1.4.0 release.
> >
> > Regards,
> >
> > Hans
>
> I just downloaded the svn trunk version, and tried to compile. This is my
> unsuccessful result on Linux 2.6.29.2 x86_64:
>
>
> [marc@pcprive ivtv]$ make
> make -C utils all
> make[1]: Entering directory `/home/marc/dl2/ivtv-trunk/ivtv/utils'
> g++ -D_GNU_SOURCE -O2 -Wall -g -I. -c -o v4l2-ctl.o v4l2-ctl.cpp
> v4l2-ctl.cpp: In function 'void print_qctrl(int, v4l2_queryctrl*,
> v4l2_ext_control*, int)':
> v4l2-ctl.cpp:573: warning: format '%lld' expects type 'long long int',
> but argument 3 has type '__s64'
> v4l2-ctl.cpp: In function 'void printjpegcomp(const
> v4l2_jpegcompression&)': v4l2-ctl.cpp:793: warning: format '%08lx'
> expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> v4l2-ctl.cpp: In function 'void list_devices()':
> v4l2-ctl.cpp:1152: warning: suggest parentheses around assignment used as
> truth value
> v4l2-ctl.cpp: In function 'int main(int, char**)':
> v4l2-ctl.cpp:1780: warning: comparison between signed and unsigned
> integer expressions
> v4l2-ctl.cpp:1790: warning: comparison between signed and unsigned
> integer expressions
> v4l2-ctl.cpp:1393: warning: 'overlay_fmt_ptr' may be used uninitialized
> in this function
> v4l2-ctl.cpp:1392: warning: 'set_overlay_fmt_ptr' may be used
> uninitialized in this function
> v4l2-ctl.cpp: At global scope:
> v4l2-ctl.cpp:896: warning: 'char* pts_to_string(char*, long unsigned
> int)' defined but not used
> g++ -lm -o v4l2-ctl v4l2-ctl.o
> cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o ivtv-ctl.o ivtv-ctl.c
> ivtv-ctl.c: In function 'main':
> ivtv-ctl.c:557: error: 'VIDEO_GET_PTS' undeclared (first use in this
> function) ivtv-ctl.c:557: error: (Each undeclared identifier is reported
> only once ivtv-ctl.c:557: error: for each function it appears in.)
> ivtv-ctl.c:558: error: 'VIDEO_GET_FRAME_COUNT' undeclared (first use in
> this function)

What on earth is in your /usr/include/linux/dvb/video.h header? It should be
defined there.

Anyway, I've added copies of the audio.h and video.h headers as well in
ivtv-utils. Can you get the latest ivtv trunk and try again?

Regards,

Hans

> ivtv-ctl.c:575: warning: format '%04llx' expects type 'long long unsigned
> int', but argument 2 has type '__u64'
> ivtv-ctl.c:580: warning: format '%04llx' expects type 'long long unsigned
> int', but argument 2 has type '__u64'
> ivtv-ctl.c:590: warning: format '%04llx' expects type 'long long unsigned
> int', but argument 2 has type '__u64'
> ivtv-ctl.c:593: warning: format '%04llx' expects type 'long long unsigned
> int', but argument 2 has type '__u64'
> ivtv-ctl.c:596: warning: format '%04llx' expects type 'long long unsigned
> int', but argument 2 has type '__u64'
> ivtv-ctl.c:640: error: 'AUDIO_BILINGUAL_CHANNEL_SELECT' undeclared (first
> use in this function)
> make[1]: *** [ivtv-ctl.o] Error 1
> make[1]: Leaving directory `/home/marc/dl2/ivtv-trunk/ivtv/utils'
> make: *** [all] Error 2
>
> yours,
> Marc
>
> _______________________________________________
> ivtv-devel mailing list
> ivtv-devel@ivtvdriver.org
> http://ivtvdriver.org/mailman/listinfo/ivtv-devel



--
Hans Verkuil - video4linux developer - sponsored by TANDBERG

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
Re: [PATCH] ivtv-utils ps-analyzer: Fix and enhance ivtv private packet decoding [ In reply to ]
On Fri, 2009-05-22 at 14:09 +0200, Hans Verkuil wrote:

> > > Can you verify that the ivtv-utils trunk is compiling fine?
> > >
> > > See http://www.ivtvdriver.org/index.php/Svn_checkout for checkout
> > > instructions.
> > >
> > > If all works fine for you, then I'll make a new 1.4.0 release.
> > >
> > > Regards,
> > >
> > > Hans


> Anyway, I've added copies of the audio.h and video.h headers as well in
> ivtv-utils. Can you get the latest ivtv trunk and try again?
>
> Regards,
>
> Hans


Hans,

Things compile for me on my Fedora 10 x86_64 system with a few warnings
- see below. On the whole, things look OK to me.

Regards,
Andy

make -C utils all
make[1]: Entering directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/utils'
g++ -D_GNU_SOURCE -O2 -Wall -g -I. -c -o v4l2-ctl.o v4l2-ctl.cpp
v4l2-ctl.cpp: In function ‘void printjpegcomp(const v4l2_jpegcompression&)’:
v4l2-ctl.cpp:793: warning: format ‘%08lx’ expects type ‘long unsigned int’, but argument 2 has type ‘unsigned int’
v4l2-ctl.cpp: In function ‘void list_devices()’:
v4l2-ctl.cpp:1152: warning: suggest parentheses around assignment used as truth value
v4l2-ctl.cpp: In function ‘int main(int, char**)’:
v4l2-ctl.cpp:1780: warning: comparison between signed and unsigned integer expressions
v4l2-ctl.cpp:1790: warning: comparison between signed and unsigned integer expressions
v4l2-ctl.cpp:1393: warning: ‘overlay_fmt_ptr’ may be used uninitialized in this function
v4l2-ctl.cpp:1392: warning: ‘set_overlay_fmt_ptr’ may be used uninitialized in this function
v4l2-ctl.cpp: At global scope:
v4l2-ctl.cpp:896: warning: ‘char* pts_to_string(char*, long unsigned int)’ defined but not used
g++ -lm -o v4l2-ctl v4l2-ctl.o
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o ivtv-ctl.o ivtv-ctl.c
cc -lm -o ivtv-ctl ivtv-ctl.o
cc -D_GNU_SOURCE -O2 -Wall -g -I. ivtv-radio.c -o ivtv-radio
g++ -D_GNU_SOURCE -O2 -Wall -g -I. -lm -lpthread -o ivtvplay ivtvplay.cc
cc -D_GNU_SOURCE -O2 -Wall -g -I. ivtv-mpegindex.c -o ivtv-mpegindex
make CFLAGS="-D_GNU_SOURCE -O2 -Wall -g -I." -C ivtv-tune
make[2]: Entering directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/utils/ivtv-tune'
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o ivtv-tune.o ivtv-tune.c
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o frequencies.o frequencies.c
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o xawtv_parseconfig.o xawtv_parseconfig.c
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o cmdline.o cmdline.c
cc ivtv-tune.o frequencies.o xawtv_parseconfig.o cmdline.o -o ivtv-tune
make[2]: Leaving directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/utils/ivtv-tune'
make CFLAGS="-D_GNU_SOURCE -O2 -Wall -g -I." -C cx25840ctl
make[2]: Entering directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/utils/cx25840ctl'
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o cx25840ctl.o cx25840ctl.c
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o cx25840-registers.o cx25840-registers.c
cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o cmdline.o cmdline.c
cc cx25840ctl.o cx25840-registers.o cmdline.o -o cx25840ctl
make[2]: Leaving directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/utils/cx25840ctl'
make[1]: Leaving directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/utils'
make -C test all
make[1]: Entering directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/test'
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm vbi.c -o vbi
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm wss.c -o wss
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm vbi-passthrough.c -o vbi-passthrough
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm vbi-detect.c -o vbi-detect
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm ivtv-pcm-tester.c -o ivtv-pcm-tester
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm mpeg-read-test.c -o mpeg-read-test
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm mpeg-freq-test.c -o mpeg-freq-test
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm mpeg-read-sleep-test.c -o mpeg-read-sleep-test
mpeg-read-sleep-test.c: In function ‘main’:
mpeg-read-sleep-test.c:48: warning: format ‘%u’ expects type ‘unsigned int’, but argument 4 has type ‘long unsigned int’
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm mpeg-enc-stop-start-test.c -o mpeg-enc-stop-start-test
mpeg-enc-stop-start-test.c: In function ‘main’:
mpeg-enc-stop-start-test.c:51: warning: format ‘%u’ expects type ‘unsigned int’, but argument 4 has type ‘long unsigned int’
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm ivtv-yuv-dma-test.c -o ivtv-yuv-dma-test
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm ivtv-osd-dma-test.c -o ivtv-osd-dma-test
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm ivtv-fb-colormap-test.c -o ivtv-fb-colormap-test
cc -I../utils -D_GNU_SOURCE -O2 -Wall -lm ivtv-fb-16-bit-test.c -o ivtv-fb-16-bit-test
g++ -I../utils -D_GNU_SOURCE -O2 -Wall -lm ps-analyzer.cpp -o ps-analyzer
make[1]: Leaving directory `/home/andy/hw/pvr150mce/ivtv-svn/ivtv/test'





_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel
Re: [PATCH] ivtv-utils ps-analyzer: Fix and enhance ivtv private packet decoding [ In reply to ]
On Friday 22 May 2009 14:09, Hans Verkuil wrote:
> On Thursday 21 May 2009 22:22:22 Marc Kessels wrote:
> > On Thursday 21 May 2009 16:36, Hans Verkuil wrote:
> > > On Friday 15 May 2009 17:48:06 Andy Walls wrote:
> > > > Hans,
> > > >
> > > > Since you're going to release a new ivtv-utils soon: could you
> > > > include the functionality in the attached patches?
> > > >
> > > > The *patch2 file is just a stripped down and renamed videodev2.h
> > > > header file for the ivtv VBI private packet payload definitions. If
> > > > you're fixing up the types so videodev2.h can be included without the
> > > > compile errors, then this custom header may not be needed.
> > >
> > > Thanks! I've applied this.
> > >
> > > Can you verify that the ivtv-utils trunk is compiling fine?
> > >
> > > See http://www.ivtvdriver.org/index.php/Svn_checkout for checkout
> > > instructions.
> > >
> > > If all works fine for you, then I'll make a new 1.4.0 release.
> > >
> > > Regards,
> > >
> > > Hans
> >
> > I just downloaded the svn trunk version, and tried to compile. This is my
> > unsuccessful result on Linux 2.6.29.2 x86_64:
> >
> >
> > [marc@pcprive ivtv]$ make
> > make -C utils all
> > make[1]: Entering directory `/home/marc/dl2/ivtv-trunk/ivtv/utils'
> > g++ -D_GNU_SOURCE -O2 -Wall -g -I. -c -o v4l2-ctl.o v4l2-ctl.cpp
> > v4l2-ctl.cpp: In function 'void print_qctrl(int, v4l2_queryctrl*,
> > v4l2_ext_control*, int)':
> > v4l2-ctl.cpp:573: warning: format '%lld' expects type 'long long int',
> > but argument 3 has type '__s64'
> > v4l2-ctl.cpp: In function 'void printjpegcomp(const
> > v4l2_jpegcompression&)': v4l2-ctl.cpp:793: warning: format '%08lx'
> > expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> > v4l2-ctl.cpp: In function 'void list_devices()':
> > v4l2-ctl.cpp:1152: warning: suggest parentheses around assignment used as
> > truth value
> > v4l2-ctl.cpp: In function 'int main(int, char**)':
> > v4l2-ctl.cpp:1780: warning: comparison between signed and unsigned
> > integer expressions
> > v4l2-ctl.cpp:1790: warning: comparison between signed and unsigned
> > integer expressions
> > v4l2-ctl.cpp:1393: warning: 'overlay_fmt_ptr' may be used uninitialized
> > in this function
> > v4l2-ctl.cpp:1392: warning: 'set_overlay_fmt_ptr' may be used
> > uninitialized in this function
> > v4l2-ctl.cpp: At global scope:
> > v4l2-ctl.cpp:896: warning: 'char* pts_to_string(char*, long unsigned
> > int)' defined but not used
> > g++ -lm -o v4l2-ctl v4l2-ctl.o
> > cc -D_GNU_SOURCE -O2 -Wall -g -I. -c -o ivtv-ctl.o ivtv-ctl.c
> > ivtv-ctl.c: In function 'main':
> > ivtv-ctl.c:557: error: 'VIDEO_GET_PTS' undeclared (first use in this
> > function) ivtv-ctl.c:557: error: (Each undeclared identifier is reported
> > only once ivtv-ctl.c:557: error: for each function it appears in.)
> > ivtv-ctl.c:558: error: 'VIDEO_GET_FRAME_COUNT' undeclared (first use in
> > this function)
>
> What on earth is in your /usr/include/linux/dvb/video.h header? It should
> be defined there.
>
> Anyway, I've added copies of the audio.h and video.h headers as well in
> ivtv-utils. Can you get the latest ivtv trunk and try again?
>
> Regards,
>
> Hans
>
> > ivtv-ctl.c:575: warning: format '%04llx' expects type 'long long unsigned
> > int', but argument 2 has type '__u64'
> > ivtv-ctl.c:580: warning: format '%04llx' expects type 'long long unsigned
> > int', but argument 2 has type '__u64'
> > ivtv-ctl.c:590: warning: format '%04llx' expects type 'long long unsigned
> > int', but argument 2 has type '__u64'
> > ivtv-ctl.c:593: warning: format '%04llx' expects type 'long long unsigned
> > int', but argument 2 has type '__u64'
> > ivtv-ctl.c:596: warning: format '%04llx' expects type 'long long unsigned
> > int', but argument 2 has type '__u64'
> > ivtv-ctl.c:640: error: 'AUDIO_BILINGUAL_CHANNEL_SELECT' undeclared (first
> > use in this function)
> > make[1]: *** [ivtv-ctl.o] Error 1
> > make[1]: Leaving directory `/home/marc/dl2/ivtv-trunk/ivtv/utils'
> > make: *** [all] Error 2
> >
> > yours,
> > Marc
> >
> > _______________________________________________
> > ivtv-devel mailing list
> > ivtv-devel@ivtvdriver.org
> > http://ivtvdriver.org/mailman/listinfo/ivtv-devel


thanks for pointing this out. It appeared that I had still some old linux
headers in /usr/include/linux... After fixing that, it works like a charm!

thanks,
Marc

_______________________________________________
ivtv-devel mailing list
ivtv-devel@ivtvdriver.org
http://ivtvdriver.org/mailman/listinfo/ivtv-devel