Mailing List Archive: RTSP support for 2.6.23

RTSP support for 2.6.23

Aug 5, 2007, 1:38 AM

Post #1 of 3 (2205 views)

Good morning,

I did a quick check to see if the RTSP module still compiles with the
upcoming 2.6.23.
But as I thought there were some changes needed.
I had no problem with the renamed functions nf_conntrack_... ->
nf_ct_... but there was one other change I was not able to solve.
The rtsp code uses the following code in certain places.

struct nf_conntrack_expect
exp->mask.dst.u.udp.port

nf_conntrack_helper
hlpr->mask.src.u.tcp.port
hlpr->mask.dst.protonum

The new structs have no mask members and I am not sure how I can
achieve the same results with the new code. I looked at several other
modules but could not figure out how to do it correctly.
Maybe someone can give me a hint on how to fix this.

Kind regards,
Michael

Re: RTSP support for 2.6.23 [ In reply to ]

mike at it-loops

Aug 5, 2007, 1:50 AM

Post #2 of 3 (2110 views)

Permalink

On Aug 5, 2007, at 10:38, Michael Guntsche wrote:

> struct nf_conntrack_expect
> exp->mask.dst.u.udp.port
>
> nf_conntrack_helper
> hlpr->mask.src.u.tcp.port
> hlpr->mask.dst.protonum
>
> The new structs have no mask members and I am not sure how I can
> achieve the same results with the new code.

Of course this should read nf_conntrack_expect has not "dst" member
and nf_conntrack_helper has no "mask" member.

/Michael

Re: RTSP support for 2.6.23 [ In reply to ]

mike at it-loops

Aug 5, 2007, 9:38 AM

Post #3 of 3 (2110 views)

Permalink

On Aug 5, 2007, at 10:50, Michael Guntsche wrote:

>
> On Aug 5, 2007, at 10:38, Michael Guntsche wrote:
>
>> struct nf_conntrack_expect
>> exp->mask.dst.u.udp.port
>>
>> nf_conntrack_helper
>> hlpr->mask.src.u.tcp.port
>> hlpr->mask.dst.protonum
>>
>> The new structs have no mask members and I am not sure how I can
>> achieve the same results with the new code.
>

Ok, I got it working now, but I am not sure if this is completely
correct.
During the setup of the help struct I removed hlpr-
>mask.src.u.tcp.port and hlpr->mask.dst.protonum and added hlpr-
>tuple.src.l3num. After this change everything started to work
again, I am just not sure if this solution is correct.
Maybe someone can give me a quick ACK or NACK :)

Kind regards,
Michael