Mailing List Archive

[PATCH][CTNETLINK] return EEXIST instead of EINVAL for existing nat'ed conntracks
ctnetlink must return EEXIST for existing nat'ed conntracks instead of
EINVAL. Only return EINVAL if we try to update a conntrack with NAT
handlings (that is not allowed).

Decadence:libnetfilter_conntrack/utils# ./conntrack_create_nat
TEST: create conntrack (0)(Success)
Decadence:libnetfilter_conntrack/utils# ./conntrack_create_nat
TEST: create conntrack (-1)(Invalid argument)

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

--
"Será preciso viajar a través de los ojos de los idiotas" -- Poeta en
Nueva York -- Federico García Lorca.
Re: [PATCH][CTNETLINK] return EEXIST instead of EINVAL for existing nat'ed conntracks [ In reply to ]
Pablo Neira Ayuso wrote:
> ctnetlink must return EEXIST for existing nat'ed conntracks instead of
> EINVAL. Only return EINVAL if we try to update a conntrack with NAT
> handlings (that is not allowed).


Applied, thanks Pablo.