Mailing List Archive

Serious bug in ip6_tables
Mr. Harald,

Here is a patch to fix a _major_ bug in ip6_tables where if you
compile ip6_tables.o statically, but compile everything else as modules,
you can't get the module dependencies to work. It took me a while to figure
this out, since I was blaming it on ip6_conntrack, but below is a patch to
fix it.
Please include.

Thanks,

Brad

<snip>

--- linux/net/ipv6/netfilter/ip6_tables.c Mon Jul 30 19:14:52 2001
+++ linux/net/ipv6/netfilter/ip6_tables.c Mon Jul 30 19:14:27 2001
@@ -1791,5 +1791,13 @@
#endif
}

+EXPORT_SYMBOL(ip6t_register_table);
+EXPORT_SYMBOL(ip6t_unregister_table);
+EXPORT_SYMBOL(ip6t_do_table);
+EXPORT_SYMBOL(ip6t_register_match);
+EXPORT_SYMBOL(ip6t_unregister_match);
+EXPORT_SYMBOL(ip6t_register_target);
+EXPORT_SYMBOL(ip6t_unregister_target);
+
module_init(init);
module_exit(fini);
--- linux/net/ipv6/netfilter/Makefile Mon Jul 30 19:39:30 2001
+++ linux/net/ipv6/netfilter/Makefile Mon Jul 30 19:39:21 2001
@@ -9,7 +9,7 @@

O_TARGET := netfilter.o

-export-objs =
+export-objs = ip6_tables.o

# Link order matters here.
obj-$(CONFIG_IP6_NF_IPTABLES) += ip6_tables.o
<snip>
Re: Serious bug in ip6_tables [ In reply to ]
On Mon, Jul 30, 2001 at 08:03:32PM -0400, Brad Chapman wrote:
> Mr. Harald,
>
> Here is a patch to fix a _major_ bug in ip6_tables where if you
> compile ip6_tables.o statically, but compile everything else as modules,
> you can't get the module dependencies to work. It took me a while to figure
> this out, since I was blaming it on ip6_conntrack, but below is a patch to
> fix it.
> Please include.

Thanks for this bugfix, Brad.

I'll submit it for kernel inclusion.

> Thanks,
> Brad

--
Live long and prosper
- Harald Welte / laforge@gnumonks.org http://www.gnumonks.org
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M-
V-- PS+ PE-- Y+ PGP++ t++ 5-- !X !R tv-- b+++ DI? !D G+ e* h+ r% y+(*)