Mailing List Archive

commit 347feb7015798aae8f28a883a732a1cc8c120076
Author: Jon Jensen <jon@endpoint.com>
Date: Wed Nov 1 19:04:40 2017 -0600

Explicitly set $@ for cases where set_field() doesn't set $@

lib/Vend/Search.pm | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/lib/Vend/Search.pm b/lib/Vend/Search.pm
index 2350513..6689aef 100644
--- a/lib/Vend/Search.pm
+++ b/lib/Vend/Search.pm
@@ -1,6 +1,6 @@
# Vend::Search - Base class for search engines
#
-# Copyright (C) 2002-2008 Interchange Development Group
+# Copyright (C) 2002-2017 Interchange Development Group
# Copyright (C) 1996-2002 Red Hat, Inc.
#
# This program is free software; you can redistribute it and/or modify
@@ -20,7 +20,7 @@

package Vend::Search;

-$VERSION = substr(q$Revision: 2.38 $, 10);
+$VERSION = '2.39';

use strict;
no warnings qw(uninitialized numeric);
@@ -1242,7 +1242,10 @@ sub save_more {
#::logDebug("save_more: $id to Session DB.");
#::logDebug("save_more:object:" . ::uneval($new));
my $db = Vend::Util::dbref($Vend::Cfg->{SessionDB});
- $db->set_field($id, 'session', Vend::Util::uneval_fast($new));
+ my $key = $db->set_field($id, 'session', Vend::Util::uneval_fast($new));
+ # explicitly set $@ for check below because some exits from set_field()
+ # never set $@, and it's safer in general not to rely its internals
+ $@ = defined($key) ? undef : 1;
}
else {
#::logDebug("save_more: $id to $file.");

_______________________________________________
interchange-cvs mailing list
interchange-cvs@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-cvs