Mailing List Archive

commit a9db3e3e5f6671c64c9117774c41b75b1524023b
Author: Peter Ajamian <peter@pajamian.dhs.org>
Date: Fri Feb 10 13:54:45 2017 +1300

Fixed a bug in the [area] tag when a full URL is passed as the href.

When a fully-qualified URL is passed in the href attribute of the [area] tag and
the form attribute is also used Interchange would overwrite the
protocol://domain portion of the URL with the one in the VendURL configuration
directive.

Please note that if your code relied on this buggy behaviour then you will need
to fix it before upgrading.

UPGRADE | 12 ++++++++++++
lib/Vend/Interpolate.pm | 2 +-
2 files changed, 13 insertions(+), 1 deletions(-)
---
diff --git a/UPGRADE b/UPGRADE
index e563edf..005f255 100644
--- a/UPGRADE
+++ b/UPGRADE
@@ -7,6 +7,10 @@ Interchange is designed to be drop-in compatible in its major version.
Briefly summarized, here's what you can expect when upgrading from the
following versions:

+ 5.10.x -- A minor bug was fixed in an edge-case usage of the [area] tag which
+ could result in incompatibility if your code relies on the buggy
+ behaviour.
+
5.6.x -- Perl 5.8.8 or newer is now generally required to run Interchange.
See "Known Issues" below.

@@ -83,6 +87,14 @@ That's it. Verify your catalog's operation, and you are live.
K N O W N I S S U E S


+KNOWN ISSUES UPGRADING FROM 5.10.x
+
+1. A bug was fixed in the [area] tag where if you previously passed a fully
+qualified URL as the href and used the form attribute then the protocol://domain
+portion of the URL would get overwritten by the one in VendUrl. If you're code
+relies on this buggy behaviour you need to fix it.
+
+
KNOWN ISSUES UPGRADING FROM 5.6.x

1. Perl 5.8.5 (unthreaded) or Perl 5.8.8 (threaded) or newer is now required.
diff --git a/lib/Vend/Interpolate.pm b/lib/Vend/Interpolate.pm
index c75ea20..9e36da1 100644
--- a/lib/Vend/Interpolate.pm
+++ b/lib/Vend/Interpolate.pm
@@ -2764,7 +2764,7 @@ sub tag_area {

$urlroutine = $opt->{secure} ? \&secure_vendUrl : \&vendUrl;

- return $urlroutine->($page, $arg, undef, $opt);
+ return $urlroutine->($page, $arg, $r, $opt);
}

}

_______________________________________________
interchange-cvs mailing list
interchange-cvs@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-cvs