Mailing List Archive: My patches

Hi,

I didn't get any comment about my patches.

I can understand that you reject patches "remove REGISTER_DEFAULT_DIGESTS"
and "REGISTER_DEFAULT_PUBKEYS", since it change function behaviour. New
behaviour: _gcry_md_init()/_gcry_pk_init() have to be called (eg. call
global_init()) before calling any function of md.c / pubkey.c

Patch "fix gcc warning about gcry_thread_cbs in gcrypt.h" just remove a
gcc warning. I need it to compile my project with "-Werror" :-)

Patch "fix ath_mutex_destroy" don't really change function behaviour, it
just simplify the code (don't create a mutex if it doesn't exist).

--

For the copyright:
Victor Stinner <victor.stinner AT inl.fr>

Is it enough?

Victor Stinner

_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel

At Wed, 12 Jul 2006 18:04:09 +0200 (CEST),
haypo@inl.fr wrote:
> I didn't get any comment about my patches.

It has only been a week. I looked over them briefly at the day they
arrived, but they were all low priority so I postponed to process them
as a batch. It's good to know that you are done with this batch and
are stalled waiting for an answer, so here it is ;)

> I can understand that you reject patches "remove REGISTER_DEFAULT_DIGESTS"
> and "REGISTER_DEFAULT_PUBKEYS", since it change function behaviour. New
> behaviour: _gcry_md_init()/_gcry_pk_init() have to be called (eg. call
> global_init()) before calling any function of md.c / pubkey.c

Silence is not rejection. In particular, Werner said that we may
follow your suggestion, but as it would be an ABI break, this requires
more changes beyond the ones you sent in, and needs to be coordinated
with the release schedule. In particular, these two patches I want to
defer to Moritz.

> Patch "fix gcc warning about gcry_thread_cbs in gcrypt.h" just remove a
> gcc warning. I need it to compile my project with "-Werror" :-)
>
> Patch "fix ath_mutex_destroy" don't really change function behaviour, it
> just simplify the code (don't create a mutex if it doesn't exist).

I put in those two now.

Thanks,
Marcus

_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel