Mailing List Archive: Re: libgcrypt/tests/Makefile.am patch

Re: libgcrypt/tests/Makefile.am patch

Jul 29, 2004, 3:56 AM

Post #1 of 3 (892 views)

At Tue, 27 Jul 2004 23:00:07 -0500 (CDT), Bob Friesenhahn wrote:

[.I'm redirecting this thread to gcrypt-devel@, which seems to be more
appropriate to me]

Hello,

> Libgcrypt does not completely build under Solaris due to a missing
> Makefile.am library dependency.

I wonder wether this is the correct patch; after all, Libtool
libraries (*.la) should keep track of such library dependencies
themselves.

src/Makefile.am contains:

libgcrypt_la_DEPENDENCIES = ../cipher/libcipher.la ../mpi/libmpi.la \
$(srcdir)/libgcrypt.vers

Therefore, linking against libgcrypt.la should imply linking against
libcipher.la and libmpi.la. When speaking of libmpi.la: I also wonder
why, assuming that your dependencies are broken, you don't have to add
libmpi.la to the LDADD line as well.

Thanks,
Moritz

Re: libgcrypt/tests/Makefile.am patch [ In reply to ]

bfriesen at simple

Jul 29, 2004, 9:49 AM

Post #2 of 3 (857 views)

Permalink

You are right there is indeed another problem. There is an incorrect
assuption that libgcrypt_la_DEPENDENCIES has something to do with
libtool and library dependencies when in fact it does not.

Perhaps libgcrypt_la_LDADD should be used instead?

Bob

On Thu, 29 Jul 2004, Moritz Schulte wrote:

> At Tue, 27 Jul 2004 23:00:07 -0500 (CDT), Bob Friesenhahn wrote:
>
> [.I'm redirecting this thread to gcrypt-devel@, which seems to be more
> appropriate to me]
>
> Hello,
>
>> Libgcrypt does not completely build under Solaris due to a missing
>> Makefile.am library dependency.
>
> I wonder wether this is the correct patch; after all, Libtool
> libraries (*.la) should keep track of such library dependencies
> themselves.
>
> src/Makefile.am contains:
>
> libgcrypt_la_DEPENDENCIES = ../cipher/libcipher.la ../mpi/libmpi.la \
> $(srcdir)/libgcrypt.vers
>
> Therefore, linking against libgcrypt.la should imply linking against
> libcipher.la and libmpi.la. When speaking of libmpi.la: I also wonder
> why, assuming that your dependencies are broken, you don't have to add
> libmpi.la to the LDADD line as well.
>
> Thanks,
> Moritz
>

======================================
Bob Friesenhahn
bfriesen@simple.dallas.tx.us
http://www.simplesystems.org/users/bfriesen

Re: libgcrypt/tests/Makefile.am patch [ In reply to ]

marcus.brinkmann at ruhr-uni-bochum

Aug 2, 2004, 3:06 AM

Post #3 of 3 (862 views)

Permalink

At Thu, 29 Jul 2004 11:49:42 -0500 (CDT),
Bob Friesenhahn wrote:
>
> You are right there is indeed another problem. There is an incorrect
> assuption that libgcrypt_la_DEPENDENCIES has something to do with
> libtool and library dependencies when in fact it does not.
>
> Perhaps libgcrypt_la_LDADD should be used instead?

But we are using _LIBADD.

Marcus