Mailing List Archive: [PATCH libgcrypt] configure: fix minor typo in warning message

[PATCH libgcrypt] configure: fix minor typo in warning message

Jul 13, 2023, 8:42 AM

Post #1 of 5 (222 views)

Signed-off-by: Bernhard Reiter <bernhard@intevation.de>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 8ddba0e8..e00c0445 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3811,7 +3811,7 @@ fi

if test "$gcry_cv_gcc_attribute_aligned" != "yes" ; then
cat <<G10EOF
- Please not that your compiler does not support the GCC style
+ Please note that your compiler does not support the GCC style
aligned attribute. Using this software may evoke bus errors.

G10EOF
--
2.30.2

Re: [PATCH libgcrypt] configure: fix minor typo in warning message [ In reply to ]

gniibe at fsij

Jul 13, 2023, 7:21 PM

Post #2 of 5 (222 views)

Permalink

Bernhard Reiter <bernhard@intevation.de> wrote:
> @@ -3811,7 +3811,7 @@ fi
>
> if test "$gcry_cv_gcc_attribute_aligned" != "yes" ; then
> cat <<G10EOF
> - Please not that your compiler does not support the GCC style
> + Please note that your compiler does not support the GCC style
> aligned attribute. Using this software may evoke bus errors.
>
> G10EOF

Thank you. Applied to master and 1.10 branch.

BTW, with Clang 16, it works well (no alignment issue) for me.
I wonder if it's newer Clang.
--

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel

Re: [PATCH libgcrypt] configure: fix minor typo in warning message [ In reply to ]

bernhard at intevation

Jul 14, 2023, 12:18 AM

Post #3 of 5 (218 views)

Permalink

Am Freitag 14 Juli 2023 04:21:19 schrieb NIIBE Yutaka:
> Applied to master and 1.10 branch.

Thanks!

> BTW, with Clang 16, it works well (no alignment issue) for me.
> I wonder if it's newer Clang.

It was a discussion of gnupg-devel, where somebody saw this warning.
Is this a spurious warning, if it works?
--
https://intevation.de/~bernhard ? +49 541 33 508 3-3
Intevation GmbH, Osnabr?ck, DE; Amtsgericht Osnabr?ck, HRB 18998
Gesch?ftsf?hrer Frank Koormann, Bernhard Reiter

Re: [PATCH libgcrypt] configure: fix minor typo in warning message [ In reply to ]

gnupg-devel at gnupg

Jul 14, 2023, 7:38 PM

Post #4 of 5 (214 views)

Permalink

Bernhard Reiter wrote:
> Am Freitag 14 Juli 2023 04:21:19 schrieb NIIBE Yutaka:
>
> [...]
>> BTW, with Clang 16, it works well (no alignment issue) for me.
>> I wonder if it's newer Clang.
>>
>
> It was a discussion of gnupg-devel, where somebody saw this warning.
> Is this a spurious warning, if it works?

The problem is that the most common architectures right now (x86) do not
enforce alignment, although they do perform better with aligned data.
If that issue is not policed, code could slip in that will work until
someone builds on a less-common RISC architecture that /does/ enforce
alignment, then they get a program that crashes with SIGBUS.

In short, it is a portability issue.

-- Jacob

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel

Re: [PATCH libgcrypt] configure: fix minor typo in warning message [ In reply to ]

bernhard at intevation

Jul 19, 2023, 7:56 AM

Post #5 of 5 (210 views)

Permalink

Am Samstag 15 Juli 2023 04:38:07 schrieb Jacob Bachmeyer via Gnupg-devel:
> code could slip in that will work until
> someone builds on a less-common RISC architecture that /does/ enforce
> alignment, then they get a program that crashes with SIGBUS.

But shouldn't a configure test during build time on on of these platforms
find out, if there is a problem? And only warn if it is.

--
https://intevation.de/~bernhard ? +49 541 33 508 3-3
Intevation GmbH, Osnabr?ck, DE; Amtsgericht Osnabr?ck, HRB 18998
Gesch?ftsf?hrer Frank Koormann, Bernhard Reiter

Mailing List Archive

Attached Files:

Attached Files:

Attached Files: