Mailing List Archive: [PATCH scute] Add configure enable argument to build tests

[PATCH scute] Add configure enable argument to build tests

Jun 29, 2023, 2:41 PM

Post #1 of 6 (257 views)

* configure.ac:
- remove always-true RUN_TESTS
- add enable argument 'tests' (default = yes)
- set conditional BUILD_TESTS
* Makefile.am:
- rename RUN_TESTS to BUILD_TESTS

Signed-off-by: Jernej Jakob <jernej.jakob@gmail.com>
---
Makefile.am | 2 +-
configure.ac | 14 ++++++++------
2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index a20f1bc..58a6641 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -26,7 +26,7 @@ AUTOMAKE_OPTIONS = dist-bzip2 no-dist-gzip

EXTRA_DIST = autogen.sh README.GIT VERSION

-if RUN_TESTS
+if BUILD_TESTS
tests = tests
else
tests =
diff --git a/configure.ac b/configure.ac
index c3d58cf..a4754c5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -202,7 +202,14 @@ AC_ARG_ENABLE([doc], AS_HELP_STRING([--disable-doc],
build_doc=$enableval, build_doc=yes)
AM_CONDITIONAL([BUILD_DOC], [test "x$build_doc" != xno && test "x$have_doc_tools" = xyes])

-
+#
+# Option to build tests
+#
+build_tests=yes
+AC_ARG_ENABLE([tests], AS_HELP_STRING([--disable-tests],
+ [do not build tests]),
+ build_tests=$enableval, build_tests=yes)
+AM_CONDITIONAL([BUILD_TESTS], [test "x$build_tests" = xyes ])

AC_SUBST(LIBSCUTE_LT_CURRENT)
AC_SUBST(LIBSCUTE_LT_AGE)
@@ -298,11 +305,6 @@ AC_C_INLINE
# Checks for library functions.
AC_CHECK_FUNCS([ttyname localtime_r timegm stpcpy])

-# Test if tests can be run
-ok=yes
-AM_CONDITIONAL(RUN_TESTS, test "$ok" = "yes")
-
-
AH_BOTTOM([
/* Prefix all estream functions. */
#define _ESTREAM_EXT_SYM_PREFIX _scute_
--
2.39.3

Re: [PATCH scute] Add configure enable argument to build tests [ In reply to ]

gnupg-devel at gnupg

Jun 30, 2023, 7:31 AM

Post #2 of 6 (257 views)

Permalink

Hi,

please provide a description of your patch and why you need this. Also
check doc/HACKING please.

Shalom-Salam,

Werner

--
The pioneers of a warless world are the youth that
refuse military service. - A. Einstein

Re: [PATCH scute] Add configure enable argument to build tests [ In reply to ]

gnupg-devel at gnupg

Jun 30, 2023, 8:17 AM

Post #3 of 6 (257 views)

Permalink

On Fri, 30 Jun 2023 16:31:29 +0200
Werner Koch <wk@gnupg.org> wrote:

> Hi,
>
> please provide a description of your patch and why you need this. Also
> check doc/HACKING please.

I've created a Gentoo ebuild for scute built from the latest master
commit. Since Gentoo provides a boolean "test" USE flag the tests
should not be built or run when that flag is off. When it's on they
should be built and run of course.

You can see my ebuild that includes the patch I sent here:
https://github.com/jjakob/gentoo-overlay/blob/master/app-crypt/scute/scute-1.7.0_p20230424.ebuild

Regarding doc/HACKING, I already read it before submitting the patches,
is there a particular problem in them that I need to fix?

>
>
> Shalom-Salam,
>
> Werner
>

Re: [PATCH scute] Add configure enable argument to build tests [ In reply to ]

bernhard at intevation

Jul 13, 2023, 8:15 AM

Post #4 of 6 (242 views)

Permalink

Hi Jernej,

Am Freitag 30 Juni 2023 17:17:46 schrieb Jernej Jakob via Gnupg-devel:
> Regarding doc/HACKING, I already read it before submitting the patches,
> is there a particular problem in them that I need to fix?

had a brief look: What about the one line summary
and the DCO?

Regards,
Bernhard

--
https://intevation.de/~bernhard +49 541 33 508 3-3
Intevation GmbH, Osnabrück, DE; Amtsgericht Osnabrück, HRB 18998
Geschäftsführer Frank Koormann, Bernhard Reiter

Re: [PATCH scute] Add configure enable argument to build tests [ In reply to ]

gnupg-devel at gnupg

Jul 13, 2023, 9:45 AM

Post #5 of 6 (242 views)

Permalink

On Thu, 13 Jul 2023 17:15:15 +0200
Bernhard Reiter <bernhard@intevation.de> wrote:

> Hi Jernej,
>
> Am Freitag 30 Juni 2023 17:17:46 schrieb Jernej Jakob via Gnupg-devel:
> > Regarding doc/HACKING, I already read it before submitting the patches,
> > is there a particular problem in them that I need to fix?
>
> had a brief look: What about the one line summary
> and the DCO?

I sent this patch, the DCO and another patch for scute on the same day.
I thought those other two mails were still waiting for manual approval
because I never saw them on the mailing list archives. Maybe they got
caught by spam filters?

Is "Add configure enable argument to build tests" the one-line summary
you mean? I put that in the message subject, I should have put it in the
message body too.

>
> Regards,
> Bernhard
>

Re: [PATCH scute] Add configure enable argument to build tests [ In reply to ]

bernhard at intevation

Jul 14, 2023, 12:13 AM

Post #6 of 6 (242 views)

Permalink

Am Donnerstag 13 Juli 2023 18:45:47 schrieb Jernej Jakob via Gnupg-devel:
> > had a brief look: What about the one line summary
> > and the DCO?
>
> I sent this patch, the DCO and another patch for scute on the same day.
> I thought those other two mails were still waiting for manual approval
> because I never saw them on the mailing list archives. Maybe they got
> caught by spam filters?

I also didn't see these emails on the list, so maybe they were caught
in moderation. You could try to send them again. Maybe you did use a different
From: by accident

Note that it sometimes takes a long while until a submitted patch will be
evaluated. It is okay to ask about the status once in a while, e.g. after a
months or so, depending on the importance of the patch.

> Is "Add configure enable argument to build tests" the one-line summary
> you mean? I put that in the message subject, I should have put it in the
> message body too.

Good question, maybe it was fine, but could have been more specific.
I'm just trying to guess what Werner was referring to.

Best,
Bernhard

--
https://intevation.de/~bernhard +49 541 33 508 3-3
Intevation GmbH, Osnabrück, DE; Amtsgericht Osnabrück, HRB 18998
Geschäftsführer Frank Koormann, Bernhard Reiter

Mailing List Archive

Attached Files:

Attached Files:

Attached Files: