Mailing List Archive

On 19:59 Fri 14 Dec , Markus Dittrich (markusle) wrote:
> Index: paraview-3.2.1.ebuild
> ===================================================================
> # Copyright 1999-2007 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> # $Header: /var/cvsroot/gentoo-x86/sci-visualization/paraview/paraview-3.2.1.ebuild,v 1.1 2007/12/14 19:59:46 markusle Exp $
>
> inherit distutils eutils flag-o-matic toolchain-funcs versionator python

I'm surprised to see this not using cmake-utils.eclass.

> src_compile() {
> cd "${BUILDDIR}"
> local CMAKE_VARIABLES=""
> CMAKE_VARIABLES="${CMAKE_VARIABLES} -DPV_INSTALL_LIB_DIR:PATH=/${PVLIBDIR}"
> CMAKE_VARIABLES="${CMAKE_VARIABLES} -DCMAKE_SKIP_RPATH:BOOL=YES"
> CMAKE_VARIABLES="${CMAKE_VARIABLES} -DVTK_USE_RPATH:BOOL=OFF"
> CMAKE_VARIABLES="${CMAKE_VARIABLES} -DCMAKE_INSTALL_PREFIX:PATH=/usr"
> CMAKE_VARIABLES="${CMAKE_VARIABLES} -DBUILD_SHARED_LIBS:BOOL=ON"

...

Since this seems to go beyond the standard variable naming for cmake,
you could set up custom functions based on cmake-utils _use_me_now() for
e.g. VTK_USE, PARAVIEW_USE, CMAKE_USE. Also seems like this would be a
lot easier to read if it were a multiline variable...

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list