Mailing List Archive

Re: [gentoo-commits] gentoo-x86 commit in gnome-extra/gnome-power-manager: ChangeLog gnome-power-manager-2.20.0.ebuild
On 16:41 Tue 02 Oct , Saleem Abdulrasool (compnerd) wrote:
> 1.1 gnome-extra/gnome-power-manager/gnome-power-manager-2.20.0.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/gnome-extra/gnome-power-manager/gnome-power-manager-2.20.0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/gnome-extra/gnome-power-manager/gnome-power-manager-2.20.0.ebuild?rev=1.1&content-type=text/plain

> ${S}/docs/Makefile.in
> sed -i -e 's:@HAVE_DOCBOOK2MAN_TRUE@.*::' ${S}/man/Makefile.in

Quoting

> src_test() {
> Xmake check || die "Test phase failed"

Is Xmake/virtualx.eclass still needed?

> if [[ $(portageq has_version / 'sys-libs/pam') ]] ; then

You don't need to call portageq, you're already inside portage.

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list
Re: Re: [gentoo-commits] gentoo-x86 commit in gnome-extra/gnome-power-manager: ChangeLog gnome-power-manager-2.20.0.ebuild [ In reply to ]
On 22:58 Tue 02 Oct , Donnie Berkholz wrote:
> On 16:41 Tue 02 Oct , Saleem Abdulrasool (compnerd) wrote:
> > if [[ $(portageq has_version / 'sys-libs/pam') ]] ; then
>
> You don't need to call portageq, you're already inside portage.

Oh yes, this also is broken for ROOT != /. Just wanted to make sure that
didn't slip through when you change it.

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list