Mailing List Archive

On Wed, Sep 26, 2007 at 06:41:50AM +0000, Mike Frysinger (vapier) wrote:
> - if [[ -f "${ROOT}/etc/conf.d/$1" ]]; then
> + if [[ -f ${ROOT}/etc/conf.d/$1 ]]; then
You removed the quotes here - $ROOT with spaces?
> - [[ -e "${ROOT}etc/${x}" ]] && continue
> - [[ -e "${ROOT}usr/share/baselayout/${x}" ]] || continue
> - cp -p "${ROOT}usr/share/baselayout/${x}" ${ROOT}etc
> + [[ -e ${ROOT}etc/${x} ]] && continue
> + [[ -e ${ROOT}usr/share/baselayout/${x} ]] || continue
> + cp -p "${ROOT}usr/share/baselayout/${x}" "${ROOT}"etc
2 removes, one add. Make up your mind.

> - for f in ${ROOT}etc/init.d/net.*; do
> - [[ -L ${f} || ${f} == "${ROOT}etc/init.d/${lo}" ]] && continue
> + for f in "${ROOT}"etc/init.d/net.*; do
> + [[ -L ${f} || ${f} == */${lo} ]] && continue
Again the quotes, and that conditional looks iffy, it was checking
against ${ROOT}/etc/init.d/net.lo before, and now it's checking against
${PWD}/*/net.lo?

> - if [[ -e "${ROOT}"/etc/env.d/01hostname ]] ; then
> + if [[ -e ${ROOT}/etc/env.d/01hostname ]] ; then
...
> - if [[ -e "${ROOT}"/etc/init.d/domainname ]] ; then
> + if [[ -e ${ROOT}/etc/init.d/domainname ]] ; then
Again with the quotes.

--
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail : robbat2@gentoo.org
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85