Mailing List Archive: Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6

Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

Sep 24, 2007, 2:48 AM

Post #1 of 4 (118 views)

On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
> rbrown 07/09/24 09:38:33
>
> Modified: ChangeLog
> Added: ruby-1.8.6_p110.ebuild
> Log:
> Version bump
> (Portage version: 2.1.3.9)

> 1.1 dev-lang/ruby/ruby-1.8.6_p110.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/ruby/ruby-1.8.6_p110.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/ruby/ruby-1.8.6_p110.ebuild?rev=1.1&content-type=text/plain

> SRC_URI="ftp://ftp.ruby-lang.org/pub/ruby/1.8/${MY_P}.tar.gz

> SLOT="1.8"

> !=dev-lang/ruby-cvs-1.8*

Would be nice to see all instances of 1.8 use hacked-up PV instead, for
easier bumps to 1.9 etc.

> econf --with-rubydir=${S} || die "econf failed"

> LD_LIBRARY_PATH=${D}/usr/$(get_libdir)
> RUBYLIB="${S}:${D}/usr/$(get_libdir)/ruby/${SLOT}"
> for d in $(find ${S}/ext -type d) ; do

> cp -pPR sample ${D}/usr/share/doc/${PF}

> cp -pPR test ${D}/usr/share/${PN}-${SLOT}

Quotes ...

> make DESTDIR="${D}" install-doc || die "make install-doc failed"

Why not emake?

> if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
> ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}

> if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
> ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
> fi

ROOT can have spaces in it too.

Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list

Re: Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild [ In reply to ]

vapier at gentoo

Sep 24, 2007, 3:18 AM

Post #2 of 4 (116 views)

Permalink

On Monday 24 September 2007, Donnie Berkholz wrote:
> On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
> > if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
> > ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
> >
> > if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
> > ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
> > fi
>
> ROOT can have spaces in it too.

this is why the form:
[[ -n $(readlink "${ROOT}"usr/bin/ruby) ]]
is preferred ... much easier to read and no nested quotes
-mike

Re: Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild [ In reply to ]

vapier at gentoo

Sep 24, 2007, 4:06 AM

Post #3 of 4 (118 views)

Permalink

On Monday 24 September 2007, René 'Necoro' Neumann wrote:
> Mike Frysinger schrieb:
> > On Monday 24 September 2007, Donnie Berkholz wrote:
> >> On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
> >>> if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
> >>> ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
> >>>
> >>> if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
> >>> ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
> >>> fi
> >>
> >> ROOT can have spaces in it too.
> >
> > this is why the form:
> > [[ -n $(readlink "${ROOT}"usr/bin/ruby) ]]
> > is preferred ... much easier to read and no nested quotes
>
> And: [[ ! -n ... ]] transforms to [[ -z ... ]]

! -n and -z are equivalent but there are no standards from the point of view
of Gentoo ... this is purely whatever logic happens to spew out of the head
of the developer as he composes the ebuild
-mike

Re: Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild [ In reply to ]

lists at necoro

Sep 24, 2007, 12:28 PM

Post #4 of 4 (118 views)

Permalink

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mike Frysinger schrieb:
> On Monday 24 September 2007, Donnie Berkholz wrote:
>> On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
>>> if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
>>> ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
>>>
>>> if [ ! -n "$(readlink ${ROOT}usr/bin/ruby)" ] ; then
>>> ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
>>> fi
>> ROOT can have spaces in it too.
>
> this is why the form:
> [[ -n $(readlink "${ROOT}"usr/bin/ruby) ]]
> is preferred ... much easier to read and no nested quotes
> -mike

And: [[ ! -n ... ]] transforms to [[ -z ... ]]

Or am I wrong?

Regards,
- -- Necoro
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG+A/04UOg/zhYFuARAg/dAJ9I5m/p7crLGG9JkIMu2vigtXlXVQCeLJwj
/zofTwO9Vtf+mu6EBYT8XiE=
=NIoO
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list

Mailing List Archive

Attached Files:

Attached Files: