Mailing List Archive: [RFC] custom-cflags global USE

[RFC] custom-cflags global USE

drizzt at gentoo

Feb 21, 2007, 6:32 AM

Post #1 of 14 (650 views)

What do you think about custom-cflags global USE?

app-emulation/xen-tools:custom-cflags - Use CFLAGS from /etc/make.conf
rather than the default Xen CFLAGS (not supported)
app-emulation/xen:custom-cflags - Use CFLAGS from /etc/make.conf rather
than the default Xen CFLAGS (not supported)
games-emulation/zsnes:custom-cflags - Enables custom cflags (not supported)
media-video/mplayer:custom-cflags - Enables custom cflags (not supported)
net-im/gaim:custom-cflags - Disables stripping of "unsafe C[XX]FLAGS"
sys-boot/grub:custom-cflags - Enables custom cflags (not supported)

It has (almost) the same meaning on all packages

--
Timothy `Drizzt` Redaelli - http://dev.gentoo.org/~drizzt/
FreeSBIE Developer, Gentoo Developer, GUFI Staff
There are two major products that come out of Berkeley: LSD and UNIX.
We don't believe this to be a coincidence. -- Jeremy S. Anderson

Re: [RFC] custom-cflags global USE [ In reply to ]

ciaranm at ciaranm

Feb 21, 2007, 10:12 AM

Post #2 of 14 (628 views)

On Wed, 21 Feb 2007 14:32:56 +0100 Timothy Redaelli <drizzt@gentoo.org>
wrote:
| What do you think about custom-cflags global USE?

I think it encourages policy violations.

http://devmanual.gentoo.org/general-concepts/user-environment/index.html

--
Ciaran McCreesh
Mail : ciaranm at ciaranm.org
Web : http://ciaranm.org/
Paludis, the secure package manager : http://paludis.pioto.org/

Re: [RFC] custom-cflags global USE [ In reply to ]

drizzt at gentoo

Feb 21, 2007, 10:25 AM

Post #3 of 14 (633 views)

Ciaran McCreesh wrote:
> On Wed, 21 Feb 2007 14:32:56 +0100 Timothy Redaelli <drizzt@gentoo.org>
> wrote:
> | What do you think about custom-cflags global USE?
>
> I think it encourages policy violations.
>
> http://devmanual.gentoo.org/general-concepts/user-environment/index.html

I know the policy, but sometimes upstream does not want user CFLAGS,
zsnes developers will remove support for Gentoo hosts from their bug
reports if i remove custom-cflags use and also mplayer.

Since some exceptions exists, i think we can globalize the USE without
any problem (with local USE the problem is the same, anyone can create a
port with custom-cflags local USE)

--
Timothy `Drizzt` Redaelli - http://dev.gentoo.org/~drizzt/
FreeSBIE Developer, Gentoo Developer, GUFI Staff
There are two major products that come out of Berkeley: LSD and UNIX.
We don't believe this to be a coincidence. -- Jeremy S. Anderson

Re: [RFC] custom-cflags global USE [ In reply to ]

kugelfang at gentoo

Feb 21, 2007, 10:46 AM

Post #4 of 14 (633 views)

Am Mittwoch, 21. Februar 2007 18:25 schrieb Timothy Redaelli:
> Ciaran McCreesh wrote:
> > On Wed, 21 Feb 2007 14:32:56 +0100 Timothy Redaelli
> > <drizzt@gentoo.org>
> >
> > wrote:
> > | What do you think about custom-cflags global USE?
> >
> > I think it encourages policy violations.
> >
> > http://devmanual.gentoo.org/general-concepts/user-environment/index
> >.html
>
> I know the policy, but sometimes upstream does not want user CFLAGS,
> zsnes developers will remove support for Gentoo hosts from their bug
> reports if i remove custom-cflags use and also mplayer.

What about making custom-cflags default in the base profile?

Danny
--
Danny van Dyk <kugelfang@gentoo.org>
Gentoo/AMD64 Project, Gentoo Scientific Project
--
gentoo-dev@gentoo.org mailing list

Re: [RFC] custom-cflags global USE [ In reply to ]

jakub at gentoo

Feb 21, 2007, 10:53 AM

Post #5 of 14 (625 views)

Danny van Dyk napsal(a):
> What about making custom-cflags default in the base profile?

Uhm? Maybe re-read the description of the flags? It's unsupported and
breaks stuff, that's why the use flag exists...

--
Best regards,

Jakub Moc
mailto:jakub@gentoo.org
GPG signature:
http://subkeys.pgp.net:11371/pks/lookup?op=get&search=0xCEBA3D9E
Primary key fingerprint: D2D7 933C 9BA1 C95B 2C95 B30F 8717 D5FD CEBA 3D9E

... still no signature ;)

Re: [RFC] custom-cflags global USE [ In reply to ]

msterret at coat

Feb 21, 2007, 10:54 AM

Post #6 of 14 (630 views)

How about we just leave them as local use flags and move on? global
vs. local is more then just about number of packages using the flag.
It has more to do with, "Is this flag globally useful and relevant."
So far, I haven't seen a recently suggest local use flag that cries out
to be made global.

Michael Sterrett
-Mr. Bones.-
mr_bones_@gentoo.org

On Wed, 21 Feb 2007, Danny van Dyk wrote:

> Am Mittwoch, 21. Februar 2007 18:25 schrieb Timothy Redaelli:
>> Ciaran McCreesh wrote:
>>> On Wed, 21 Feb 2007 14:32:56 +0100 Timothy Redaelli
>>> <drizzt@gentoo.org>
>>>
>>> wrote:
>>> | What do you think about custom-cflags global USE?
>>>
>>> I think it encourages policy violations.
>>>
>>> http://devmanual.gentoo.org/general-concepts/user-environment/index
>>> .html
>>
>> I know the policy, but sometimes upstream does not want user CFLAGS,
>> zsnes developers will remove support for Gentoo hosts from their bug
>> reports if i remove custom-cflags use and also mplayer.
>
> What about making custom-cflags default in the base profile?
>
> Danny
> --
> Danny van Dyk <kugelfang@gentoo.org>
> Gentoo/AMD64 Project, Gentoo Scientific Project
> --
> gentoo-dev@gentoo.org mailing list
>
>
--
gentoo-dev@gentoo.org mailing list

Re: [RFC] custom-cflags global USE [ In reply to ]

ciaranm at ciaranm

Feb 21, 2007, 11:32 AM

Post #7 of 14 (626 views)

On Wed, 21 Feb 2007 18:53:47 +0100 Jakub Moc <jakub@gentoo.org> wrote:
| Danny van Dyk napsal(a):
| > What about making custom-cflags default in the base profile?
|
| Uhm? Maybe re-read the description of the flags? It's unsupported and
| breaks stuff, that's why the use flag exists...

And not using user CFLAGS is unsupported and breaks things horribly on
several archs.

--
Ciaran McCreesh
Mail : ciaranm at ciaranm.org
Web : http://ciaranm.org/
Paludis, the secure package manager : http://paludis.pioto.org/

Re: [RFC] custom-cflags global USE [ In reply to ]

lu_zero at gentoo

Feb 21, 2007, 1:30 PM

Post #8 of 14 (626 views)

Ciaran McCreesh wrote:
> On Wed, 21 Feb 2007 18:53:47 +0100 Jakub Moc <jakub@gentoo.org> wrote:
> | Danny van Dyk napsal(a):
> | > What about making custom-cflags default in the base profile?
> |
> | Uhm? Maybe re-read the description of the flags? It's unsupported and
> | breaks stuff, that's why the use flag exists...
>
> And not using user CFLAGS is unsupported and breaks things horribly on
> several archs.
>

Upstream is willing to heard good bug reports about it possibly with
patches to improve the support on such arches =)

lu

--

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero

--
gentoo-dev@gentoo.org mailing list

Re: [RFC] custom-cflags global USE [ In reply to ]

carlo at gentoo

Feb 22, 2007, 5:40 PM

Post #9 of 14 (631 views)

On Mittwoch, 21. Februar 2007, Timothy Redaelli wrote:
> What do you think about custom-cflags global USE?

I'd be pleased to see the flag removed. I think it's up to the maintainers, if
they accept bug reports due to custom cflags, even though upstream doesn't or
restrict them for other reasons. If people care so much about it, there's
always your local overlay.

And I'd be fond of having all the -ffast-math filtering ripped out of the tree
as well.

Carsten

Re: [RFC] custom-cflags global USE [ In reply to ]

wolf31o2 at gentoo

Feb 23, 2007, 1:48 AM

Post #10 of 14 (625 views)

On Fri, 2007-02-23 at 01:40 +0100, Carsten Lohrke wrote:
> And I'd be fond of having all the -ffast-math filtering ripped out of the tree
> as well.

Except some things really do not compile with it enabled. Now, if
you're meaning you'd prefer patch every compilation failure using
-ffast-math instead, then I'd say go for it. Patches are always a
better solution than workarounds.

--
Chris Gianelloni
Release Engineering Strategic Lead
Alpha/AMD64/x86 Architecture Teams
Games Developer/Council Member/Foundation Trustee
Gentoo Foundation

Re: [RFC] custom-cflags global USE [ In reply to ]

vapier at gentoo

Feb 23, 2007, 4:41 AM

Post #11 of 14 (629 views)

On Friday 23 February 2007, Chris Gianelloni wrote:
> On Fri, 2007-02-23 at 01:40 +0100, Carsten Lohrke wrote:
> > And I'd be fond of having all the -ffast-math filtering ripped out of the
> > tree as well.
>
> Except some things really do not compile with it enabled. Now, if
> you're meaning you'd prefer patch every compilation failure using
> -ffast-math instead, then I'd say go for it. Patches are always a
> better solution than workarounds.

filtering encourages users to continue to put -ffast-math into their global
CFLAGS ... this is just plain wrong

ignoring compile issues, fast math can break runtime code that actually
requires the IEEE compliant behavior ... the only people who know
whether -ffast-math is safe are the upstream maintainers ... leave using the
flag to them
-mike

Re: [RFC] custom-cflags global USE [ In reply to ]

carlo at gentoo

Feb 23, 2007, 6:20 AM

Post #12 of 14 (626 views)

On Freitag, 23. Februar 2007, Chris Gianelloni wrote:
> Except some things really do not compile with it enabled. Now, if
> you're meaning you'd prefer patch every compilation failure using
> -ffast-math instead, then I'd say go for it. Patches are always a
> better solution than workarounds.

I mean that having this flag set globally is plain stupid and everyone doing
so deserves to deal with the consequences. Mike pointed out why.

Carsten

Re: [RFC] custom-cflags global USE [ In reply to ]

pauldv at gentoo

Feb 24, 2007, 8:01 AM

Post #13 of 14 (627 views)

On Friday 23 February 2007, Chris Gianelloni wrote:
> On Fri, 2007-02-23 at 01:40 +0100, Carsten Lohrke wrote:
> > And I'd be fond of having all the -ffast-math filtering ripped out of the
> > tree as well.
>
> Except some things really do not compile with it enabled. Now, if
> you're meaning you'd prefer patch every compilation failure using
> -ffast-math instead, then I'd say go for it. Patches are always a
> better solution than workarounds.

Except that software not working with -ffast-math is not in the wrong at all.
It is like specifying -fno-rtti for a c++ program. If rtti is not used, this
is fine. It is a part of the standard however, and this makes the compiler
not except all standard-compliant code. These options are there to enable
better code generation when it is known that the named features are not
needed. They should never be globally enabled.

Paul

--
Paul de Vrieze
Gentoo Developer
Mail: pauldv@gentoo.org
Homepage: http://www.devrieze.net

Re: [RFC] custom-cflags global USE [ In reply to ]

dirtyepic at gentoo

Jun 17, 2008, 1:16 AM

Post #14 of 14 (628 views)

Carsten Lohrke wrote:

> And I'd be fond of having all the -ffast-math filtering ripped out of the tree
> as well.

Please include -ftree-vectorize and -ftree-loop-linear along with that.
I've yet to see a GCC release where they work correctly, including 4.2.

--
by design, by neglect
dirtyepic gentoo org for a fact or just for effect
9B81 6C9F E791 83BB 3AB3 5B2D E625 A073 8379 37E8 (0x837937E8)