Mailing List Archive

[PATCH 1/2] python-utils-r1.eclass: add and use _python_check_EPYTHON
Signed-off-by: Florian Schmaus <flow@gentoo.org>
---
eclass/python-utils-r1.eclass | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
index 4fedf939c779..c729651699dd 100644
--- a/eclass/python-utils-r1.eclass
+++ b/eclass/python-utils-r1.eclass
@@ -1250,6 +1250,16 @@ build_sphinx() {
HTML_DOCS+=( "${dir}/_build/html/." )
}

+# @FUNCTION: _python_check_EPYTHON
+# @INTERNAL
+# @DESCRIPTION:
+# Check if EPYTHON is set, die if not.
+_python_check_EPYTHON() {
+ if [[ -z ${EPYTHON} ]]; then
+ die "EPYTHON unset, invalid call context"
+ fi
+}
+
# @VARIABLE: EPYTEST_DESELECT
# @DEFAULT_UNSET
# @DESCRIPTION:
@@ -1279,7 +1289,7 @@ build_sphinx() {
epytest() {
debug-print-function ${FUNCNAME} "${@}"

- [[ -n ${EPYTHON} ]] || die "EPYTHON unset, invalid call context"
+ _python_check_EPYTHON

local args=(
# verbose progress reporting and tracebacks
@@ -1322,7 +1332,7 @@ epytest() {
eunittest() {
debug-print-function ${FUNCNAME} "${@}"

- [[ -n ${EPYTHON} ]] || die "EPYTHON unset, invalid call context"
+ _python_check_EPYTHON

set -- "${EPYTHON}" -m unittest_or_fail discover -v "${@}"

--
2.32.0
Re: [PATCH 1/2] python-utils-r1.eclass: add and use _python_check_EPYTHON [ In reply to ]
On Mon, 2021-09-13 at 09:47 +0200, Florian Schmaus wrote:
> Signed-off-by: Florian Schmaus <flow@gentoo.org>
> ---
> eclass/python-utils-r1.eclass | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>

Both patches LGTM.

--
Best regards,
Micha? Górny
Re: [PATCH 1/2] python-utils-r1.eclass: add and use _python_check_EPYTHON [ In reply to ]
On 13/09/2021 10.15, Micha? Górny wrote:
> On Mon, 2021-09-13 at 09:47 +0200, Florian Schmaus wrote:
>> Signed-off-by: Florian Schmaus <flow@gentoo.org>
>> ---
>> eclass/python-utils-r1.eclass | 14 ++++++++++++--
>> 1 file changed, 12 insertions(+), 2 deletions(-)
>>
>
> Both patches LGTM.

Applied.

- Flow