Mailing List Archive

[Bug 401] DomainKeys dk_transport_write_message doesn't unlink an existing -K spool file
http://www.exim.org/bugzilla/show_bug.cgi?id=401





------- Additional Comments From bugzilla.exim.simon@arlott.org 2006-10-30 12:05 -------
Created an attachment (id=24)
--> (http://www.exim.org/bugzilla/attachment.cgi?id=24&action=view)
Unlink any existing -K spool file before trying to create it




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

--
## List details at http://www.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 401] DomainKeys dk_transport_write_message doesn't unlink an existing -K spool file [ In reply to ]
http://www.exim.org/bugzilla/show_bug.cgi?id=401


tom@duncanthrax.net changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|ph10@hermes.cam.ac.uk |tom@duncanthrax.net




------- Additional Comments From tom@duncanthrax.net 2006-10-30 18:27 -------
Thanks! Will be applied shortly.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

--
## List details at http://www.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 401] DomainKeys dk_transport_write_message doesn't unlink an existing -K spool file [ In reply to ]
http://www.exim.org/bugzilla/show_bug.cgi?id=401


tom@duncanthrax.net changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED






------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

--
## List details at http://www.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 401] DomainKeys dk_transport_write_message doesn't unlink an existing -K spool file [ In reply to ]
http://www.exim.org/bugzilla/show_bug.cgi?id=401


tom@duncanthrax.net changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED




------- Additional Comments From tom@duncanthrax.net 2006-10-30 22:04 -------
Did it in another way:

1) Create the -K file with an additional pid prefix to completely
rule out concurrency problems.
2) Change O_EXCL to O_TRUNC on file open to enable silent overwrite
of eventually existing file.
3) Use linux-style sendfile() call to send the -K file (when availablen,
and when TLS is not used). This should give a slight I/O performance
improvement.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

--
## List details at http://www.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##