Mailing List Archive

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #26 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
Great...now I am seeing the problem with an account where the mailbox is empty.
I think I saw that in the past as well and it could be solved by removing an
exim_filter rule. The thing is that this filter_rules works for most mailboxes
but for some it causes suddenly problems.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #27 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
I finally opened a bug here: https://github.com/PCRE2Project/pcre2/issues/376

But I don't like that bug report since I am not really feeling qualified to
actually do it and probably won't be able to answer further questions if the
pcre2-maintainers will ask them.

Maybe others can contribute to the bug report.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #28 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
(In reply to Simon Arlott from comment #21)
> (In reply to Andrew Aitchison from comment #20)
> > This patch (against 4.97.1) should tell us whether PCRE wants too much
> > store, or a negative amount.
>
> PCRE2_SIZE is size_t, so the value of "size" cannot be negative.
>
> What's needed is a reliable way to reproduce it.
>
> All I get is a request for 112 bytes for each and every check_dir_size().

The problem is that I need a mail to reproduce it and that's hard to get by.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #29 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
Ok, the last problem encountered is again the problem with the number of mails
but this time over all subfolders

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #30 from Jeremy Harris <jgh146exb@wizmail.org> ---
Created attachment 1466
--> https://bugs.exim.org/attachment.cgi?id=1466&action=edit
check_dir_size() free memory every 1000 files

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #31 from Simon Arlott <bugzilla.exim.simon@arlott.org> ---
(In reply to Niels Kobschaetzki from comment #27)
> I finally opened a bug here: https://github.com/PCRE2Project/pcre2/issues/376
>
> But I don't like that bug report since I am not really feeling qualified to
> actually do it and probably won't be able to answer further questions if the
> pcre2-maintainers will ask them.
>
> Maybe others can contribute to the bug report.

This is an Exim bug so you should close the bug report.


(In reply to Jeremy Harris from comment #30)
> Created attachment 1466 [details]
> check_dir_size() free memory every 1000 files

It looks like the interface with PCRE2 is supposed to automatically free the
memory, shouldn't that happen instead of needing to do this? I didn't see any
calls to function_store_free() in my testing.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #32 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
(In reply to Simon Arlott from comment #31)
> (In reply to Niels Kobschaetzki from comment #27)
> > I finally opened a bug here: https://github.com/PCRE2Project/pcre2/issues/376
> >
> > But I don't like that bug report since I am not really feeling qualified to
> > actually do it and probably won't be able to answer further questions if the
> > pcre2-maintainers will ask them.
> >
> > Maybe others can contribute to the bug report.
>
> This is an Exim bug so you should close the bug report.
>
>
> (In reply to Jeremy Harris from comment #30)
> > Created attachment 1466 [details]
> > check_dir_size() free memory every 1000 files
>
> It looks like the interface with PCRE2 is supposed to automatically free the
> memory, shouldn't that happen instead of needing to do this? I didn't see
> any calls to function_store_free() in my testing.

I was told in comment 12 that I should open a bug report with the
pcre2-project…

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #33 from Andrew Aitchison <exim@aitchison.me.uk> ---
(In reply to Simon Arlott from comment #31)
> (In reply to Niels Kobschaetzki from comment #27)
> > I finally opened a bug here: https://github.com/PCRE2Project/pcre2/issues/376
> >
> > But I don't like that bug report since I am not really feeling qualified to
> > actually do it and probably won't be able to answer further questions if the
> > pcre2-maintainers will ask them.
> >
> > Maybe others can contribute to the bug report.
>
> This is an Exim bug so you should close the bug report.
>
>
> (In reply to Jeremy Harris from comment #30)
> > Created attachment 1466 [details]
> > check_dir_size() free memory every 1000 files
>
> It looks like the interface with PCRE2 is supposed to automatically free the
> memory, shouldn't that happen instead of needing to do this? I didn't see
> any calls to function_store_free() in my testing.

If so, maybe we shouldn't close the PCRE2 bug just yet ?

I'm still worried that we truncate the size passed to us by PRCE2.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #34 from Simon Arlott <bugzilla.exim.simon@arlott.org> ---
(In reply to Andrew Aitchison from comment #33)
> > It looks like the interface with PCRE2 is supposed to automatically free the
> > memory, shouldn't that happen instead of needing to do this? I didn't see
> > any calls to function_store_free() in my testing.
>
> If so, maybe we shouldn't close the PCRE2 bug just yet ?

Only if PCRE2 is supposed to call Exim's free function at that time but
doesn't.

> I'm still worried that we truncate the size passed to us by PRCE2.

No, PCRE2 is only allocating 128 or 20480 bytes at a time. Exim is just
allocating memory in ever larger blocks until it refuses to allocate a 2GB
block.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #35 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
(In reply to Jeremy Harris from comment #30)
> Created attachment 1466 [details]
> check_dir_size() free memory every 1000 files

A first test looks good with that patch

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #36 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
A second test works as well, I will add it to the production systems and then
we will see...

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #37 from Niels Kobschaetzki <niels@kobschaetzki.net> ---
I rolled the patched version out in production and so far it is looking good.

Shall I close the bug report with pcre2?

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #38 from Jeremy Harris <jgh146exb@wizmail.org> ---
I'd suggest leaving it from them to decide whether inflating their memory
use by 18400 % between versions 10.34 and 10.42 constitutes a bug.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

Andrew Aitchison <exim@aitchison.me.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.exim.org/show_
| |bug.cgi?id=3072

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

Jeremy Harris <jgh146exb@wizmail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #39 from Andrew Aitchison <exim@aitchison.me.uk> ---
Re comments 6, 8 and 9, did anyone enable *both* calls to pcre2_match_data_free
?

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #40 from Jeremy Harris <jgh146exb@wizmail.org> ---
On investigation, it wouldn't help (which I should have realised).
The allocate uses Exim's memory management which does not support
individual alloc block free; only a mass release of a stack of
allocations.

The issue should be addressed by commits b4e7527561f1 and 35aacb69f5c8.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

Fabian Groffen <grobian@gentoo.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |grobian@gentoo.org

--- Comment #41 from Fabian Groffen <grobian@gentoo.org> ---
We have a Gentoo user who reports a lot of left files in spool directory after
applying the two changesets. https://bugs.gentoo.org/922780#c7

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #42 from Jeremy Harris <jgh146exb@wizmail.org> ---
(In reply to Fabian Groffen from comment #41)
> We have a Gentoo user who reports a lot of left files in spool directory
> after applying the two changesets. https://bugs.gentoo.org/922780#c7

Insufficient info. What sorts of files? New ones? What *else* did they
change?

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

https://bugs.exim.org/show_bug.cgi?id=3047

--- Comment #43 from Jeremy Harris <jgh146exb@wizmail.org> ---
Commits b4e7527561f1, 35aacb69f5c8, 84add256b346 so far.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/