Mailing List Archive

[Bug 3039] "log_write called with no log flags set" when log_reject_target empty
https://bugs.exim.org/show_bug.cgi?id=3039

Jeremy Harris <jgh146exb@wizmail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--- Comment #1 from Jeremy Harris <jgh146exb@wizmail.org> ---
Can't repro, at least under "-bh" :-

01:01:01 p1234 LOG: smtp_connection MAIN
01:01:01 p1234 SMTP connection from [127.0.0.2]
01:01:01 p1234 host in host_lookup? no (option unset)
01:01:01 p1234 set_process_info: pppp handling incoming connection from
[127.0.0.2]
01:01:01 p1234 host in host_reject_connection? no (option unset)
01:01:01 p1234 host in sender_unqualified_hosts? no (option unset)
01:01:01 p1234 host in recipient_unqualified_hosts? no (option unset)
01:01:01 p1234 host in helo_verify_hosts? no (option unset)
01:01:01 p1234 host in helo_try_verify_hosts? no (option unset)
01:01:01 p1234 host in helo_accept_junk_hosts? no (option unset)
01:01:01 p1234 using ACL "check_conn"
01:01:01 p1234 processing "deny" (TESTSUITE/test-config 21)
01:01:01 p1234 check hosts = 127.0.0.2
01:01:01 p1234 host in "127.0.0.2"?
01:01:01 p1234 list element: 127.0.0.2
01:01:01 p1234 host in "127.0.0.2"? yes (matched "127.0.0.2")
01:01:01 p1234 check log_reject_target =
01:01:01 p1234 deny: condition test succeeded in ACL "check_conn"
01:01:01 p1234 end of ACL "check_conn": DENY
01:01:01 p1234 SMTP>> 550 Administrative prohibition
01:01:01 p1234 search_tidyup called
01:01:01 p1234 >>>>>>>>>>>>>>>> Exim pid=p1234 (fresh-exec) terminating with
rc=0 >>>>>>>>>>>>>>>>

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/
[Bug 3039] "log_write called with no log flags set" when log_reject_target empty [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=3039

--- Comment #2 from Matthew Frost <matthewf-eximbugzilla@shop.frost.net> ---
I agree it doesn't show up under -bh.

log.c line 967 seems to be the source of the check:

/* If no log file is specified, we are in a mess. */

if (!(flags & (LOG_MAIN|LOG_PANIC|LOG_REJECT)))
log_write(0, LOG_MAIN|LOG_PANIC_DIE, "log_write called with no log "
"flags set");

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/
[Bug 3039] "log_write called with no log flags set" when log_reject_target empty [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=3039

--- Comment #3 from Jeremy Harris <jgh146exb@wizmail.org> ---
Nor for an actual TCP connection:

17:51:49 5275 Process 5275 is handling incoming connection from [127.0.0.1]
17:51:49 5275 host in host_lookup? no (option unset)
17:51:49 5275 set_process_info: 5275 handling incoming connection from
[127.0.0.1]
17:51:49 5275 host in host_reject_connection? no (option unset)
17:51:49 5275 host in sender_unqualified_hosts? no (option unset)
17:51:49 5275 host in recipient_unqualified_hosts? no (option unset)
17:51:49 5275 host in helo_verify_hosts? no (option unset)
17:51:49 5275 host in helo_try_verify_hosts? no (option unset)
17:51:49 5275 host in helo_accept_junk_hosts? no (option unset)
17:51:49 5275 host in hosts_proxy? no (option unset)
17:51:49 5275 using ACL "check_conn"
17:51:49 5275 processing "deny" (/data/jgh/git/exim/test/test-config 23)
17:51:49 5275 ?considering: ${if eq {server}{server}}
17:51:49 5275 ?considering: server}{server}}
17:51:49 5275 ????????text: server
17:51:49 5275 ?considering: }{server}}
17:51:49 5275 ???expanding: server
17:51:49 5275 ??????result: server
17:51:49 5275 ?considering: server}}
17:51:49 5275 ????????text: server
17:51:49 5275 ?considering: }}
17:51:49 5275 ???expanding: server
17:51:49 5275 ??????result: server
17:51:49 5275 ???condition: eq {server}{server}
17:51:49 5275 ??????result: true
17:51:49 5275 ???expanding: ${if eq {server}{server}}
17:51:49 5275 ??????result: true
17:51:49 5275 check condition = ${if eq {server}{server}}
17:51:49 5275 = true
17:51:49 5275 check log_reject_target =
17:51:49 5275 deny: condition test succeeded in ACL "check_conn"
17:51:49 5275 end of ACL "check_conn": DENY
17:51:49 5275 SMTP>> 550 Administrative prohibition
17:51:49 5275 search_tidyup called
17:51:49 5275 >>>>>>>>>>>>>>>> Exim pid=5275 (daemon-accept) terminating with
rc=0 >>>>>>>>>>>>>>>>


Can you get a debug run of your daemon showing the issue?

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/
[Bug 3039] "log_write called with no log flags set" when log_reject_target empty [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=3039

--- Comment #4 from Matthew Frost <matthewf-eximbugzilla@shop.frost.net> ---
Of note, this is on port 465 with tls_on_connect_ports = 465

8872 processing "deny" (/usr/exim/configure 289)
8872 check hosts = 141.xx.xx.xx:141.xx.xx.xx
8872 host in "141.xx.xx.xx:141.xx.xx.xx"?
8872 list element: 141.xx.xx.xx
8872 list element: 141.xx.xx.xx
8872 host in "141.xx.xx.xx:141.xx.xx.xx"? yes (matched "141.xx.xx.xx")
8872 check log_reject_target =
8872 deny: condition test succeeded in ACL "acl_check_connection"
8872 end of ACL "acl_check_connection": DENY
8872 LOG: connection_reject
8872 H=[141.xx.xx.xx] I=[178.xx.xx.xx]:465 Ci=8872 dropped by 'connect'
ACLNULL
8872 LOG: MAIN PANIC DIE
8872 log_write called with no log flags set
8872 SMTP>> 421 Unexpected failure, please try later
c??R.].?s??089'??~
8872 SMTP>> 421 Unexpected failure, please try later
8872 SMTP<< i:W????0?,?(?$??
8872 SMTP>> 421 Unexpected failure, please try later
8872 SMTP<< ?????????k?j?i?h?9?8?7?6?????????2?.?*?&?????=?5???/?+?'?#??





?????????g?@???>?3?2?1?0?????????E?D?C?B?1?-?)?%?????<?/???A?????
8872 SMTP>> 421 Unexpected failure, please try later
8872 SMTP<< ????
???????C?
???
8872 SMTP>> 421 Unexpected failure, please try later
8872 SMTP<< ?
8872 SMTP>> 421 Unexpected failure, please try later
8872 search_tidyup called
8872 >>>>>>>>>>>>>>>> Exim pid=8872 (daemon-accept) terminating with rc=1
>>>>>>>>>>>>>>>>

The:

"dropped by 'connect' ACLNULL"

message appears to originate in smtp_in.c via log_connect_tls_drop

/* Run the connect ACL if it exists */

user_msg = NULL;
if (acl_smtp_connect)
{
int rc;
if ((rc = acl_check(ACL_WHERE_CONNECT, NULL, acl_smtp_connect, &user_msg,
&log_msg)) != OK)
{
#ifndef DISABLE_TLS
if (tls_in.on_connect)
log_connect_tls_drop(US"'connect' ACL", log_msg);
else
#endif
(void) smtp_handle_acl_fail(ACL_WHERE_CONNECT, rc, user_msg, log_msg);
return FALSE;
}
}

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/
[Bug 3039] "log_write called with no log flags set" when log_reject_target empty [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=3039

Jeremy Harris <jgh146exb@wizmail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |WAIT_FIX_CONFIRMATION
Target Milestone|Exim 4.97 |Exim 4.98
OS|FreeBSD |All
Priority|medium |low

--- Comment #5 from Jeremy Harris <jgh146exb@wizmail.org> ---
Bingo. Both smtps and a connection_reject log_selector are needed.

A bit of an odd combination, the log_selector and clearing log_reject_target -
but fixable. eb09d0da1fb9 addresses.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/
[Bug 3039] "log_write called with no log flags set" when log_reject_target empty [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=3039

Matthew Frost <matthewf-eximbugzilla@shop.frost.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|WAIT_FIX_CONFIRMATION |RESOLVED

--- Comment #6 from Matthew Frost <matthewf-eximbugzilla@shop.frost.net> ---
39839 check log_reject_target =
39839 deny: condition test succeeded in ACL "acl_check_connection"
39839 end of ACL "acl_check_connection": DENY
39839 search_tidyup called
39839 >>>>>>>>>>>>>>>> Exim pid=39839 (daemon-accept) terminating with rc=0
>>>>>>>>>>>>>>>>

eb09d0da1fb9 is working for me.

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/